[jira] [Commented] (HADOOP-17912) ABFS: Support for Encryption Context

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789006#comment-17789006 ] ASF GitHub Bot commented on HADOOP-17912: - saxenapranav commented on PR #6221: URL:

Re: [PR] HADOOP-17912. ABFS: Support for Encryption Context [hadoop]

2023-11-22 Thread via GitHub
saxenapranav commented on PR #6221: URL: https://github.com/apache/hadoop/pull/6221#issuecomment-1823908493 Hi @steveloughran , thank you so much for reviewing and approving the PR. I have backmerged the trunk and removed the conflict. Also, I have added the documentation in abfs.md for

[jira] [Commented] (HADOOP-18883) Expect-100 JDK bug resolution: prevent multiple server calls

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789005#comment-17789005 ] ASF GitHub Bot commented on HADOOP-18883: - saxenapranav commented on PR #6022: URL:

Re: [PR] HADOOP-18883. [ABFS]: Expect-100 JDK bug resolution: prevent multiple server calls [hadoop]

2023-11-22 Thread via GitHub
saxenapranav commented on PR #6022: URL: https://github.com/apache/hadoop/pull/6022#issuecomment-1823904909 Hi @steveloughran @mehakmeet @mukund-thakur , Requesting you to kindly review the PR please. This is PR to prevent day-0 JDK bug around expect-100 in abfs. Would be really awesome

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-22 Thread via GitHub
anmolanmol1234 commented on PR #6275: URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1823838318 Hi @steveloughran, I have made the changes for shaded client checks that were failing on the mockito upgrade. Requesting your review for the same. -- This is an automated message

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6275: URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1823806436 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17261. RBF: Fix getFileInfo return wrong path when get mountTable path which is multi-level [hadoop]

2023-11-22 Thread via GitHub
LiuGuH commented on code in PR #6288: URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402864449 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -2188,11 +2188,12 @@ private static

Re: [PR] HDFS-17261. RBF: Fix getFileInfo return wrong path when get mountTable path which is multi-level [hadoop]

2023-11-22 Thread via GitHub
LiuGuH commented on code in PR #6288: URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402864449 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -2188,11 +2188,12 @@ private static

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
LiuGuH commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1402860528 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

[jira] [Commented] (HADOOP-18967) Allow secure mode to be enabled with no downtime

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788935#comment-17788935 ] ASF GitHub Bot commented on HADOOP-18967: - hadoop-yetus commented on PR #6293: URL:

Re: [PR] HADOOP-18967 Allow no-downtime migration into secure mode [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6293: URL: https://github.com/apache/hadoop/pull/6293#issuecomment-1823698807 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18967) Allow secure mode to be enabled with no downtime

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788932#comment-17788932 ] ASF GitHub Bot commented on HADOOP-18967: - hadoop-yetus commented on PR #6293: URL:

Re: [PR] HADOOP-18967 Allow no-downtime migration into secure mode [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6293: URL: https://github.com/apache/hadoop/pull/6293#issuecomment-182369 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-11-22 Thread via GitHub
xinglin commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1823610335 TestDirectoryScanner unit test is failing non-deterministically (For example, it happened in https://github.com/apache/hadoop/pull/6266 as well). Besides, we did not touch anything

Re: [PR] HDFS-17262 Fixed the verbose log.warn in DFSUtil.addTransferRateMetric(). [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6290: URL: https://github.com/apache/hadoop/pull/6290#issuecomment-1823534623 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18967) Allow secure mode to be enabled with no downtime

2023-11-22 Thread Charles Connell (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Connell updated HADOOP-18967: - Fix Version/s: 3.4.0 Status: Patch Available (was: Open) > Allow secure

Re: [PR] HDFS-17261. RBF: Fix getFileInfo return wrong path when get mountTable path which is multi-level [hadoop]

2023-11-22 Thread via GitHub
goiri commented on code in PR #6288: URL: https://github.com/apache/hadoop/pull/6288#discussion_r1402611938 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -2188,11 +2188,12 @@ private static

Re: [PR] YARN-11613. [Federation] Router CLI Supports Delete SubClusterPolicyConfiguration Of Queues. [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6267: URL: https://github.com/apache/hadoop/pull/6267#issuecomment-1823245254 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Updated] (HADOOP-18967) Allow secure mode to be enabled with no downtime

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18967: Labels: pull-request-available (was: ) > Allow secure mode to be enabled with no

[jira] [Commented] (HADOOP-18967) Allow secure mode to be enabled with no downtime

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788825#comment-17788825 ] ASF GitHub Bot commented on HADOOP-18967: - charlesconnell opened a new pull request, #6293:

[PR] HADOOP-18967 Allow no-downtime migration into secure mode [hadoop]

2023-11-22 Thread via GitHub
charlesconnell opened a new pull request, #6293: URL: https://github.com/apache/hadoop/pull/6293 ### Description of PR This PR adds two new boolean settings to DataNodes: - `dfs.datanode.block.access.token.unsafe.allowed-not-required` -

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1822931221 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788807#comment-17788807 ] ASF GitHub Bot commented on HADOOP-18971: - hadoop-yetus commented on PR #6270: URL:

[jira] [Commented] (HADOOP-18987) Corrections to Hadoop FileSystem API Definition

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788790#comment-17788790 ] ASF GitHub Bot commented on HADOOP-18987: - hadoop-yetus commented on PR #6292: URL:

Re: [PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6292: URL: https://github.com/apache/hadoop/pull/6292#issuecomment-1822864150 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788774#comment-17788774 ] ASF GitHub Bot commented on HADOOP-18971: - saxenapranav commented on code in PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-22 Thread via GitHub
saxenapranav commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1402009495 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStreamReadFooter.java: ## @@ -387,8 +374,72 @@ private void

[jira] [Updated] (HADOOP-18987) Corrections to Hadoop FileSystem API Definition

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-18987: Labels: pull-request-available (was: ) > Corrections to Hadoop FileSystem API

[jira] [Commented] (HADOOP-18987) Corrections to Hadoop FileSystem API Definition

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788745#comment-17788745 ] ASF GitHub Bot commented on HADOOP-18987: - DieterDP-ng opened a new pull request, #6292: URL:

[PR] HADOOP-18987 Various fixes to FileSystem API docs [hadoop]

2023-11-22 Thread via GitHub
DieterDP-ng opened a new pull request, #6292: URL: https://github.com/apache/hadoop/pull/6292 ### Description of PR This PR contains documentation updates to [the Hadoop FileSystem API

[jira] [Created] (HADOOP-18987) Corrections to Hadoop FileSystem API Definition

2023-11-22 Thread Dieter De Paepe (Jira)
Dieter De Paepe created HADOOP-18987: Summary: Corrections to Hadoop FileSystem API Definition Key: HADOOP-18987 URL: https://issues.apache.org/jira/browse/HADOOP-18987 Project: Hadoop Common

[jira] [Commented] (HADOOP-17372) S3A AWS Credential provider loading gets confused with isolated classloaders

2023-11-22 Thread Antonio Murgia (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788742#comment-17788742 ] Antonio Murgia commented on HADOOP-17372: - I add a workaround for anyone having the same issue

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
slfan1989 commented on code in PR #6291: URL: https://github.com/apache/hadoop/pull/6291#discussion_r1401902539 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/resolver/MountTableResolver.java: ## @@ -357,7 +357,7 @@ public void

Re: [PR] HDFS-17233. The conf dfs.datanode.lifeline.interval.seconds is not co… [hadoop]

2023-11-22 Thread via GitHub
eshwitha commented on PR #6286: URL: https://github.com/apache/hadoop/pull/6286#issuecomment-1822495298 The above failure tests are not related to the changes made. They are passing in my local environment. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788699#comment-17788699 ] ASF GitHub Bot commented on HADOOP-18971: - saxenapranav commented on code in PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-22 Thread via GitHub
saxenapranav commented on code in PR #6270: URL: https://github.com/apache/hadoop/pull/6270#discussion_r1401789516 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java: ## @@ -811,13 +813,17 @@ private AbfsInputStreamContext

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1822446504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18613) Upgrade ZooKeeper to version 3.8.1

2023-11-22 Thread Szucs Villo (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788683#comment-17788683 ] Szucs Villo commented on HADOOP-18613: -- Hi [~BilwaST] , I'm not planning to work on this issue. If

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788685#comment-17788685 ] ASF GitHub Bot commented on HADOOP-18971: - hadoop-yetus commented on PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-22 Thread via GitHub
hadoop-yetus commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1822410567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: |

[jira] [Commented] (HADOOP-18971) ABFS: Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size

2023-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788680#comment-17788680 ] ASF GitHub Bot commented on HADOOP-18971: - anujmodi2021 commented on PR #6270: URL:

Re: [PR] HADOOP-18971: [ABFS] Enable Footer Read Optimizations with Appropriate Footer Read Buffer Size [hadoop]

2023-11-22 Thread via GitHub
anujmodi2021 commented on PR #6270: URL: https://github.com/apache/hadoop/pull/6270#issuecomment-1822396392 AGGREGATED TEST RESULT HNS-OAuth [INFO] Results: [INFO] [WARNING] Tests run: 141, Failures: 0,

Re: [PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
LiuGuH commented on PR #6291: URL: https://github.com/apache/hadoop/pull/6291#issuecomment-1822312358 @zhuxiangyi @ferhui @goiri , Do you have time to review this? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] HDFS-17263. [RBF] Fix client ls trash path cannot get except default nameservices trash path [hadoop]

2023-11-22 Thread via GitHub
LiuGuH opened a new pull request, #6291: URL: https://github.com/apache/hadoop/pull/6291 ### Description of PR https://issues.apache.org/jira/browse/HDFS-17263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub