[PR] HDFS-17390. [FGL] FSDirectory supports this fine-grained locking [hadoop]

2024-02-21 Thread via GitHub
ZanderXu opened a new pull request, #6573: URL: https://github.com/apache/hadoop/pull/6573 FSDirectory should holds read or write lock of FSLock, since it just involves directory tree-related operations. -- This is an automated message from the Apache Git Service. To respond to th

[PR] HDFS-17387. [FGL] Abstract selectable locking mode [hadoop]

2024-02-21 Thread via GitHub
ZanderXu opened a new pull request, #6572: URL: https://github.com/apache/hadoop/pull/6572 Splitting the current global FNS lock into FSLock and BMLock. Abstract these lock mode and make them selectable, so that end-user can choose to use global lock or fine-grained lock through conf

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1958788319 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[PR] HDFS-17394. [FGL] Remove unused WriteHoldCount of FSNamesystemLock [hadoop]

2024-02-21 Thread via GitHub
ZanderXu opened a new pull request, #6571: URL: https://github.com/apache/hadoop/pull/6571 ``` public int getWriteHoldCount() { return this.fsLock.getWriteHoldCount(FSNamesystemLockMode.GLOBAL); } @Deprecated // dirLock is obsolete, use namesystem.fsLock instead public in

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819483#comment-17819483 ] ASF GitHub Bot commented on HADOOP-18910: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-21 Thread via GitHub
anujmodi2021 commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1498704079 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/contracts/exceptions/AbfsInvalidChecksumException.java: ## @@ -0,0 +1,56 @@ +/** + * Licens

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1958776146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-02-21 Thread via GitHub
hfutatzhanghb commented on code in PR #6509: URL: https://github.com/apache/hadoop/pull/6509#discussion_r1498581949 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java: ## @@ -436,9 +442,17 @@ protected void recover()

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-02-21 Thread via GitHub
zhangshuyan0 commented on code in PR #6509: URL: https://github.com/apache/hadoop/pull/6509#discussion_r1498579433 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java: ## @@ -436,9 +442,17 @@ protected void recover() t

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-02-21 Thread via GitHub
hfutatzhanghb commented on code in PR #6509: URL: https://github.com/apache/hadoop/pull/6509#discussion_r1498576377 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java: ## @@ -436,9 +442,17 @@ protected void recover()

Re: [PR] HDFS-17358. EC: infinite lease recovery caused by the length of RWR equals to zero. [hadoop]

2024-02-21 Thread via GitHub
zhangshuyan0 commented on code in PR #6509: URL: https://github.com/apache/hadoop/pull/6509#discussion_r1498565609 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java: ## @@ -436,9 +442,17 @@ protected void recover() t

[jira] [Commented] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-21 Thread Kai Zheng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819454#comment-17819454 ] Kai Zheng commented on HADOOP-19085: Hi [~han.liu], since you're working on this, w

[jira] [Moved] (HADOOP-19085) Compatibility Benchmark over HCFS Implementations

2024-02-21 Thread Kai Zheng (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Zheng moved HDFS-17316 to HADOOP-19085: --- Key: HADOOP-19085 (was: HDFS-17316) Project: Hadoop Common (was:

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819448#comment-17819448 ] ASF GitHub Bot commented on HADOOP-19065: - huangzhaobo99 commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1958556471 Pipeline failed, but the local env launched docker image was successfully built and compiled. cc @tasanuma 1. Install Docker and run this command: ``` ./start-build-env.sh

Re: [PR] HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block [hadoop]

2024-02-21 Thread via GitHub
haiyang1987 commented on code in PR #6559: URL: https://github.com/apache/hadoop/pull/6559#discussion_r1498534965 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -188,6 +188,10 @@ public class DFSConfigKeys extends CommonConfigur

Re: [PR] YARN-11656 RMStateStore event queue blocked [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6569: URL: https://github.com/apache/hadoop/pull/6569#issuecomment-1958479227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1958262110 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Commented] (HADOOP-19083) hadoop binary tarball to exclude aws v2 sdk

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819401#comment-17819401 ] ASF GitHub Bot commented on HADOOP-19083: - hadoop-yetus commented on PR #6570:

Re: [PR] HADOOP-19083. hadoop binaries aws sdk unless -Pawssdk builds [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6570: URL: https://github.com/apache/hadoop/pull/6570#issuecomment-1958145264 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819386#comment-17819386 ] ASF GitHub Bot commented on HADOOP-18910: - mukund-thakur commented on PR #6069:

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-21 Thread via GitHub
mukund-thakur commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1957878931 `./hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:28:import java.nio.charset.StandardCharsets;:8: Unused import - java.nio.charset.St

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819385#comment-17819385 ] ASF GitHub Bot commented on HADOOP-18910: - mukund-thakur commented on code in P

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-21 Thread via GitHub
mukund-thakur commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1498282476 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStream.java: ## @@ -279,3 +283,17 @@ private void verifyAfterSeek(A

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819384#comment-17819384 ] ASF GitHub Bot commented on HADOOP-18910: - mukund-thakur commented on code in P

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-21 Thread via GitHub
mukund-thakur commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1498282476 ## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsInputStream.java: ## @@ -279,3 +283,17 @@ private void verifyAfterSeek(A

[jira] [Updated] (HADOOP-19083) hadoop binary tarball to exclude aws v2 sdk

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19083: Labels: pull-request-available (was: ) > hadoop binary tarball to exclude aws v2 sdk > -

[jira] [Commented] (HADOOP-19083) hadoop binary tarball to exclude aws v2 sdk

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819380#comment-17819380 ] ASF GitHub Bot commented on HADOOP-19083: - steveloughran opened a new pull requ

[jira] [Created] (HADOOP-19084) hadoop-common exports logback as a transitive dependency

2024-02-21 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19084: --- Summary: hadoop-common exports logback as a transitive dependency Key: HADOOP-19084 URL: https://issues.apache.org/jira/browse/HADOOP-19084 Project: Hadoop Commo

[jira] [Commented] (HADOOP-18910) ABFS: Adding Support for MD5 Hash based integrity verification of the request content during transport

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819379#comment-17819379 ] ASF GitHub Bot commented on HADOOP-18910: - mukund-thakur commented on code in P

Re: [PR] HADOOP-18910: [ABFS] Adding Support for MD5 Hash based integrity verification of the request content during transport [hadoop]

2024-02-21 Thread via GitHub
mukund-thakur commented on code in PR #6069: URL: https://github.com/apache/hadoop/pull/6069#discussion_r1498253744 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/contracts/exceptions/AbfsInvalidChecksumException.java: ## @@ -0,0 +1,56 @@ +/** + * Licen

[PR] YARN-11656 RMStateStore event queue blocked [hadoop]

2024-02-21 Thread via GitHub
K0K0V0K opened a new pull request, #6569: URL: https://github.com/apache/hadoop/pull/6569 ### Description of PR Created a MultiDispatcher class which implements the Dispatcher interface. The dispatcher replace the AsyncDispatcher in the RMStateStore. The Dispatcher creates a sepa

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819359#comment-17819359 ] ASF GitHub Bot commented on HADOOP-19065: - hadoop-yetus commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957664677 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819356#comment-17819356 ] ASF GitHub Bot commented on HADOOP-19065: - hadoop-yetus commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957645773 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Assigned] (HADOOP-19083) hadoop binary tarball to exclude aws v2 sdk

2024-02-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran reassigned HADOOP-19083: --- Assignee: Steve Loughran > hadoop binary tarball to exclude aws v2 sdk > -

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819337#comment-17819337 ] ASF GitHub Bot commented on HADOOP-19065: - hadoop-yetus commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957424893 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Created] (HADOOP-19083) hadoop binary tarball to exclude aws v2 sdk

2024-02-21 Thread Steve Loughran (Jira)
Steve Loughran created HADOOP-19083: --- Summary: hadoop binary tarball to exclude aws v2 sdk Key: HADOOP-19083 URL: https://issues.apache.org/jira/browse/HADOOP-19083 Project: Hadoop Common I

[jira] [Commented] (HADOOP-19071) Update maven-surefire-plugin from 3.0.0 to 3.2.5

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819336#comment-17819336 ] ASF GitHub Bot commented on HADOOP-19071: - shahrs87 commented on PR #6537: URL:

Re: [PR] HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. [hadoop]

2024-02-21 Thread via GitHub
shahrs87 commented on PR #6537: URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1957394370 Thank you @steveloughran for your response. > Rather than say "hey, let's revert", I'd propose a "surefire update triggers test failures" and see what can be done about addressing

[jira] [Commented] (HADOOP-18708) AWS SDK V2 - Implement CSE

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819335#comment-17819335 ] ASF GitHub Bot commented on HADOOP-18708: - steveloughran commented on PR #6164:

[jira] [Commented] (HADOOP-19050) Add S3 Access Grants Support in S3A

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819334#comment-17819334 ] ASF GitHub Bot commented on HADOOP-19050: - steveloughran commented on PR #6544:

Re: [PR] HADOOP-18708. AWS SDK V2 - Implement CSE [hadoop]

2024-02-21 Thread via GitHub
steveloughran commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1957376970 @ahmarsuhail can you rebase this and we can merge in to branch-3.4. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] HADOOP-19050. Add S3 Access Grants Support in S3A [hadoop]

2024-02-21 Thread via GitHub
steveloughran commented on PR #6544: URL: https://github.com/apache/hadoop/pull/6544#issuecomment-1957375191 really focused purely on 3.4.0 shipping right now, not looking at stuff it doesn't need. sorry -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819318#comment-17819318 ] ASF GitHub Bot commented on HADOOP-19065: - hadoop-yetus commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957214381 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957114687 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19082) S3A: Update AWS SDK V2 to 2.24.1

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819304#comment-17819304 ] ASF GitHub Bot commented on HADOOP-19082: - hadoop-yetus commented on PR #6568:

Re: [PR] HADOOP-19082: Update AWS SDK V2 to 2.24.1 [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6568: URL: https://github.com/apache/hadoop/pull/6568#issuecomment-1957074319 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819302#comment-17819302 ] ASF GitHub Bot commented on HADOOP-19065: - hadoop-yetus commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957048566 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819301#comment-17819301 ] ASF GitHub Bot commented on HADOOP-19065: - huangzhaobo99 commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957044724 @tasanuma Have completed, Whether or not need to modify the PR title? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819300#comment-17819300 ] ASF GitHub Bot commented on HADOOP-19065: - hadoop-yetus commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1957037784 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956867368 @tasanuma Thanks for the reminder. I will complete it after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819285#comment-17819285 ] ASF GitHub Bot commented on HADOOP-19065: - huangzhaobo99 commented on PR #6526:

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819282#comment-17819282 ] ASF GitHub Bot commented on HADOOP-19065: - tasanuma commented on PR #6526: URL:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
tasanuma commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956849499 @huangzhaobo99 Thanks for updating it, but there are still many mentions of Protocol Buffers 3.7.1 in BUILDING.txt. If we want to update all them to version 3.21.12, we firstly need to up

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819277#comment-17819277 ] ASF GitHub Bot commented on HADOOP-19065: - huangzhaobo99 commented on PR #6526:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
huangzhaobo99 commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956774830 > Although I'm not an expert in curl, I believe this change is fine as it aligns with the instruction for CMake. However, in the first place, protobuf 3.7.1 could be outdated. We hav

[jira] [Commented] (HADOOP-19082) Update AWS SDK V2 to 2.24.1

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819272#comment-17819272 ] ASF GitHub Bot commented on HADOOP-19082: - steveloughran commented on PR #6568:

[jira] [Updated] (HADOOP-19082) S3A: Update AWS SDK V2 to 2.24.1

2024-02-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran updated HADOOP-19082: Summary: S3A: Update AWS SDK V2 to 2.24.1 (was: Update AWS SDK V2 to 2.24.1) > S3A: Upd

Re: [PR] HADOOP-19082: Update AWS SDK V2 to 2.24.1 [hadoop]

2024-02-21 Thread via GitHub
steveloughran commented on PR #6568: URL: https://github.com/apache/hadoop/pull/6568#issuecomment-1956747625 * you will need to update LICENSE-binary * and run the hadoop-aws tests -where? * and run the "qualifying an SDK update" steps -where and what problems surfaced? -- This is a

[jira] [Commented] (HADOOP-19065) Improve Protocol Buffers install instructions.

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819270#comment-17819270 ] ASF GitHub Bot commented on HADOOP-19065: - tasanuma commented on PR #6526: URL:

Re: [PR] HADOOP-19065. Improve Protocol Buffers install instructions. [hadoop]

2024-02-21 Thread via GitHub
tasanuma commented on PR #6526: URL: https://github.com/apache/hadoop/pull/6526#issuecomment-1956740552 Although I'm not an expert in curl, I believe this change is fine as it aligns with the instruction for CMake. However, in the first place, protobuf 3.7.1 could be outdated. We have start

[jira] [Updated] (HADOOP-19082) Update AWS SDK V2 to 2.24.1

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HADOOP-19082: Labels: pull-request-available (was: ) > Update AWS SDK V2 to 2.24.1 > -

[jira] [Commented] (HADOOP-19082) Update AWS SDK V2 to 2.24.1

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819266#comment-17819266 ] ASF GitHub Bot commented on HADOOP-19082: - HarshitGupta11 opened a new pull req

[PR] HADOOP-19082: Update AWS SDK V2 to 2.24.1 [hadoop]

2024-02-21 Thread via GitHub
HarshitGupta11 opened a new pull request, #6568: URL: https://github.com/apache/hadoop/pull/6568 Update the AWS SDK to 2.24.1 from 2.23.5 for latest updates in packaging w.r.t. imds module. ### How was this patch tested? Integration Test using ```mvn clean verify -Dparallel-tests

[jira] [Commented] (HADOOP-18197) Update protobuf 3.7.1 to a version without CVE-2021-22569

2024-02-21 Thread Steve Loughran (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819229#comment-17819229 ] Steve Loughran commented on HADOOP-18197: - saw this in the context of surefire

Re: [PR] HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. [hadoop]

2024-02-21 Thread via GitHub
ayushtkn commented on PR #6537: URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1956562170 & some are failing due to protobuf upgrade as part of hadoop thirdparty upgrade, I am checking all the HDFS tests, but little slowly https://issues.apache.org/jira/browse/HADOOP-18197?

[jira] [Commented] (HADOOP-19071) Update maven-surefire-plugin from 3.0.0 to 3.2.5

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819220#comment-17819220 ] ASF GitHub Bot commented on HADOOP-19071: - ayushtkn commented on PR #6537: URL:

Re: [PR] HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. [hadoop]

2024-02-21 Thread via GitHub
ayushtkn commented on PR #6537: URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1956558036 Some tests are getting skipped as well as I mentioned on the jira https://issues.apache.org/jira/browse/HADOOP-19071?focusedCommentId=17818734&page=com.atlassian.jira.plugin.system.issu

Re: [PR] HDFS-17352. Add configuration to control whether DN delete this replica from disk when client requests a missing block [hadoop]

2024-02-21 Thread via GitHub
tomscut commented on code in PR #6559: URL: https://github.com/apache/hadoop/pull/6559#discussion_r1497454155 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java: ## @@ -188,6 +188,10 @@ public class DFSConfigKeys extends CommonConfiguratio

[jira] [Commented] (HADOOP-19071) Update maven-surefire-plugin from 3.0.0 to 3.2.5

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819215#comment-17819215 ] ASF GitHub Bot commented on HADOOP-19071: - steveloughran commented on PR #6537:

Re: [PR] HADOOP-19071. Update maven-surefire-plugin from 3.0.0 to 3.2.5. [hadoop]

2024-02-21 Thread via GitHub
steveloughran commented on PR #6537: URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1956544980 This is not good. But looking at the failures I don't know whether to categorise as "test runner regression" or "brittle tests failing under new test runner". Here are s

[jira] [Commented] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to SAS Token Provider class

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819148#comment-17819148 ] ASF GitHub Bot commented on HADOOP-18516: - anujmodi2021 commented on code in PR

Re: [PR] HADOOP-18516: [ABFS][Authentication] Support Fixed SAS Token for ABFS Authentication [hadoop]

2024-02-21 Thread via GitHub
anujmodi2021 commented on code in PR #6552: URL: https://github.com/apache/hadoop/pull/6552#discussion_r1497042989 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AbfsConfiguration.java: ## @@ -941,33 +941,66 @@ public AccessTokenProvider getTokenProvide

[jira] [Commented] (HADOOP-18516) [ABFS]: Support fixed SAS token config in addition to SAS Token Provider class

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819137#comment-17819137 ] ASF GitHub Bot commented on HADOOP-18516: - saxenapranav commented on code in PR

Re: [PR] HADOOP-18516: [ABFS][Authentication] Support Fixed SAS Token for ABFS Authentication [hadoop]

2024-02-21 Thread via GitHub
saxenapranav commented on code in PR #6552: URL: https://github.com/apache/hadoop/pull/6552#discussion_r1497115703 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java: ## @@ -332,6 +335,8 @@ public AbfsRestOperation setFilesystemProp

[PR] HDFS-17393. [FGL] Remove unused `cond` in FSNamesystem [hadoop]

2024-02-21 Thread via GitHub
ZanderXu opened a new pull request, #6567: URL: https://github.com/apache/hadoop/pull/6567 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP