[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845797#comment-17845797 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on PR #6752:

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845796#comment-17845796 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-12 Thread via GitHub
saxenapranav commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2106793214 > Looks good to me. Just some thoughts around test. > > Alos, if we do not already have, can we add a test to make surethat getAcl() is not called if `fs.azure.account.hns.enabl

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-12 Thread via GitHub
saxenapranav commented on code in PR #6752: URL: https://github.com/apache/hadoop/pull/6752#discussion_r1597964210 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java: ## @@ -165,5 +165,8 @@ public static ApiVersion getCurren

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845795#comment-17845795 ] ASF GitHub Bot commented on HADOOP-19137: - hadoop-yetus commented on PR #6752:

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6752: URL: https://github.com/apache/hadoop/pull/6752#issuecomment-2106769599 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

[jira] [Commented] (HADOOP-18851) Performance improvement for DelegationTokenSecretManager.

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-18851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845794#comment-17845794 ] ASF GitHub Bot commented on HADOOP-18851: - vikaskr22 commented on PR #6803: URL

Re: [PR] HADOOP-18851. DT performance improvement latest review incorporation [hadoop]

2024-05-12 Thread via GitHub
vikaskr22 commented on PR #6803: URL: https://github.com/apache/hadoop/pull/6803#issuecomment-2106765757 @Hexiaoqiao , @ChenSammi , Anything else needed from my side? I had fixed all the review comments that's part of my commit. -- This is an automated message from the Apache Git Service

Re: [PR] HDFS-17463. Support the switch StringTable Split ID feature [hadoop]

2024-05-12 Thread via GitHub
hiwangzhihui commented on PR #6736: URL: https://github.com/apache/hadoop/pull/6736#issuecomment-2106760458 @Hexiaoqiao I agree with your propose , We will proceed with work for it. Thank you for your guide. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845792#comment-17845792 ] ASF GitHub Bot commented on HADOOP-19137: - saxenapranav commented on code in PR

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-12 Thread via GitHub
saxenapranav commented on code in PR #6752: URL: https://github.com/apache/hadoop/pull/6752#discussion_r1597936942 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java: ## @@ -223,6 +225,21 @@ public void initialize(URI uri, Configura

Re: [PR] Bump ch.qos.logback:logback-classic from 1.1.2 to 1.2.13 in /hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6819: URL: https://github.com/apache/hadoop/pull/6819#issuecomment-2106734066 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HADOOP-19137. [ABFS]Fail fs init if cpk config is given on non-hns account [hadoop]

2024-05-12 Thread via GitHub
anujmodi2021 commented on code in PR #6752: URL: https://github.com/apache/hadoop/pull/6752#discussion_r1597905780 ## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java: ## @@ -223,6 +225,21 @@ public void initialize(URI uri, Configura

[jira] [Commented] (HADOOP-19137) [ABFS]:Extra getAcl call while calling the very first API of FileSystem

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845788#comment-17845788 ] ASF GitHub Bot commented on HADOOP-19137: - anujmodi2021 commented on code in PR

Re: [PR] HDFS-17520. [BugFix] TestDFSAdmin.testAllDatanodesReconfig and TestDFSAdmin.testDecommissionDataNodesReconfig failed [hadoop]

2024-05-12 Thread via GitHub
slfan1989 commented on PR #6812: URL: https://github.com/apache/hadoop/pull/6812#issuecomment-2106716295 LGTM +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

2024-05-12 Thread via GitHub
slfan1989 commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1597873381 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md: ## @@ -536,7 +536,7 @@ To enable cross-origin support (CORS) for the Yarn Router,

[PR] Bump ch.qos.logback:logback-classic from 1.1.2 to 1.2.13 in /hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle [hadoop]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #6819: URL: https://github.com/apache/hadoop/pull/6819 Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.1.2 to 1.2.13. Commits See full diff in https://github.com/qos-ch/logback/commits/v_1.2.13";>compar

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
slfan1989 merged PR #6816: URL: https://github.com/apache/hadoop/pull/6816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@had

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6784: URL: https://github.com/apache/hadoop/pull/6784#issuecomment-2106577140 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17384. [FGL] Replace the global lock with global FS Lock and global BM lock [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6762: URL: https://github.com/apache/hadoop/pull/6762#issuecomment-2106553639 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | -1 :x: | patch

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-12 Thread via GitHub
ferhui commented on PR #6806: URL: https://github.com/apache/hadoop/pull/6806#issuecomment-2106540855 Thanks for contribution. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] HDFS-17506. [FGL] Performance for phase 1 [hadoop]

2024-05-12 Thread via GitHub
ferhui merged PR #6806: URL: https://github.com/apache/hadoop/pull/6806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597807172 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean checkLe

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597806803 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean internalReleaseLease(Lease

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597806803 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean internalReleaseLease(Lease

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
slfan1989 commented on PR #6816: URL: https://github.com/apache/hadoop/pull/6816#issuecomment-2106525423 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[jira] [Commented] (HADOOP-19167) Change of Codec configuration does not work

2024-05-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HADOOP-19167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845766#comment-17845766 ] ASF GitHub Bot commented on HADOOP-19167: - skyskyhu commented on PR #6807: URL:

Re: [PR] HADOOP-19167 Bug Fix: Change of Codec configuration does not work [hadoop]

2024-05-12 Thread via GitHub
skyskyhu commented on PR #6807: URL: https://github.com/apache/hadoop/pull/6807#issuecomment-2106522484 @ZanderXu I do not have permission to merge my commit. Could you help merge the commit? Thanks! -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-12 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1597789296 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java: ## @@ -1224,6 +1224,17 @@ public void testProxyCo

Re: [PR] HDFS-17509. RBF: Fix ClientProtocol.concat will throw NPE if tgr is a empty file. [hadoop]

2024-05-12 Thread via GitHub
LiuGuH commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1597788935 ## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java: ## @@ -1009,6 +1000,20 @@ public HdfsFileS

Re: [PR] HDFS-17397. Choose another DN as soon as possible, when encountering network issues [hadoop]

2024-05-12 Thread via GitHub
daragu commented on PR #6591: URL: https://github.com/apache/hadoop/pull/6591#issuecomment-2106461328 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Bump es5-ext from 0.10.53 to 0.10.64 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6818: URL: https://github.com/apache/hadoop/pull/6818#issuecomment-2106392155 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6816: URL: https://github.com/apache/hadoop/pull/6816#issuecomment-2106370922 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
pjfanning commented on PR #6811: URL: https://github.com/apache/hadoop/pull/6811#issuecomment-2106356182 @vinayakumarb The LICENSE-binary has to be kept up to date. I have https://issues.apache.org/jira/browse/HADOOP-19154 open to track this upgrade. -- This is an automated message

Re: [PR] Bump follow-redirects from 1.14.7 to 1.15.6 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6815: URL: https://github.com/apache/hadoop/pull/6815#issuecomment-2106353659 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
vinayakumarb commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597693783 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java: ## @@ -626,7 +626,8 @@ private synchronized boolean check

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2106325014 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] HDFS-17438. RBF: The newest STANDBY and UNAVAILABLE nn should be the lowest priority. [hadoop]

2024-05-12 Thread via GitHub
goiri commented on code in PR #6655: URL: https://github.com/apache/hadoop/pull/6655#discussion_r1597672487 ## hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java: ## @@ -404,6 +404,28 @@ public static void waitFor(final Supplier check,

Re: [PR] YARN-11471. [Federation] FederationStateStoreFacade Cache Support Caffeine. [hadoop]

2024-05-12 Thread via GitHub
goiri commented on code in PR #6795: URL: https://github.com/apache/hadoop/pull/6795#discussion_r1597672074 ## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/Federation.md: ## @@ -536,7 +536,7 @@ To enable cross-origin support (CORS) for the Yarn Router, ple

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2106300111 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

Re: [PR] Bump es5-ext from 0.10.53 to 0.10.64 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6818: URL: https://github.com/apache/hadoop/pull/6818#issuecomment-2106294767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6816: URL: https://github.com/apache/hadoop/pull/6816#issuecomment-2106267878 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Bump express from 4.17.1 to 4.19.2 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6817: URL: https://github.com/apache/hadoop/pull/6817#issuecomment-2106266971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] Bump follow-redirects from 1.14.7 to 1.15.6 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6815: URL: https://github.com/apache/hadoop/pull/6815#issuecomment-2106264916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17522. JournalNode web interfaces lack configs for X-FRAME-OPTIO… [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6814: URL: https://github.com/apache/hadoop/pull/6814#issuecomment-2106252485 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| _ Prechecks _

[PR] Bump express from 4.17.1 to 4.19.2 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #6817: URL: https://github.com/apache/hadoop/pull/6817 Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.19.2. Release notes Sourced from https://github.com/expressjs/express/releases";>express's releases. 4.19.

[PR] Bump org.apache.derby:derby from 10.14.2.0 to 10.17.1.0 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #6816: URL: https://github.com/apache/hadoop/pull/6816 Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apa

[PR] Bump follow-redirects from 1.14.7 to 1.15.6 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #6815: URL: https://github.com/apache/hadoop/pull/6815 Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.15.6. Commits https://github.com/follow-redirects/follow-redirects/commit/35a517c58

[PR] Bump es5-ext from 0.10.53 to 0.10.64 in /hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp [hadoop]

2024-05-12 Thread via GitHub
dependabot[bot] opened a new pull request, #6818: URL: https://github.com/apache/hadoop/pull/6818 Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.53 to 0.10.64. Release notes Sourced from https://github.com/medikoo/es5-ext/releases";>es5-ext's releases. 0.10.64

Re: [PR] Bump org.bouncycastle:bcprov-jdk18on from 1.77 to 1.78 in /hadoop-project [hadoop]

2024-05-12 Thread via GitHub
vinayakumarb merged PR #6811: URL: https://github.com/apache/hadoop/pull/6811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
ThinkerLei commented on code in PR #6809: URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597594907 ## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ## @@ -3738,7 +3738,7 @@ boolean internalReleaseLease(Lease

Re: [PR] HDFS-17518: Sync the editslog if a file is closed in the lease monitor [hadoop]

2024-05-12 Thread via GitHub
hadoop-yetus commented on PR #6809: URL: https://github.com/apache/hadoop/pull/6809#issuecomment-2106176232 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe