Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-17 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2003013056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-17 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2002971355 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-17 Thread via GitHub
shahrs87 merged PR #6614: URL: https://github.com/apache/hadoop/pull/6614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-17 Thread via GitHub
shahrs87 commented on code in PR #6614: URL: https://github.com/apache/hadoop/pull/6614#discussion_r1527571968 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java: ## @@ -1707,4 +1708,154 @@ public void testStorageFavouredNodes(

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-16 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2002275973 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-16 Thread via GitHub
ritegarg commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2002216244 > All the tests (except for 1 test) that failed in [this build](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6614/6/) are flaky. They are failing in daily build also. Check

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-16 Thread via GitHub
shahrs87 commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2002199316 All the tests (except for 1 test) that failed in [this build](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6614/6/) are flaky. They are failing in daily build also. Check

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-15 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2001010847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-15 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2000788575 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-15 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2000757455 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-15 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-2000644545 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-15 Thread via GitHub
ritegarg commented on code in PR #6614: URL: https://github.com/apache/hadoop/pull/6614#discussion_r1526907541 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestCrcCorruption.java: ## @@ -86,7 +86,7 @@ public void setUp() throws IOException { * crea

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 merged PR #6612: URL: https://github.com/apache/hadoop/pull/6612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1998589730 All the failed test in this build are flaky. Merging this PR. Thank you @ritegarg for your contribution ! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1998524754 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 commented on code in PR #6614: URL: https://github.com/apache/hadoop/pull/6614#discussion_r1525236336 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestCrcCorruption.java: ## @@ -86,7 +86,7 @@ public void setUp() throws IOException { * crea

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-14 Thread via GitHub
shahrs87 commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-1997942382 @ritegarg Can you please check if the checkstyle warning is relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1996287519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1996283905 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1996262022 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-1996218189 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
ritegarg commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-1996070790 Updated some tests, some of the tests are false positives so can be ignored if failing in main hadoop repo as well. Test Name | With Changes(locally) | Without Changes -- | -- |

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1995857608 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
ritegarg commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1994939750 > @ritegarg Thank you for the PR. Overall looks good. Looks like `blanks` and `spotbugs` warnings are relevant. Can you please fix them? Once that is done, I will approve and merge.

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-13 Thread via GitHub
shahrs87 commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1994802519 @ritegarg Thank you for the PR. Overall looks good. Looks like `blanks` and `spotbugs` warnings are relevant. Can you please fix them? Once that is done, I will approve and merge

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-09 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1987056450 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-09 Thread via GitHub
ritegarg commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1987003317 Ran the tests locally and observing that some of the failures are not reproducible and tests are passing. 1 test is failing with and without changes. 1 test is flaky in both upstream and

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-09 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1986999110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1984392158 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
ritegarg commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1984310623 > There are few test failures. Can you please take a look? @ritegarg I was looking into the failures, looks like transient failures. The same tests are running fine locally. --

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
shahrs87 commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1984012754 There are few test failures. Can you please take a look? @ritegarg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-07 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1983180401 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao commented on PR #6613: URL: https://github.com/apache/hadoop/pull/6613#issuecomment-1982836474 Hi @ritegarg Thanks for your PR. branch-3.2 has been EOL. We should not submit PR to this branch. I will close this one. Please feel free to reopen it if something I missed. Thanks agai

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-07 Thread via GitHub
Hexiaoqiao closed pull request #6613: HDFS-17299. Adding rack failure tolerance when creating a new file (… URL: https://github.com/apache/hadoop/pull/6613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6614: URL: https://github.com/apache/hadoop/pull/6614#issuecomment-1982453381 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6613: URL: https://github.com/apache/hadoop/pull/6613#issuecomment-1982313394 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1982297366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
ritegarg opened a new pull request, #6614: URL: https://github.com/apache/hadoop/pull/6614 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file (… [hadoop]

2024-03-06 Thread via GitHub
ritegarg opened a new pull request, #6613: URL: https://github.com/apache/hadoop/pull/6613 …#6566) ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
ritegarg opened a new pull request, #6612: URL: https://github.com/apache/hadoop/pull/6612 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g.

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
shahrs87 merged PR #6566: URL: https://github.com/apache/hadoop/pull/6566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hado

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
shahrs87 commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1981347404 Will merge the PR later today. FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-06 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1980368491 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-05 Thread via GitHub
ritegarg commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1979910458 > There are some new checkstyle issues from the result of CI. Could you fix them? Should be fixed now -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-05 Thread via GitHub
tasanuma commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1979904394 There are some new checkstyle issues from the result of CI. Could you fix them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-05 Thread via GitHub
shahrs87 commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1979352026 1. [spotbugs](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6566/20/artifact/out/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client-warnings.html) warning is not related

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-05 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1513209226 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientExcludedNodes.java: ## @@ -89,6 +89,10 @@ public void testExcludedNodesForgiveness(

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-05 Thread via GitHub
tasanuma commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1512884161 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1817,10 +1839,10 @@ protected LocatedBlock nextBlockOutputStrea

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-05 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1978665926 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-04 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1977869072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-04 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1977657875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-04 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1977608476 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-04 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1511777291 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1817,10 +1839,10 @@ protected LocatedBlock nextBlockOutputStrea

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-04 Thread via GitHub
shahrs87 commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1511445056 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1817,10 +1839,10 @@ protected LocatedBlock nextBlockOutputStrea

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-03 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1975518985 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-03 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1510344496 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-03 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1510344410 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java: ## @@ -111,6 +111,7 @@ protected LocatedBlock nextBlockOutputSt

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-02 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1510154387 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-02 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1974733389 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509893467 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509891173 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java: ## @@ -111,6 +111,7 @@ protected LocatedBlock nextBlockOutputSt

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509773824 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -2259,4 +2282,4 @@ public String toString() { return extend

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509772592 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java: ## @@ -111,6 +111,7 @@ protected LocatedBlock nextBlockOutputSt

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509591909 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-03-01 Thread via GitHub
ayushtkn commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1509482598 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -414,6 +414,10 @@ synchronized void markFirstNodeIfNotMarked() {

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-29 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1972572072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-29 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1972468090 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-29 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1508255776 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1618,33 +1625,47 @@ private void setupPipelineForAppendOrRecove

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-29 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1508255658 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java: ## @@ -2651,5 +2653,154 @@ public void testNameNodeCreateSnapsh

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-29 Thread via GitHub
ritegarg commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1508253750 ## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java: ## @@ -2651,5 +2653,154 @@ public void testNameNodeCreateSnapsh

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-29 Thread via GitHub
shahrs87 commented on code in PR #6566: URL: https://github.com/apache/hadoop/pull/6566#discussion_r1508229688 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1618,33 +1625,47 @@ private void setupPipelineForAppendOrRecove

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-27 Thread via GitHub
ritegarg closed pull request #6556: HDFS-17299. Adding rack failure tolerance when creating a new file URL: https://github.com/apache/hadoop/pull/6556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-27 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1966180516 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-26 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1965614194 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-26 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1964720571 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-23 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1960990799 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1960584739 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1960345982 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1959924123 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-22 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1959333777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1958788319 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1958776146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-21 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1958262110 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-20 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1955918130 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-20 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1955745685 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-20 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1955129523 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-20 Thread via GitHub
hadoop-yetus commented on PR #6566: URL: https://github.com/apache/hadoop/pull/6566#issuecomment-1954866984 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://ci-hadoop.apache.org/job

[PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-20 Thread via GitHub
ritegarg opened a new pull request, #6566: URL: https://github.com/apache/hadoop/pull/6566 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-16 Thread via GitHub
hadoop-yetus commented on PR #6556: URL: https://github.com/apache/hadoop/pull/6556#issuecomment-1949219422 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-15 Thread via GitHub
ritegarg closed pull request #6513: HDFS-17299. Adding rack failure tolerance when creating a new file URL: https://github.com/apache/hadoop/pull/6513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-15 Thread via GitHub
ritegarg commented on PR #6513: URL: https://github.com/apache/hadoop/pull/6513#issuecomment-1947097875 Closing this PR in favor of https://github.com/apache/hadoop/pull/6556/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] [HDFS-17299] Adding rack failure tolerance when creating a new file [hadoop]

2024-02-15 Thread via GitHub
ritegarg opened a new pull request, #6556: URL: https://github.com/apache/hadoop/pull/6556 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-07 Thread via GitHub
hadoop-yetus commented on PR #6513: URL: https://github.com/apache/hadoop/pull/6513#issuecomment-1933421772 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-06 Thread via GitHub
shahrs87 commented on code in PR #6513: URL: https://github.com/apache/hadoop/pull/6513#discussion_r1479041865 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1607,8 +1607,11 @@ private void transfer(final DatanodeInfo src

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-06 Thread via GitHub
shahrs87 commented on code in PR #6513: URL: https://github.com/apache/hadoop/pull/6513#discussion_r1480341310 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1618,24 +1621,33 @@ private void setupPipelineForAppendOrRecove

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-06 Thread via GitHub
shahrs87 commented on code in PR #6513: URL: https://github.com/apache/hadoop/pull/6513#discussion_r1479057807 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1618,24 +1621,33 @@ private void setupPipelineForAppendOrRecove

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-05 Thread via GitHub
shahrs87 commented on code in PR #6513: URL: https://github.com/apache/hadoop/pull/6513#discussion_r1479041865 ## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java: ## @@ -1607,8 +1607,11 @@ private void transfer(final DatanodeInfo src

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-03 Thread via GitHub
hadoop-yetus commented on PR #6513: URL: https://github.com/apache/hadoop/pull/6513#issuecomment-1925254084 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reex

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-02 Thread via GitHub
ritegarg commented on PR #6513: URL: https://github.com/apache/hadoop/pull/6513#issuecomment-1925029661 > @ritegarg There are still 45 test faiures in the latest run. Please take a look. Fixed locally, started a new Jenkins build -- This is an automated message from the Apache Git

Re: [PR] HDFS-17299. Adding rack failure tolerance when creating a new file [hadoop]

2024-02-02 Thread via GitHub
ritegarg commented on PR #6513: URL: https://github.com/apache/hadoop/pull/6513#issuecomment-1925029575 > Overall the changes looks good. @ritegarg Can you please add a comment on why you changed the signature of `setupPipelineForAppendOrRecovery` method. Updated -- This is an auto

  1   2   >