[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-04-14 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240774#comment-15240774 ] Kai Zheng commented on HADOOP-12924: Thanks Rui for the great update and nice tests! Two more

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-04-13 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15240534#comment-15240534 ] Rui Li commented on HADOOP-12924: - All the failures either cannot be reproduced or fail on trunk as

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-04-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239686#comment-15239686 ] Hadoop QA commented on HADOOP-12924: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-04-12 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238526#comment-15238526 ] Rui Li commented on HADOOP-12924: - Thanks [~drankye] for the review! 1. Actually I do get NPEs in tests

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-04-12 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238366#comment-15238366 ] Kai Zheng commented on HADOOP-12924: Thanks [~lirui] for the nice work. 1. In {{CodecUtil}}, I guess

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-04-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221398#comment-15221398 ] Hadoop QA commented on HADOOP-12924: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-31 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219811#comment-15219811 ] Rui Li commented on HADOOP-12924: - Test failures are not related. I don't quite understand the

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219723#comment-15219723 ] Hadoop QA commented on HADOOP-12924: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-29 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215500#comment-15215500 ] Kai Zheng commented on HADOOP-12924: >>For the other codec, how about rs-default? Cool! Thanks for

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-28 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215487#comment-15215487 ] Zhe Zhang commented on HADOOP-12924: Thanks Rui and Kai! The two points Rui proposed above make

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-28 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213877#comment-15213877 ] Kai Zheng commented on HADOOP-12924: Thanks [~lirui] for the nice summary! it's fine to me. We may

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-24 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210167#comment-15210167 ] Rui Li commented on HADOOP-12924: - Based on my offline discussion with Kai, we have the following

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-24 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15209989#comment-15209989 ] Kai Zheng commented on HADOOP-12924: bq. I think the bottomline is that the file metadata (stored in

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-23 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207952#comment-15207952 ] Zhe Zhang commented on HADOOP-12924: Technically, any coder that yields new numerical results should

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-22 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207635#comment-15207635 ] Kai Zheng commented on HADOOP-12924: [~lirui] and [~zhz], how do you think doing the above change

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-22 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205952#comment-15205952 ] Kai Zheng commented on HADOOP-12924: Ping [~andrew.wang], in case needed. > Add default coder key

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-22 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205947#comment-15205947 ] Kai Zheng commented on HADOOP-12924: OK, it won't be bad to have a policy for the legacy coder,

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-22 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205942#comment-15205942 ] Rui Li commented on HADOOP-12924: - Actually we also have dummy raw coders, which I think should work

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-22 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205856#comment-15205856 ] Zhe Zhang commented on HADOOP-12924: Thanks for the thoughts Kai. Simplifying logic is a valid

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-19 Thread Kai Zheng (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198533#comment-15198533 ] Kai Zheng commented on HADOOP-12924: Thanks for the discussions, Zhe and Rui. bq. Kai mentioned that

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-16 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196905#comment-15196905 ] Rui Li commented on HADOOP-12924: - Thanks Zhe for the review and comments. Yes I think the concern is

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196885#comment-15196885 ] Hadoop QA commented on HADOOP-12924: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HADOOP-12924) Add default coder key for creating raw coders

2016-03-16 Thread Zhe Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196858#comment-15196858 ] Zhe Zhang commented on HADOOP-12924: Thanks Rui. Patch itself LGTM. However I realized some issues