[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098749#comment-15098749
]
Colin Patrick McCabe commented on HADOOP-8887:
--
So, the two issues from the plugin I saw
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098770#comment-15098770
]
Andrew Wang commented on HADOOP-8887:
-
There's a bunch of checkstyle stuff, and findbugs looks like
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098787#comment-15098787
]
Hudson commented on HADOOP-8887:
FAILURE: Integrated in Hadoop-trunk-Commit #9113 (See
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098790#comment-15098790
]
Colin Patrick McCabe commented on HADOOP-8887:
--
Yes, let's take care of the whitespace /
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098678#comment-15098678
]
Andrew Wang commented on HADOOP-8887:
-
Hey Colin, I think commit was a little premature, since
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097206#comment-15097206
]
Andrew Wang commented on HADOOP-8887:
-
Nice work here Colin! Just a few review comments:
* Rather
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097278#comment-15097278
]
Colin Patrick McCabe commented on HADOOP-8887:
--
bq. Rather than hardcoding 4, we could use
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097554#comment-15097554
]
Hadoop QA commented on HADOOP-8887:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095458#comment-15095458
]
Kai Zheng commented on HADOOP-8887:
---
This sounds so good to have! I felt the same pain and necessity
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14364466#comment-14364466
]
Colin Patrick McCabe commented on HADOOP-8887:
--
Please, -1 on automatic
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361458#comment-14361458
]
Haohui Mai commented on HADOOP-8887:
Either approach looks reasonable to me. The only
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361355#comment-14361355
]
Colin Patrick McCabe commented on HADOOP-8887:
--
I did try to work with
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353524#comment-14353524
]
Haohui Mai commented on HADOOP-8887:
I just came across
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479942#comment-13479942
]
Hudson commented on HADOOP-8887:
Integrated in Hadoop-Yarn-trunk #8 (See
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480005#comment-13480005
]
Hudson commented on HADOOP-8887:
Integrated in Hadoop-Hdfs-trunk #1200 (See
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480038#comment-13480038
]
Hudson commented on HADOOP-8887:
Integrated in Hadoop-Mapreduce-trunk #1230 (See
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479198#comment-13479198
]
Colin Patrick McCabe commented on HADOOP-8887:
--
test failures are unrelated
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479446#comment-13479446
]
Hudson commented on HADOOP-8887:
Integrated in Hadoop-trunk-Commit #2889 (See
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479571#comment-13479571
]
Tsz Wo (Nicholas), SZE commented on HADOOP-8887:
How about the javadoc
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479570#comment-13479570
]
Suresh Srinivas commented on HADOOP-8887:
-
I reverted the branch-2 patch. Some
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479602#comment-13479602
]
Suresh Srinivas commented on HADOOP-8887:
-
@Alejandro no worries.
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479642#comment-13479642
]
Hudson commented on HADOOP-8887:
Integrated in Hadoop-trunk-Commit #2893 (See
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478267#comment-13478267
]
Alejandro Abdelnur commented on HADOOP-8887:
+1 pending jenkins.
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478341#comment-13478341
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478550#comment-13478550
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475480#comment-13475480
]
Colin Patrick McCabe commented on HADOOP-8887:
--
By the way, one thing that's
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475481#comment-13475481
]
Colin Patrick McCabe commented on HADOOP-8887:
--
oh, also, I added the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473251#comment-13473251
]
Tom White commented on HADOOP-8887:
---
bq. Does it make sense to put it in Hadoop for
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472272#comment-13472272
]
Tom White commented on HADOOP-8887:
---
This plugin looks general purpose and it's in the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472758#comment-13472758
]
Colin Patrick McCabe commented on HADOOP-8887:
--
It would be nice to spin it
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472786#comment-13472786
]
Alejandro Abdelnur commented on HADOOP-8887:
* plugin root package should be
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472842#comment-13472842
]
Colin Patrick McCabe commented on HADOOP-8887:
--
bq. plugin root package
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472857#comment-13472857
]
Alejandro Abdelnur commented on HADOOP-8887:
* Unless I'm missing something,
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472864#comment-13472864
]
Colin Patrick McCabe commented on HADOOP-8887:
--
bq. [defaults]
I'll add
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472866#comment-13472866
]
Alejandro Abdelnur commented on HADOOP-8887:
got it, ok on clean. on the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472875#comment-13472875
]
Colin Patrick McCabe commented on HADOOP-8887:
--
bq. does compiled test stuff
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471990#comment-13471990
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472096#comment-13472096
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470538#comment-13470538
]
Colin Patrick McCabe commented on HADOOP-8887:
--
A word of explanation about
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470646#comment-13470646
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470853#comment-13470853
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the
41 matches
Mail list logo