Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: Seems to me the HashMap --- Hashtable change could be made against HEAD. It's only NECESSARY for 1.1 compatibility but it poses no great problem for a 1.2 compatible version; it isn't as if this would impact some functionality deep in the

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-02 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: This code was calling a method in ORO that returned a Collection, also not JDK1.1 compatible. Since the older ORO method that returned a Vector had been deprecated, I looked at what it was doing, which was simply splitting a string on a comma.

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-01 Thread steve cohen
Seems to me the HashMap --- Hashtable change could be made against HEAD. It's only NECESSARY for 1.1 compatibility but it poses no great problem for a 1.2 compatible version; it isn't as if this would impact some functionality deep in the core of the product. So after this is done, a

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-01 Thread steve cohen
On Thursday 01 January 2004 09:06 am, Jeffrey D. Brekke wrote: Maven uses the following property: maven.compiler.target which defaults to 1.1 so what I last released generated 1.1 compatible class files. http://maven.apache.org/reference/plugins/java/properties.html Example: maven

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-01 Thread Jeffrey D. Brekke
I believe it just produces 1.1 compatible class files. Maven just passes the setting to the ant task, which passes it to javac. Since the HashMap class is is not present under 1.1 I guess we'd just get a ClassNotFoundException. I believe that should be all we need, we shouldn't need to

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2004-01-01 Thread steve cohen
Yes, in order to verify that the code doesn't use any 1.2+ code I found that you have to also use bootclasspath={path to jdk1.1.8 classes.zip} There were a couple of other instances: use of ArrayLists in VMSFTPEntryParser and in ExtendedNNTPOps.java in the examples section. I cleaned all of

Re: [net] VMSFTPEntryParser bug?

2003-12-31 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], Steve Cohen writes: But what about my point that what we have now is NOT 1.1 compatible? VMSFTPEntryParser broke that, although it could, if necessary, be reimplemented to use Hashtable instead of HashMap. I misread your email (unfortunately an increasingly common

Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2003-12-31 Thread steve cohen
This makes a lot of sense, Daniel, and as long as I stay unemployed, I will even have time to devote to the project :-) I am not completely CVS-literate and setting up the branches is beyond my current level of experience but probably would be good experience for me. I am working now on a

Re: Next Steps - WAS Re: [net] VMSFTPEntryParser bug?

2003-12-31 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes: I am not completely CVS-literate and setting up the branches is beyond my current level of experience but probably would be good experience for me. In my response to Jeffrey's email, I asked about whether we wanted to replace the existing

Re: [net] VMSFTPEntryParser bug?

2003-12-30 Thread Jeffrey D. Brekke
On Mon, 29 Dec 2003 16:22:48 -0600, Steve Cohen [EMAIL PROTECTED] said: [SNIP] However, this brings up the larger question, of what the target platform for commons-net is. I dimly remember that it being java 1.1. This is why I went through the annoying exercise of creating the FTPFileList

Re: [net] VMSFTPEntryParser bug?

2003-12-30 Thread Steve Cohen
But what about my point that what we have now is NOT 1.1 compatible? VMSFTPEntryParser broke that, although it could, if necessary, be reimplemented to use Hashtable instead of HashMap. However, there might be room for discussion whether we want to leave 1.1 compatibility behind. Ant 1.6 now

Re: [net] VMSFTPEntryParser bug?

2003-12-30 Thread Jeffrey D. Brekke
Unfortunately I don't remember if it was discussed or not. I'm for leaving 1.1 behind, even if we need to make a compatible version at this point, but then moving on. Seems like 1.3 is doable. I wouldn't want to leave users out in the cold. I still want to provide a release that works with a

Re: [NET] VMSFTPEntryParser bug?

2003-12-30 Thread Daniel F. Savarese
In message [EMAIL PROTECTED], steve cohen writes : failing but on a different line. I'm not sure what platform Jeff is on when he did the build, but I think I should rewrite this test in a way that doesn't assume any particular order since this seems to be JDK-implementation dependent. The

Re: [NET] VMSFTPEntryParser bug?

2003-12-29 Thread steve cohen
On Monday 29 December 2003 04:27 pm, steve cohen wrote: I am trying to build commons-net prior to making some changes and some other issues have come to light. One of the tests is failing for me - VMSFTPEntryParserTest.testParseFileList(). This test seems poorly implemented, since the class

[net] VMSFTPEntryParser bug?

2003-12-29 Thread Steve Cohen
I am trying to build commons-net prior to making some changes and some other issues have come to light. One of the tests is failing for me - VMSFTPEntryParserTest.testParseFileList(). This test seems poorly implemented, since the class being tested builds its list of files using a HashMap

[NET] VMSFTPEntryParser bug?

2003-12-29 Thread steve cohen
I am trying to build commons-net prior to making some changes and some other issues have come to light. One of the tests is failing for me - VMSFTPEntryParserTest.testParseFileList(). This test seems poorly implemented, since the class being tested builds its list of files using a HashMap

Re: [NET] VMSFTPEntryParser bug?

2003-12-29 Thread Steve Cohen
On Monday 29 December 2003 04:27 pm, steve cohen wrote: I am trying to build commons-net prior to making some changes and some other issues have come to light. One of the tests is failing for me - VMSFTPEntryParserTest.testParseFileList(). This test seems poorly implemented, since the