Re: [id] Review before 1.0 (Summary)

2006-01-24 Thread Phil Steitz
On 1/24/06, Jörg Schaible [EMAIL PROTECTED] wrote: Hi Michael, Michael Heuer wrote on Friday, January 20, 2006 7:40 PM: On Fri, 20 Jan 2006, Phil Steitz wrote: I have started working on this. What I had in mind was just a simple facility for creating composite identifiers created by

Re: [id] Review before 1.0 (Summary)

2006-01-23 Thread Michael Heuer
On Fri, 20 Jan 2006, Phil Steitz wrote: On 1/17/06, J?rg Schaible [EMAIL PROTECTED] wrote: Stephen Colebourne wrote on Monday, January 16, 2006 11:13 PM: J?rg Schaible wrote: The release plan is available now: http://wiki.apache.org/jakarta-commons/id/1.0ReleasePlan Looks good,

RE: [id] Review before 1.0 (Summary)

2006-01-23 Thread Jörg Schaible
Hi Michael, Michael Heuer wrote on Friday, January 20, 2006 7:40 PM: On Fri, 20 Jan 2006, Phil Steitz wrote: I have started working on this. What I had in mind was just a simple facility for creating composite identifiers created by concatenating results of an array of generators. This

Re: [id] Review before 1.0 (Summary)

2006-01-20 Thread Phil Steitz
On 1/17/06, Jörg Schaible [EMAIL PROTECTED] wrote: Stephen Colebourne wrote on Monday, January 16, 2006 11:13 PM: Jörg Schaible wrote: The release plan is available now: http://wiki.apache.org/jakarta-commons/id/1.0ReleasePlan Looks good, though we may actually want to keep

Re: [id] Review before 1.0 (Summary)

2006-01-20 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote: On 1/17/06, Jörg Schaible [EMAIL PROTECTED] wrote: Stephen Colebourne wrote on Monday, January 16, 2006 11:13 PM: Jörg Schaible wrote: The release plan is available now: http://wiki.apache.org/jakarta-commons/id/1.0ReleasePlan Looks good, though we may

RE: [id] Review before 1.0 (Summary)

2006-01-17 Thread Jörg Schaible
Stephen Colebourne wrote on Monday, January 16, 2006 11:13 PM: Jörg Schaible wrote: The release plan is available now: http://wiki.apache.org/jakarta-commons/id/1.0ReleasePlan Refactor PrefixXXXGeneratorIdentifier implementations This should be done with great care. id generation is very

RE: [id] Review before 1.0 (Summary)

2006-01-16 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote on Monday, January 16, 2006 1:31 AM: On 1/15/06, Jörg Schaible [EMAIL PROTECTED] wrote: Phil Steitz wrote: On 1/14/06, Michael Heuer [EMAIL PROTECTED] wrote: Jörg Schaible wrote: 8/ Prefix generators We have 3 generators, that add a prefix to the

RE: [id] Review before 1.0 (Summary)

2006-01-16 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote on Monday, January 16, 2006 1:27 AM: [snip] I know quite some projects that use a snapshot of c-id to generate UUIDs in production (including some of mine). I don't know what we can do to make it more clear that people should *not* depend on code in the commons

RE: [id] Review before 1.0 (Summary)

2006-01-16 Thread Jörg Schaible
Hi fellows, Jörg Schaible wrote: Phil Steitz wrote on Monday, January 16, 2006 1:27 AM: [snip] In any case, I think we have critical mass to get [id] promoted and released, and the API decisions left to make are fairly simple, so we should agree on a release plan and get the work done.

Re: [id] Review before 1.0 (Summary)

2006-01-16 Thread Stephen Colebourne
Jörg Schaible wrote: The release plan is available now: http://wiki.apache.org/jakarta-commons/id/1.0ReleasePlan Refactor PrefixXXXGeneratorIdentifier implementations This should be done with great care. id generation is very performance and sync sensitive in many systems. Introduce a

Re: [id] Review before 1.0 (Summary)

2006-01-15 Thread Jörg Schaible
Phil Steitz wrote: On 1/14/06, Michael Heuer [EMAIL PROTECTED] wrote: Jörg Schaible wrote: 8/ Prefix generators We have 3 generators, that add a prefix to the generated id. All 3 classes to mainly the same for 3 different StringIdentifierGenerators. Proposal: Since we have a lot

Re: [id] Review before 1.0 (Summary)

2006-01-15 Thread Jörg Schaible
Hi Phil, Phil Steitz wrote: snip/ For me the question is, does a normal user really care about the specifics of an unique id. The most difference is the returned type of the id, because that may impact other parts of the code (e.g. DB). I think many apps will care about more than just

Re: [id] Review before 1.0 (Summary)

2006-01-15 Thread Phil Steitz
On 1/15/06, Jörg Schaible [EMAIL PROTECTED] wrote: Hi Phil, Phil Steitz wrote: snip/ For me the question is, does a normal user really care about the specifics of an unique id. The most difference is the returned type of the id, because that may impact other parts of the code (e.g.

Re: [id] Review before 1.0 (Summary)

2006-01-15 Thread Phil Steitz
On 1/15/06, Jörg Schaible [EMAIL PROTECTED] wrote: Phil Steitz wrote: On 1/14/06, Michael Heuer [EMAIL PROTECTED] wrote: Jörg Schaible wrote: 8/ Prefix generators We have 3 generators, that add a prefix to the generated id. All 3 classes to mainly the same for 3 different

[id] Review before 1.0 (Summary)

2006-01-14 Thread Jörg Schaible
Hi folks, reviewing c-id I found more issues to resolve before releasing 1.0 final. Since I already reported different complaints, I create here a summary of anything already reported and all new issues. 1/ Concept of IdentifierGeneratorFactory The IdentifierGeneratorFactory provides a

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Tim OBrien
Good summary, comments inline... --- Jörg Schaible [EMAIL PROTECTED] wrote: 4/ Copied c-codec classes in official API To remove a dependency to c-codec the digest and hex utilities have been copied to c-id, but they are now publicly available in the o.a.c.id namespace. Martin already

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Jörg Schaible
Hi Tim, Tim OBrien wrote: Good summary, comments inline... --- Jörg Schaible [EMAIL PROTECTED] wrote: 4/ Copied c-codec classes in official API To remove a dependency to c-codec the digest and hex utilities have been copied to c-id, but they are now publicly available in the o.a.c.id

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Tim OBrien
--- Jörg Schaible [EMAIL PROTECTED] wrote: Hi Tim, Tim OBrien wrote: Good summary, comments inline... --- Jörg Schaible [EMAIL PROTECTED] wrote: 4/ Copied c-codec classes in official API To remove a dependency to c-codec the digest and hex utilities have been copied to

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Stephen Colebourne
Tim OBrien wrote: --- Jörg Schaible [EMAIL PROTECTED] wrote: 4/ Copied c-codec classes in official API To remove a dependency to c-codec the digest and hex utilities have been copied to c-id, but they are now publicly available in the o.a.c.id namespace. Martin already proposed to move them

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Phil Steitz
On 1/14/06, Jörg Schaible [EMAIL PROTECTED] wrote: Hi folks, reviewing c-id I found more issues to resolve before releasing 1.0 final. Since I already reported different complaints, I create here a summary of anything already reported and all new issues. 1/ Concept of

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Stephen Colebourne
As per the general thrust of Phil's mail, we should remove everything thats complex and not working and get a simple 1.0 out there. We can then grow from that point as and when the desire arises. Stephen Phil Steitz wrote: On 1/14/06, Jörg Schaible [EMAIL PROTECTED] wrote: Hi folks,

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Jörg Schaible
Hi Phil, comments in line again ... Phil Steitz wrote: On 1/14/06, Jörg Schaible [EMAIL PROTECTED] wrote: Hi folks, reviewing c-id I found more issues to resolve before releasing 1.0 final. Since I already reported different complaints, I create here a summary of anything already reported

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Jörg Schaible
Hi Stephen, Stephen Colebourne wrote: As per the general thrust of Phil's mail, we should remove everything thats complex and not working and get a simple 1.0 out there. We can then grow from that point as and when the desire arises. As answered to Phil, UUID is now part of c-id for two

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Jörg Schaible
Hi Stephen, Stephen Colebourne wrote: Tim OBrien wrote: --- Jörg Schaible [EMAIL PROTECTED] wrote: 4/ Copied c-codec classes in official API To remove a dependency to c-codec the digest and hex utilities have been copied to c-id, but they are now publicly available in the o.a.c.id namespace.

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Jörg Schaible
Hi fellows, two of the issues have already be solved (see inline comments), but I have two new ones, see at the bottom. Jörg Schaible wrote: [snip] 3/ xxxStateImpl classes The javadoc of ReadOnlyResourceStateImpl implies that the implementation tries to discover (well, use c-discovery) to

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Phil Steitz
snip/ For me the question is, does a normal user really care about the specifics of an unique id. The most difference is the returned type of the id, because that may impact other parts of the code (e.g. DB). I think many apps will care about more than just the type as in string or numeric,

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Michael Heuer
J?rg Schaible wrote: 8/ Prefix generators We have 3 generators, that add a prefix to the generated id. All 3 classes to mainly the same for 3 different StringIdentifierGenerators. Proposal: Since we have a lot more StringIdentifierGenrators (e.g. the UUIDIdentifierGenerators a

Re: [id] Review before 1.0 (Summary)

2006-01-14 Thread Phil Steitz
On 1/14/06, Michael Heuer [EMAIL PROTECTED] wrote: Jörg Schaible wrote: 8/ Prefix generators We have 3 generators, that add a prefix to the generated id. All 3 classes to mainly the same for 3 different StringIdentifierGenerators. Proposal: Since we have a lot more