Re: [lang] checkstyle report

2005-05-25 Thread Steven Caswell
I propose that for the upcoming lang 2.1 release we leave the errors unfixed and leave the checkstyle report as is. 1. Leave them unfixed because the errors are all documentation-related, and while it is important to fix them, I don't believe the problems are detrimental to the product. It has

RE: [lang] checkstyle report

2005-05-25 Thread Gary Gregory
I agree with Steven. Gary -Original Message- From: Steven Caswell [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 25, 2005 2:11 PM To: Jakarta Commons Developers List; [EMAIL PROTECTED] Subject: Re: [lang] checkstyle report I propose that for the upcoming lang 2.1 release we leave

Re: [lang] checkstyle report

2005-05-25 Thread Fredrik Westermarck
Steven Caswell wrote: I propose that for the upcoming lang 2.1 release we leave the errors unfixed and leave the checkstyle report as is. 1. Leave them unfixed because the errors are all documentation-related, and while it is important to fix them, I don't believe the problems are

Re: [lang] checkstyle report

2005-05-25 Thread Simon Kitching
On Wed, 2005-05-25 at 23:59 +0200, Fredrik Westermarck wrote: off-topic While on the subject of svn; is there a repository (at apache) where one can test svn without causing a mess? :-P /off-topic Not a publicly accessable one. But it is trivial to set up a local repository on your own

[lang] checkstyle report

2005-05-24 Thread Simon Kitching
Hi, I've checked http://people.apache.org/~stevencaswell/commons-lang-2.1/docs/checkstyle-report.html and there is a massive number of checkstyle errors reported. I suggest you either fix them or turn off the checkstyle checks you don't want. Fixing the problem is probably better. By the way,

Re: [lang] checkstyle report

2005-05-24 Thread Simon Kitching
On Wed, 2005-05-25 at 15:18 +1200, Simon Kitching wrote: By the way, I've struck a checkstyle problem when using it in the digester site. Despite project.properties having maven.checkstyle.properties=${basedir}/checkstyle.xml it doesn't look to me like the specified checkstyle.xml file

Re: [lang] checkstyle report

2005-05-24 Thread Frank W. Zammetti
I believe that is the OperatorWrap check, in the Whitespace group of checks. -- Frank W. Zammetti Founder and Chief Software Architect Omnytex Technologies http://www.omnytex.com Simon Kitching wrote: On Wed, 2005-05-25 at 15:18 +1200, Simon Kitching wrote: By the way, I've struck a

Re: [lang] checkstyle report

2005-05-24 Thread Phil Steitz
If you are talking about the digester checkstyle.xml, the culprit is this: module name=OperatorWrap property name=option value=eol/ /module See http://checkstyle.sourceforge.net/config_whitespace.html#OperatorWrap I think nl forces the opposite behaviour, dropping the check eliminates

Re: [lang] checkstyle report

2005-05-24 Thread Martin Cooper
On 5/24/05, Simon Kitching [EMAIL PROTECTED] wrote: On Wed, 2005-05-25 at 15:18 +1200, Simon Kitching wrote: By the way, I've struck a checkstyle problem when using it in the digester site. Despite project.properties having maven.checkstyle.properties=${basedir}/checkstyle.xml it

Re: [lang] checkstyle report

2005-05-24 Thread Simon Kitching
On Wed, 2005-05-25 at 00:30 -0400, Phil Steitz wrote: If you are talking about the digester checkstyle.xml, the culprit is this: module name=OperatorWrap property name=option value=eol/ /module See http://checkstyle.sourceforge.net/config_whitespace.html#OperatorWrap I think nl