RE: [logging] Avalon log not Serializable?

2006-02-22 Thread Jörg Schaible
Simon Kitching wrote on Thursday, February 23, 2006 6:17 AM: [snip] > Assuming that some Avalon loggers are *not* serializable then > there are > two problems. None of it implement Serializable, so your assumption is right. Since they don't have a default ctor they also cannot be the base of a

Re: [logging] Avalon log not Serializable?

2006-02-22 Thread Torsten Curdt
These two issues *can* be sort-of worked around by my proposed option (c). However I don't really like the idea of silently disabling logging. Me neither :-/ In short, I believe that Avalon logging in general, and the JCL AvalonLogger in particular are not designed to handle serialization

Re: [logging] Avalon log not Serializable?

2006-02-22 Thread Simon Kitching
On Thu, 2006-02-23 at 13:07 +1100, Torsten Curdt wrote: > > Here are the options I can see: > > (a) remove AvalonLogger from the JCL 1.1 distribution. > > N ...bad idea IMO. We would have to deprecate it first. Ok. > > > (b) remove Serializable marker interface from AvalonLogger > > It's p

Re: [logging] Avalon log not Serializable?

2006-02-22 Thread Torsten Curdt
Here are the options I can see: (a) remove AvalonLogger from the JCL 1.1 distribution. N ...bad idea IMO. We would have to deprecate it first. (b) remove Serializable marker interface from AvalonLogger It's probably the best to fix it in the Avalon code. It's old, it's becoming reviled

Re: [logging] Avalon log not Serializable?

2006-02-21 Thread robert burrell donkin
On Tue, 2006-02-21 at 17:59 +1300, Simon Kitching wrote: > The Log4JLogger class appears to work correctly, because it implements > getLogger like this: > public Logger getLogger() { > if (logger == null) { > logger = Logger.getLogger(name); > } > return (th

Re: [logging] Avalon log not Serializable?

2006-02-21 Thread robert burrell donkin
On Tue, 2006-02-21 at 23:58 +1300, Simon Kitching wrote: > Craig Mcc has also confirmed it looks broken to him. yep, broke > Here are the options I can see: > (a) remove AvalonLogger from the JCL 1.1 distribution. > (b) remove Serializable marker interface from AvalonLogger > (c) on deserialize,

Re: [logging] Avalon log not Serializable?

2006-02-21 Thread Simon Kitching
On Tue, 2006-02-21 at 17:59 +1300, Simon Kitching wrote: > Hi, > > I've been checking whether all the standard Log adapter classes are > Serializable. The Avalon logger declares itself to be Serializable, but > my reading of the code indicates this won't work. Can someone > confirm/deny this? I'v

Re: [logging] Avalon log not Serializable?

2006-02-20 Thread Craig McClanahan
On 2/20/06, Simon Kitching <[EMAIL PROTECTED]> wrote: > > Hi, > > I've been checking whether all the standard Log adapter classes are > Serializable. The Avalon logger declares itself to be Serializable, but > my reading of the code indicates this won't work. Can someone > confirm/deny this? I su

[logging] Avalon log not Serializable?

2006-02-20 Thread Simon Kitching
Hi, I've been checking whether all the standard Log adapter classes are Serializable. The Avalon logger declares itself to be Serializable, but my reading of the code indicates this won't work. Can someone confirm/deny this? The javadoc has this: * Note: AvalonLogger implements * Serializable f