DoubleMetaphone and Nysiis have been committed.
Kyle, thanks for the code.
Here's a numbered list...
1. Thread Safety - All of the other encoders are thread safe in that
multiple threads can call encode on a single instance of the class.
Since we intend codec to be in wide use, it might
Big worry for code like this is to make sure the licencing etc is okay. As
even the cvs-sandbox is published code, making sure that the ASF are not
taking over ownership of code without permission is important.
These seem okay. Nysiis and DoubleMetaphone are names of algorithms and
not
not a lawyer. We do intend to modify the code.
Tim O'Brien
-Original Message-
From: Henri Yandell [mailto:[EMAIL PROTECTED]]
Sent: Monday, February 03, 2003 10:09 AM
To: Jakarta Commons Developers List
Cc: 'Kyle R . Burton'
Subject: RE: [codec] Re: DoubleMetaphone
formatting looks close enough to me :)
(whoever commits should probably go through the code and correct any small
problems anyway.)
since this is a (reasonably) significant donation of code for which
versions with other copyright already exist, we should probably check with
the foundation to
Definitely. I've got a bunch of codec things that built up while I was
away [I've been submitting patches when they've been sitting around for a
bit]. I'll add this to the list and try to push them through. Hopefully as
codec gains submissions, it can gain a bit of life.
Hen
Great! I'm
Straight off the top of my head, just match the format of Metaphone in any
obvious ways. Copy the license declaration, javadoc as much as it does,
don't do any blatant things it doesn't do code standard wise.
Obeying the Sun code standard is usually the easy thing to do.
There's probably a
Straight off the top of my head, just match the format of Metaphone in any
obvious ways. Copy the license declaration, javadoc as much as it does,
don't do any blatant things it doesn't do code standard wise.
- Copied license: check
- Added Javadoc comments: check
Obeying the Sun code
One last annoyance...I put the new classes in a sub-directory of the
old ones:
http://www.bgw.org/projects/java/phonetic/jakarta-commons-codec/
They already have changed package names for org.apache.commons.codec.
Thanks again,
Kyle R. Burton
--
