Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-24 Thread Henri Yandell
On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Niall Pemberton wrote: On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Noticed the call of toString() on a String during the huntdown of what in beanutils broke the betwixt tests. (in the TestObjectStringConverters) The

Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-24 Thread Niall Pemberton
On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Niall Pemberton wrote: On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Noticed the call of toString() on a String during the huntdown of what in beanutils broke the betwixt tests. (in the TestObjectStringConverters) The

Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-24 Thread Martin van den Bemt
Thanx.. Mvgr, Martin Niall Pemberton wrote: On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Niall Pemberton wrote: On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Noticed the call of toString() on a String during the huntdown of what in beanutils broke the betwixt

Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-23 Thread Martin van den Bemt
Niall Pemberton wrote: On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Noticed the call of toString() on a String during the huntdown of what in beanutils broke the betwixt tests. (in the TestObjectStringConverters) The commit was a bit premature probably, although this is most

svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-22 Thread mvdb
Author: mvdb Date: Fri Jun 22 17:58:02 2007 New Revision: 549986 URL: http://svn.apache.org/viewvc?view=revrev=549986 Log: Prevent calling toString on a String. Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java Modified:

Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-22 Thread Niall Pemberton
Is there a reason for this change? AFAIK calling toString() on a String object just returns a reference to itself - so this just seems to add clutter in my mind. Also there was discussion on this (i.e. calling toString() on a String) for this very bit of code in the following issue ticket - would

Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-22 Thread Martin van den Bemt
Noticed the call of toString() on a String during the huntdown of what in beanutils broke the betwixt tests. (in the TestObjectStringConverters) The commit was a bit premature probably, although this is most (read most, so not all) of the time faster that calling toString() on a String. Will

Re: svn commit: r549986 - /jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java

2007-06-22 Thread Niall Pemberton
On 6/23/07, Martin van den Bemt [EMAIL PROTECTED] wrote: Noticed the call of toString() on a String during the huntdown of what in beanutils broke the betwixt tests. (in the TestObjectStringConverters) The commit was a bit premature probably, although this is most (read most, so not all) of