Re: [VOTE] Release ManifoldCF 0.5.1, RC0

2012-05-17 Thread Karl Wright
I see two problems.

First, the outer level names are correct
(apache-manifoldcf-0.5.1-xxx), but the prefix inside is incorrect
(apache-manifoldcf-0.5).  This is odd because the build.xml has this
line:

target name=set-version
  property name=release-version value=0.5.1/
/target

so I cannot explain this unless somehow the artifacts were built with
an old version of build.xml.

The second problem is that we need to rev the pom.xml versions also.
They have to be 0.5.1 not 0.5.  I'll take care of that.

Karl

On Wed, May 16, 2012 at 10:26 PM, Karl Wright daddy...@gmail.com wrote:
 Thanks!
 I'll have a look in the morning...
 Karl

 On Wed, May 16, 2012 at 10:24 PM, Shinichiro Abe
 shinichiro.ab...@gmail.com wrote:
 Hi,

 You can download the release candidate from
 http://people.apache.org/~shinichiro/apache-manifoldcf-0.5.1-RC0/
 and there is also a tag in svn under
 https://svn.apache.org/repos/asf/incubator/lcf/tags

 I've already checked signatures,
 run example and run ant test-dr test-hs.

 Thank you,
 Shinichiro Abe


Re: [VOTE] Release ManifoldCF 0.5.1, RC0

2012-05-17 Thread Karl Wright
ok - I'm done with the maven work.  Abe-san, can you check to be sure
that the release branch builds with the proper prefixes before tagging
again?

Thanks!
Karl


On Thu, May 17, 2012 at 6:08 PM, Karl Wright daddy...@gmail.com wrote:
 I see two problems.

 First, the outer level names are correct
 (apache-manifoldcf-0.5.1-xxx), but the prefix inside is incorrect
 (apache-manifoldcf-0.5).  This is odd because the build.xml has this
 line:

    target name=set-version
      property name=release-version value=0.5.1/
    /target

 so I cannot explain this unless somehow the artifacts were built with
 an old version of build.xml.

 The second problem is that we need to rev the pom.xml versions also.
 They have to be 0.5.1 not 0.5.  I'll take care of that.

 Karl

 On Wed, May 16, 2012 at 10:26 PM, Karl Wright daddy...@gmail.com wrote:
 Thanks!
 I'll have a look in the morning...
 Karl

 On Wed, May 16, 2012 at 10:24 PM, Shinichiro Abe
 shinichiro.ab...@gmail.com wrote:
 Hi,

 You can download the release candidate from
 http://people.apache.org/~shinichiro/apache-manifoldcf-0.5.1-RC0/
 and there is also a tag in svn under
 https://svn.apache.org/repos/asf/incubator/lcf/tags

 I've already checked signatures,
 run example and run ant test-dr test-hs.

 Thank you,
 Shinichiro Abe


Re: [VOTE] Release ManifoldCF 0.5.1, RC0

2012-05-17 Thread Shinichiro Abe
What is the prefix inside? 
I ' m not sure where prefixes is.
Where do I check? the source code or jar file?

Thank you for modifying the pom.xml.

Shinichiro Abe

On 2012/05/18, at 7:13, Karl Wright wrote:

 ok - I'm done with the maven work.  Abe-san, can you check to be sure
 that the release branch builds with the proper prefixes before tagging
 again?
 
 Thanks!
 Karl
 
 
 On Thu, May 17, 2012 at 6:08 PM, Karl Wright daddy...@gmail.com wrote:
 I see two problems.
 
 First, the outer level names are correct
 (apache-manifoldcf-0.5.1-xxx), but the prefix inside is incorrect
 (apache-manifoldcf-0.5).  This is odd because the build.xml has this
 line:
 
target name=set-version
  property name=release-version value=0.5.1/
/target
 
 so I cannot explain this unless somehow the artifacts were built with
 an old version of build.xml.
 
 The second problem is that we need to rev the pom.xml versions also.
 They have to be 0.5.1 not 0.5.  I'll take care of that.
 
 Karl
 
 On Wed, May 16, 2012 at 10:26 PM, Karl Wright daddy...@gmail.com wrote:
 Thanks!
 I'll have a look in the morning...
 Karl
 
 On Wed, May 16, 2012 at 10:24 PM, Shinichiro Abe
 shinichiro.ab...@gmail.com wrote:
 Hi,
 
 You can download the release candidate from
 http://people.apache.org/~shinichiro/apache-manifoldcf-0.5.1-RC0/
 and there is also a tag in svn under
 https://svn.apache.org/repos/asf/incubator/lcf/tags
 
 I've already checked signatures,
 run example and run ant test-dr test-hs.
 
 Thank you,
 Shinichiro Abe



Re: [VOTE] Release ManifoldCF 0.5.1, RC0

2012-05-17 Thread Karl Wright
If you open up the zip or tar, the top-level directory is
apache-manifoldcf-0.5.  That directory is set in build.xml when the
zip or tar is built:

  zip destfile=apache-manifoldcf-${release-version}-src.zip
update=false
zipfileset dir=. prefix=apache-manifoldcf-${release-version}

So, ${release-version} must have been incorrect.  But it is correct
now on the branch:

target name=set-version
  property name=release-version value=0.5.1/
/target

So somehow you must have built the artifacts from a version of the
branch before you checked in the release-version change.

Karl

On Thu, May 17, 2012 at 8:27 PM, Shinichiro Abe
shinichiro.ab...@gmail.com wrote:
 What is the prefix inside?
 I ' m not sure where prefixes is.
 Where do I check? the source code or jar file?

 Thank you for modifying the pom.xml.

 Shinichiro Abe

 On 2012/05/18, at 7:13, Karl Wright wrote:

 ok - I'm done with the maven work.  Abe-san, can you check to be sure
 that the release branch builds with the proper prefixes before tagging
 again?

 Thanks!
 Karl


 On Thu, May 17, 2012 at 6:08 PM, Karl Wright daddy...@gmail.com wrote:
 I see two problems.

 First, the outer level names are correct
 (apache-manifoldcf-0.5.1-xxx), but the prefix inside is incorrect
 (apache-manifoldcf-0.5).  This is odd because the build.xml has this
 line:

    target name=set-version
      property name=release-version value=0.5.1/
    /target

 so I cannot explain this unless somehow the artifacts were built with
 an old version of build.xml.

 The second problem is that we need to rev the pom.xml versions also.
 They have to be 0.5.1 not 0.5.  I'll take care of that.

 Karl

 On Wed, May 16, 2012 at 10:26 PM, Karl Wright daddy...@gmail.com wrote:
 Thanks!
 I'll have a look in the morning...
 Karl

 On Wed, May 16, 2012 at 10:24 PM, Shinichiro Abe
 shinichiro.ab...@gmail.com wrote:
 Hi,

 You can download the release candidate from
 http://people.apache.org/~shinichiro/apache-manifoldcf-0.5.1-RC0/
 and there is also a tag in svn under
 https://svn.apache.org/repos/asf/incubator/lcf/tags

 I've already checked signatures,
 run example and run ant test-dr test-hs.

 Thank you,
 Shinichiro Abe



Re: [VOTE] Release ManifoldCF 0.5.1, RC0

2012-05-16 Thread Karl Wright
Thanks!
I'll have a look in the morning...
Karl

On Wed, May 16, 2012 at 10:24 PM, Shinichiro Abe
shinichiro.ab...@gmail.com wrote:
 Hi,

 You can download the release candidate from
 http://people.apache.org/~shinichiro/apache-manifoldcf-0.5.1-RC0/
 and there is also a tag in svn under
 https://svn.apache.org/repos/asf/incubator/lcf/tags

 I've already checked signatures,
 run example and run ant test-dr test-hs.

 Thank you,
 Shinichiro Abe