Re: [PATCH] Add support for EAP configuration via service-api

Marcel Holtmann writes: > Hi Kalle, Hi again Marcel, >> There are WPA Enterprise networks just with a list of settings and >> possible screenshots of settings dialogs from different devices. Here >> are few examples I quickly googled: >> >> http://oregonstate.edu/helpdocs/wireless/getting-conn

Re: [PATCH] Add support for EAP configuration via service-api

Hi Kalle, > >> There are WPA Enterprise networks just with a list of settings and > >> possible screenshots of settings dialogs from different devices. Here > >> are few examples I quickly googled: > >> > >> http://oregonstate.edu/helpdocs/wireless/getting-connected/OSU-secure > >> http://www.oit

Re: [PATCH] Add support for EAP configuration via service-api

On Fri, 2010-08-20 at 10:37 +0200, ext Marcel Holtmann wrote: > I am not signing up for confusing the end user. If it is more than > username and password, it will not be exposed by the UI. Unfortunately I'm in the same camp as Kalle disagreeing on this one. Setting up WPA Enterprise WLANs must be

Re: [PATCH ofono-online-v3 2/6] Log more of the ofono errors

Hi Pekka, On Thu, Aug 19, 2010 at 08:13:59PM +0300, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > plugins/ofono.c | 34 +- > 1 files changed, 29 insertions(+), 5 deletions(-) > > diff --git a/plugins/ofono.c b/plugins/ofono.c > index 69121e2..8768

Re: [PATCH ofono-online-v3 3/6] Fix stale data usage in oFono plugin

Hi Pekka, On Thu, Aug 19, 2010 at 08:14:00PM +0300, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > plugins/ofono.c | 28 ++-- > 1 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/plugins/ofono.c b/plugins/ofono.c > index 8768eca..1ed4880 1

Re: [PATCH] Add support for EAP configuration via service-api

Hi Patrik, > > I am not signing up for confusing the end user. If it is more than > > username and password, it will not be exposed by the UI. > > Unfortunately I'm in the same camp as Kalle disagreeing on this one. > Setting up WPA Enterprise WLANs must be possible even for the end user. > In ad

[PATCH v2] Handle several counters simultaniously

From: Daniel Wagner The current implementation does not handle multiple counters at the same time correctly. Only the first counter gets the updates, all others just an empty dictionary. For each Counter object the counters have to be maintained separately. --- It's still a WIP, not cleanup yet

[PATCH ofono 1/4] Refactor oFono SetProperty D-Bus calls

From: Pekka Pessi --- plugins/ofono.c | 177 ++- 1 files changed, 45 insertions(+), 132 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 2f67a99..69121e2 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -3,6 +3,7 @@ *

[PATCH ofono 3/4] Fix stale data usage in oFono plugin

From: Pekka Pessi --- plugins/ofono.c | 33 +++-- 1 files changed, 23 insertions(+), 10 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 5ac77f5..f0c29a8 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -191,6 +191,11 @@ static struct connman_

[PATCH ofono 4/4] Avoid race between ofono signals and methods

From: Pekka Pessi Create modem only after Modem.GetProperties succeeds, thus avoiding races with Modem.PropertyChanged signal. Do not call Modem.GetProperties again while modem exists. --- plugins/ofono.c | 53 ++--- 1 files changed, 34 insertion

[PATCH ofono 2/4] Log more of the ofono errors

From: Pekka Pessi --- plugins/ofono.c | 32 +++- 1 files changed, 27 insertions(+), 5 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 69121e2..5ac77f5 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -92,8 +92,8 @@ static void set_property_re

[Trivia PATCH 3/5] Indicate that connman uses GNU extensions of glibc

From: Pekka Pessi --- configure.ac |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 83aa29e..7762f5c 100644 --- a/configure.ac +++ b/configure.ac @@ -30,6 +30,8 @@ AM_PROG_MKDIR_P m4_define([_LT_AC_TAGCONFIG], []) m4_ifdef([AC_LIBTOOL_

[Trivia PATCH 5/5] error: fix warning about formatting string

From: Pekka Pessi --- src/error.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/error.c b/src/error.c index e80d034..7f6b8c9 100644 --- a/src/error.c +++ b/src/error.c @@ -68,7 +68,7 @@ DBusMessage *__connman_error_failed(DBusMessage *msg, int errnum) }

[Trivia PATCH 4/5] Check harder for -lresolv

From: Pekka Pessi Older Debians and friends expose __ns_initparse and their resolv.h defines ns_initparse is __ns_initparse. --- configure.ac |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7762f5c..b7bfd67 100644 --- a/configure.ac

[Trivia PATCH 2/5] Fix signed/unsigned comparison warning

From: Pekka Pessi --- gdhcp/client.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index 430ecc8..a15687b 100644 --- a/gdhcp/client.c +++ b/gdhcp/client.c @@ -533,14 +533,14 @@ static gboolean sanity_check(struct ip_udp_dhcp_packet

Re: [Trivia PATCH 2/5] Fix signed/unsigned comparison warning

Hi Pekka, > --- > gdhcp/client.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdhcp/client.c b/gdhcp/client.c > index 430ecc8..a15687b 100644 > --- a/gdhcp/client.c > +++ b/gdhcp/client.c > @@ -533,14 +533,14 @@ static gboolean sanity_check(struct ip_udp_dhc

Re: [Trivia PATCH 3/5] Indicate that connman uses GNU extensions of glibc

Hi Pekka, > configure.ac |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 83aa29e..7762f5c 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -30,6 +30,8 @@ AM_PROG_MKDIR_P > m4_define([_LT_AC_TAGCONFIG], []) > m4_ifdef([AC_L

Re: [Trivia PATCH 4/5] Check harder for -lresolv

Hi Pekka, > Older Debians and friends expose __ns_initparse and their resolv.h > defines ns_initparse is __ns_initparse. > --- > configure.ac |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 7762f5c..b7bfd67 100644 > --- a/conf

Re: [Trivia PATCH 5/5] error: fix warning about formatting string

Hi Pekka, > --- > src/error.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH ofono 1/4] Refactor oFono SetProperty D-Bus calls

Hi Pekka, On Fri, Aug 20, 2010 at 06:32:15PM +0300, pekka.pe...@nokia.com wrote: > From: Pekka Pessi So I'm seeing regressions with this patch and my Ericsson f3607gw USB modem. Most of the time autoconnect fails and I randomly get crashes with it after it fails: connmand[20603]: plugins/ofono.c

Re: [PATCH v2] Handle several counters simultaniously

Hi Daniel, On Fri, Aug 20, 2010 at 04:49:46PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > The current implementation does not handle multiple > counters at the same time correctly. Only the first > counter gets the updates, all others just an empty > dictionary. > > For each Counter o