[PATCH] service: Check NULL pointer when setting ipconfig.

Fixes BMC#22766 --- Hi, this fixes the bug https://bugs.meego.com/show_bug.cgi?id=22766 where we must check if the ipconfig is NULL before trying to access it. The problem happened as 3G connection did not have an IPv6 address. Jukka src/service.c |3 +++ 1 files changed, 3 insertions(+),

[PATCH] resolver: Fix memory leak when resolver is stopped.

--- Hi, I noticed that resolver memory is not released when using -r connman option (dnsproxy is disabled). Jukka src/resolver.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/src/resolver.c b/src/resolver.c index 59defd4..7d15c14

[PATCH] resolver: Do not overwrite existing entries in /etc/resolv.conf

--- Hi, it is very annoying when connman clears /etc/resolv.conf and removes users own settings there. This patch remembers user settings (if dnsproxy is not in use i.e., -r option is being used) and does not remove them unnecessarily. Jukka src/resolver.c | 60

[PATCH] timezone: Do not access already released memory.

closedir() releases the filename but we were accessing it later. --- src/timezone.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/timezone.c b/src/timezone.c index 08f904f..1234622 100644 --- a/src/timezone.c +++ b/src/timezone.c @@ -185,9 +185,10 @@ static char

[PATCH] gresolv: Fix buffer size.

Make buf just big enough and initialize it in order to get rid of valgrind error (accessing uninitialized memory). --- gweb/gresolv.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gweb/gresolv.c b/gweb/gresolv.c index d857e01..0e7a755 100644 --- a/gweb/gresolv.c

[PATCH] valgrind: Suppression file for connman.

Suppress the valgrind warnings/errors that we cannot control. Use the file like this: valgrind --leak-check=full --suppressions=.valgrind.suppressions --show-reachable=yes ./src/connmand -n -d --- .valgrind.suppressions | 71 1 files changed,

[PATCH] test: Fix dbus path in service-move-before script.

Because of patch f8ef8b2a7f7ef1bd9e26df6cfb19a838e6b10b17 that removed profile support, the path needs to be changed. --- test/service-move-before |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/service-move-before b/test/service-move-before index f1fddd1..d912c88

[PATCH] gsupplicant: Do not access IE array past end of buffer.

IE list was traversed past buffer limit in the last round. --- gsupplicant/supplicant.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index e5743f0..2586075 100644 --- a/gsupplicant/supplicant.c +++

[PATCH] valgrind: Configuration file for connman.

--- Hi, note this file needs to be owned by root when valgrind is run by root so change the owner of the file to root when valgrinding connman. Jukka .valgrindrc |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) create mode 100644 .valgrindrc diff --git a/.valgrindrc b/.valgrindrc

Re: [PATCH] valgrind: Configuration file for connman.

Hi Marcel, On 09/05/2011 01:04 PM, Marcel Holtmann wrote: Hi Jukka, note this file needs to be owned by root when valgrind is run by root so change the owner of the file to root when valgrinding connman. .valgrindrc |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) create

Re: [PATCH fast connect v2 5/5] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

Hi Marcel, On 09/05/2011 01:40 PM, Marcel Holtmann wrote: Hi Patrik, + keyfile = g_key_file_new(); + + if (g_file_get_contents(pathname,data,length, NULL) == FALSE) { + g_free(pathname); + return -ENOENT; + } + + g_free(pathname); + +

[PATCH fast connect v3 0/7] Fast connect

Hi, this 3rd version contains support for the new storage module. These patches are rebased over Alok's storage module patches. Jukka Jukka Rissanen (2): storage: Add services getter. storage: Export service loading function. Mohamed Abbas (5): service: Add frequency support to service

[PATCH fast connect v3 1/7] storage: Add services getter.

--- include/storage.h | 37 src/storage.c | 54 + 2 files changed, 91 insertions(+), 0 deletions(-) create mode 100644 include/storage.h diff --git a/include/storage.h b/include/storage.h new file

[PATCH fast connect v3 2/7] storage: Export service loading function.

plugins/wifi.c needs to load services so export the function. --- Makefile.am |3 ++- include/storage.h |1 + src/service.c |6 -- src/storage.c |2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index 6c349ed..bbdc55c

[PATCH fast connect v3 3/7] service: Add frequency support to service.

From: Mohamed Abbas mohamed.ab...@intel.com Get the frequncy of gsupplicant network on connman network creation, and always save the frequency of the wifi service. --- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 10 ++ plugins/wifi.c|3 +++

[PATCH fast connect v3 4/7] wifi: Add support to multi scan type.

From: Mohamed Abbas mohamed.ab...@intel.com Allow multi scan type for fast connect. Scanning request removed from interface_added() because it is already called in connman_device_set_powered() so no need to call it again immediately (fix by Jukka Rissanen jukka.rissa...@linux.intel.com

[PATCH fast connect v3 5/7] gsupplicant: Add support to append char ** entries to dbus dict.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/dbus.c | 34 ++ gsupplicant/dbus.h | 20 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c index e014265..7d427be 100644 ---

[PATCH fast connect v3 6/7] gsupplicant: Get the number of scan ssids from supplicant.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/gsupplicant.h |2 ++ gsupplicant/supplicant.c | 18 +- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 8e3690b..1419157 100644 ---

[PATCH fast connect v3 7/7] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

From: Mohamed Abbas mohamed.ab...@intel.com Lot of fixes by Jukka Rissanen jukka.rissa...@linux.intel.com --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 135 ++- plugins/wifi.c| 196 - 3

[PATCH fast-connect v4 0/7] Fast connect

Hi, this 4th version contains device ref count fix noticed by Patrik. The patch #7 requires this patch http://lists.connman.net/pipermail/connman/2011-September/006283.html from Patrik to be commited first. Cheers, Jukka Jukka Rissanen (2): storage: Add services getter. storage: Export

[PATCH fast-connect v4 1/7] storage: Add services getter.

--- include/storage.h | 37 src/storage.c | 54 + 2 files changed, 91 insertions(+), 0 deletions(-) create mode 100644 include/storage.h diff --git a/include/storage.h b/include/storage.h new file

[PATCH fast-connect v4 2/7] storage: Export service loading function.

plugins/wifi.c needs to load services so export the function. --- Makefile.am |3 ++- include/storage.h |1 + src/service.c |6 -- src/storage.c |2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index 6c349ed..bbdc55c

[PATCH fast-connect v4 4/7] wifi: Add support to multi scan type.

From: Mohamed Abbas mohamed.ab...@intel.com Allow multi scan type for fast connect. Scanning request removed from interface_added() because it is already called in connman_device_set_powered() so no need to call it again immediately (fix by Jukka Rissanen jukka.rissa...@linux.intel.com

[PATCH fast-connect v4 5/7] gsupplicant: Add support to append char ** entries to dbus dict.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/dbus.c | 34 ++ gsupplicant/dbus.h | 20 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c index e014265..7d427be 100644 ---

[PATCH fast-connect v4 7/7] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

From: Mohamed Abbas mohamed.ab...@intel.com Lot of fixes by Jukka Rissanen jukka.rissa...@linux.intel.com --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 135 +- plugins/wifi.c| 199 - 3

[PATCH] bootstrap: Remove portal configuration.

--- bootstrap-configure |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/bootstrap-configure b/bootstrap-configure index 53b0732..12646a2 100755 --- a/bootstrap-configure +++ b/bootstrap-configure @@ -26,7 +26,6 @@ fi --enable-pacrunner=builtin \

[PATCH fast connect v5 1/7] storage: Add services getter.

From: Jukka Rissanen jukka.rissa...@nokia.com --- Makefile.am |3 +- include/storage.h | 37 src/storage.c | 54 + 3 files changed, 93 insertions(+), 1 deletions(-) create mode 100644

[PATCH fast connect v5 0/7] Fast connect

Hi, this 5th version fixes the makefile in first two patches. Jukka Jukka Rissanen (2): storage: Add services getter. storage: Export service loading function. Mohamed Abbas (5): service: Add frequency support to service. wifi: Add support to multi scan type. gsupplicant: Add

[PATCH fast connect v5 3/7] service: Add frequency support to service.

From: Mohamed Abbas mohamed.ab...@intel.com Get the frequncy of gsupplicant network on connman network creation, and always save the frequency of the wifi service. --- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 10 ++ plugins/wifi.c|3 +++

[PATCH fast connect v5 2/7] storage: Export service loading function.

From: Jukka Rissanen jukka.rissa...@nokia.com --- include/storage.h |1 + src/connman.h |1 - src/service.c |6 -- src/storage.c |2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/storage.h b/include/storage.h index cd05c60..c108511

[PATCH fast connect v5 5/7] gsupplicant: Add support to append char ** entries to dbus dict.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/dbus.c | 34 ++ gsupplicant/dbus.h | 20 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c index e014265..7d427be 100644 ---

[PATCH fast connect v5 4/7] wifi: Add support to multi scan type.

From: Mohamed Abbas mohamed.ab...@intel.com Allow multi scan type for fast connect. Scanning request removed from interface_added() because it is already called in connman_device_set_powered() so no need to call it again immediately (fix by Jukka Rissanen jukka.rissa...@linux.intel.com

[PATCH fast connect v5 6/7] gsupplicant: Get the number of scan ssids from supplicant.

From: Mohamed Abbas mohamed.ab...@intel.com --- gsupplicant/gsupplicant.h |2 ++ gsupplicant/supplicant.c | 18 +- 2 files changed, 19 insertions(+), 1 deletions(-) diff --git a/gsupplicant/gsupplicant.h b/gsupplicant/gsupplicant.h index 8262ad0..a68bba0 100644 ---

[PATCH fast connect v5 7/7] wifi: Add SSIDs and frequencies to wpa_supplicant scan for fast scan.

From: Mohamed Abbas mohamed.ab...@intel.com Lot of fixes by Jukka Rissanen jukka.rissa...@linux.intel.com --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 135 +- plugins/wifi.c| 199 - 3

Re: [PATCH fast connect v5 1/7] storage: Add services getter.

On 09/13/2011 09:55 AM, Jukka Rissanen wrote: From: Jukka Rissanenjukka.rissa...@nokia.com D'oh, I must have been sleeping when sending the patches :) Samuel, please remove the extra and wrong From: line from #1 and #2 patches before applying. Thanks, Jukka

[PATCH] provider: Fix memory leak.

Provider name is already allocated in connman_provider_get() so we must deallocate it before setting it again. --- src/provider.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/provider.c b/src/provider.c index 8f1862e..d6d1b7e 100644 --- a/src/provider.c +++

[PATCH] provider: Remove provider if there is an error when connecting.

If vpn service cannot be started for some reason, we must remove the provider so that user can reconnect to it later. --- src/provider.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/provider.c b/src/provider.c index d6d1b7e..9f7050f 100644 ---

[PATCH l2tp/pptp v2 00/17] L2TP/PPTP support

Hi, here is the resend of L2TP/PPTP patches. The patches contain fixes suggested by Daniel Wagner. I also merged some of the v1 patches together. Jukka Jukka Rissanen (11): vpn: Add null checks. l2tp: Add l2tp makefile and configure file. pptp: Add pptp makefile and configure file

[PATCH l2tp/pptp v2 01/17] vpn: Add support to allow ppp tunnelling.

. This patch is prepared by Jukka Rissanen and it contains Mohamed Abbas original patch + fixes suggested by Daniel Wagner. Jukka fixed memory leak in vpn_set_ifname(). --- plugins/vpn.c | 122 ++--- plugins/vpn.h |4 ++ 2 files changed, 94

[PATCH l2tp/pptp v2 02/17] vpn: Add null checks.

--- plugins/vpn.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/plugins/vpn.c b/plugins/vpn.c index ec841b4..a016194 100644 --- a/plugins/vpn.c +++ b/plugins/vpn.c @@ -77,6 +77,9 @@ static int stop_vpn(struct connman_provider *provider)

[PATCH l2tp/pptp v2 03/17] task: Allow vpn plugins to send reply.

From: Mohamed Abbas mab...@linux.intel.com Change task notify to allow client to send dbus reply. This will allow vpn plugin to send requested user/password info. --- include/task.h |2 +- plugins/vpn.c |8 +--- src/task.c | 30 +- 3 files changed,

[PATCH l2tp/pptp v2 04/17] pptp: Add pptp vpn support

From: Mohamed Abbas mab...@linux.intel.com Initial revision. --- plugins/pptp.c | 313 1 files changed, 313 insertions(+), 0 deletions(-) create mode 100644 plugins/pptp.c diff --git a/plugins/pptp.c b/plugins/pptp.c new file mode

[PATCH l2tp/pptp v2 06/17] l2tp: Add l2tp vpn support.

From: Mohamed Abbas mab...@linux.intel.com Initial revision. --- plugins/l2tp.c | 508 1 files changed, 508 insertions(+), 0 deletions(-) create mode 100644 plugins/l2tp.c diff --git a/plugins/l2tp.c b/plugins/l2tp.c new file mode

[PATCH l2tp/pptp v2 07/17] test: Add test script support for pptp/l2tp.

From: Mohamed Abbas mab...@linux.intel.com Modify connect-vpn script to handle pptp/l2tp connection. --- test/connect-vpn | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/test/connect-vpn b/test/connect-vpn index a43c4cd..00fa717 100755 ---

[PATCH l2tp/pptp v2 09/17] pptp: Add pptp makefile and configure file.

--- Makefile.plugins | 19 +++ configure.ac | 22 ++ 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index 64bd8e7..c029111 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -155,6 +155,25 @@

[PATCH l2tp/pptp v2 08/17] l2tp: Add l2tp makefile and configure file.

--- Makefile.plugins | 18 ++ configure.ac | 22 ++ 2 files changed, 40 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index bb3a90b..64bd8e7 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -137,6 +137,24 @@

[PATCH l2tp/pptp v2 10/17] scripts: Compile libppp-plugin.so properly.

--- Makefile.plugins | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/Makefile.plugins b/Makefile.plugins index c029111..58b0494 100644 --- a/Makefile.plugins +++ b/Makefile.plugins @@ -3,6 +3,8 @@ plugin_cflags = -fvisibility=hidden -I$(srcdir)/gdbus \

[PATCH l2tp/pptp v2 12/17] l2tp: Check authentication error properly.

--- plugins/l2tp.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/l2tp.c b/plugins/l2tp.c index 5d591eb..34dfe06 100644 --- a/plugins/l2tp.c +++ b/plugins/l2tp.c @@ -158,6 +158,9 @@ static int l2tp_notify(DBusMessage *msg, struct connman_provider *provider)

[PATCH l2tp/pptp v2 11/17] scripts: Report authentication error to connman.

The ppp plugin now checks ppp authentication error and report it to correct connman plugin. --- scripts/libppp-plugin.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/scripts/libppp-plugin.c b/scripts/libppp-plugin.c index ba79db0..911551c 100644 ---

[PATCH l2tp/pptp v2 13/17] pptp: Return authentication errors properly.

--- plugins/pptp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index 6b2838c..814be99 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -120,6 +120,9 @@ static int pptp_notify(DBusMessage *msg, struct connman_provider *provider)

[PATCH l2tp/pptp v2 14/17] pptp: Do not put password in command line options.

--- plugins/pptp.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/plugins/pptp.c b/plugins/pptp.c index 814be99..f969d1b 100644 --- a/plugins/pptp.c +++ b/plugins/pptp.c @@ -56,7 +56,6 @@ struct { int type; } pptp_options[] = { { PPTP.User, user, NULL,

[PATCH l2tp/pptp v2 15/17] readme: Add l2tp and pptp information.

--- README | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/README b/README index 0cec62b..532e327 100644 --- a/README +++ b/README @@ -41,6 +41,21 @@ To compile and install run: make make install +VPN +=== + +In order to compile pptp and l2tp

[PATCH l2tp/pptp v2 16/17] task: Make sure the process is eventually killed.

If a task refuses to kill itself, then wait two secs before trying again and if that does not help then forcefully kill it. --- src/task.c | 44 +++- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/src/task.c b/src/task.c index

[PATCH l2tp/pptp v2 17/17] todo: Mark l2tp and pptp as done.

--- TODO | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/TODO b/TODO index 69dde48..a420d4a 100644 --- a/TODO +++ b/TODO @@ -135,20 +135,6 @@ Cellular VPN === -- l2tp support - - Priority: Low - Complexity: C2 - Owner: Mohamed Abbas

[PATCH l2tp/pptp v3 06/17] l2tp: Add l2tp vpn support.

From: Mohamed Abbas mab...@linux.intel.com Initial revision. --- Hi, this version fixes the memory leak in error case when xl2tpd config file cannot be written in l2tp_connect() and removes vpnc references from the code. Thanks Patrik for review. Jukka plugins/l2tp.c | 509

Re: multiple interfaces and routing problem

Hi Geoffroy, On 09/23/2011 12:52 PM, VanCutsem, Geoffroy wrote: Hi, I see the same problem too (have seen it with both Connman 0.69.6-4.2 and 0.69.4-1.5 actually). I can very consistently reproduce this by doing the following: - Boot your machine (whatever it is), in my case running MeeGo

Re: multiple interfaces and routing problem

On 09/23/2011 02:48 PM, VanCutsem, Geoffroy wrote: Sounds like you have two default routes. Check with netstat -rn, if you have two default routes then that is is the culprit. You could upgrade to newer connman which should fix the issue. Any recommendation in terms of version to use or

Re: [PATCH 0/4] multi-path and routing issue for incoming packets

Hi Julien, On 09/23/2011 04:17 PM, Julien Massot wrote: These patchs are just for helping people who have problems with multiple interfaces and incomming packets. Some part of these patchs better looks like hacks, like the index2tid function. Some parts are not implemented like the settings

Re: multiple interfaces and routing problem

Hi Geoffroy, On 09/26/2011 09:07 PM, VanCutsem, Geoffroy wrote: Hi Jukka, -Original Message- From: Jukka Rissanen [mailto:jukka.rissa...@linux.intel.com] Sent: Friday, September 23, 2011 2:01 PM To: VanCutsem, Geoffroy Cc: connman@connman.net Subject: Re: multiple interfaces

[PATCH] gdhcp: Added original copyright information.

The client.c, common.c and common.h files come originally from busybox at http://git.busybox.net/busybox/tree/networking/udhcp/ --- Hi, this issue in connman was discussed in connman mailing list last Feb but was forgotten, see http://lists.connman.net/pipermail/connman/2011-February/003718.html

Re: [RFC v1 1/3] session: Update Session API

Hi Daniel, On 10/10/2011 11:13 AM, Daniel Wagner wrote: Hi, I think an IdleTimeout per Session makes sense. It should map to a Service and not to a bearer, BTW. If you have for example a VPN tunnel over a cellular link and the application is only interested in idle timeout in the tunnel.

[PATCH] inet: Cleanup router solicitation callback properly after error.

The cleanup routine must be called after an error and after calling RS callback, otherwise the timeout is not removed in right time. --- src/inet.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/inet.c b/src/inet.c index d898650..56f29fd 100644 --- a/src/inet.c +++

[PATCH 1/2] gdhcp: Generic stateless DHCPv6 support.

The patch adds support for information-request DHCPv6 message. --- gdhcp/client.c | 464 gdhcp/common.c | 194 ++- gdhcp/common.h | 43 +- gdhcp/gdhcp.h | 22 +++- gdhcp/server.c |2 +- 5 files changed,

[PATCH 0/2] DHCPv6 stateless support

Hi, the following patch implements DHCPv6 information-request message i.e., stateless DHCPv6 support. We only get DNS and SNTP servers from DHCPv6 server. Tested against wide-dhcpv6-server v20080615-10 and dibbler-server 0.7.3 Regards, Jukka Jukka Rissanen (2): gdhcp: Generic stateless

[PATCH] dhcp: ref count network properly

--- src/dhcp.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 10e1403..c6df4fa 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -468,6 +468,8 @@ int __connman_dhcp_start(struct connman_network *network, dhcp_cb callback) dhcp-network

[PATCH] wispr: ref count service properly

--- src/wispr.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/wispr.c b/src/wispr.c index 1f470f7..a0d491a 100644 --- a/src/wispr.c +++ b/src/wispr.c @@ -721,6 +721,8 @@ int __connman_wispr_start(struct connman_service *service,

[PATCH 0/2] Allow routing when connected to same subnet

. This patch sets to rp_filter to value 2 when two or more services are connected at the same time. The original value is restored when other services are disconnected and only one service is connected. Cheers, Jukka Jukka Rissanen (2): ipconfig: set/unset IPv4 rp_filter setting service: Activate

[PATCH 2/2] service: Activate loose mode routing

If more than one service is connected at the same time, then activate loose mode routing by setting the /proc/sys/net/ipv4/conf/all/rp_filter to value 2 If the loose mode routing is not activated, then packets are not routed properly if services are connected to same subnet. The original value of

[PATCH 1/2] ipconfig: set/unset IPv4 rp_filter setting

--- src/connman.h |4 ++ src/ipconfig.c | 89 2 files changed, 93 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index e2b0f1c..2d03a8e 100644 --- a/src/connman.h +++ b/src/connman.h @@ -249,6 +249,10 @@

Re: [RFC v2 7/7] session: Add BearerAvailable

Hi Daniel, On 10/18/2011 10:51 AM, Daniel Wagner wrote: On 10/18/2011 09:36 AM, Patrik Flykt wrote: Hi, On Thu, 2011-10-13 at 08:04 -0700, Daniel Wagner wrote: + boolean BearerAvailable [readonly] + + As soon as a matching bearer is available +

Re: [RFC v2 7/7] session: Add BearerAvailable

Hi Daniel, On 10/18/2011 12:22 PM, Daniel Wagner wrote: Hi Jukka, On 10/18/2011 10:24 AM, Jukka Rissanen wrote: On 10/18/2011 10:51 AM, Daniel Wagner wrote: On 10/18/2011 09:36 AM, Patrik Flykt wrote: On Thu, 2011-10-13 at 08:04 -0700, Daniel Wagner wrote: + boolean

[PATCH] service: Remove the gateways when removing the service.

This is needed because connection.c takes a reference of the service so we want to remove the gateways properly so that service can be deleted and IP addresses released when disconnection comes from network side (like when ethernet cable is disconnected). --- src/service.c |3 +++ 1 files

[PATCH] service: Check NULL pointer.

--- src/service.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index 7486d5c..2c31b48 100644 --- a/src/service.c +++ b/src/service.c @@ -4127,6 +4127,9 @@ enum connman_service_state __connman_service_ipconfig_get_state(

[PATCH] network: Remove obsolete service lookup in disconnect.

--- src/network.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/network.c b/src/network.c index 50d0492..b58409f 100644 --- a/src/network.c +++ b/src/network.c @@ -1051,13 +1051,10 @@ static gboolean set_connected(gpointer user_data) } }

[PATCH v2 0/2] Allow routing when connected to same subnet

Hi, 2nd version fixes these issues: - remove the possibility to set rp_filter to some specific interface - do not register notifier but call rp_filter set/unset directly when service state changes Cheers, Jukka Jukka Rissanen (2): ipconfig: set/unset IPv4 rp_filter setting service

[PATCH v2 1/2] ipconfig: set/unset IPv4 rp_filter setting

--- src/connman.h |3 +++ src/ipconfig.c | 54 ++ 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index e2b0f1c..3871a4b 100644 --- a/src/connman.h +++ b/src/connman.h @@ -249,6 +249,9 @@ int

[PATCH v2 2/2] service: Activate loose mode routing

If more than one service is connected at the same time, then activate loose mode routing by setting the /proc/sys/net/ipv4/conf/all/rp_filter to value 2 If the loose mode routing is not activated, then packets are not routed properly if services are connected to same subnet. The original value of

Re: [PATCH v1 0/8] Add *_CLOSEXC

Hi, On 10/25/2011 02:37 PM, Marcel Holtmann wrote: Hi Daniel, here an splitter version of adding O_CLOEXEC and SOCK_CLOEXEC. I went ahead and applied all 8 patches. Thanks. Regards Marcel Unfortunately connman does not compile any more in meego 1.2 as O_CLOEXEC is not found. Fix is to

Re: [PATCH v1 0/8] Add *_CLOSEXC

Hi Marcel, On 25 October 2011 17:57, Marcel Holtmann mar...@holtmann.org wrote: Hi Jukka, here an splitter version of adding O_CLOEXEC and SOCK_CLOEXEC. I went ahead and applied all 8 patches. Thanks. Regards Marcel Unfortunately connman does not compile any more in meego 1.2

[PATCH 2/3] core: Fix compilation in MeeGo

The _GNU_SOURCE needs to be defined so that O_CLOEXEC symbols can be found in system header files. The source does not compile without the patch in MeeGo 1.2 --- src/inet.c |7 +-- src/resolver.c |1 + src/rfkill.c |1 + src/timezone.c |1 + 4 files changed, 4

[PATCH 3/3] tools: Fix compilation in MeeGo

The _GNU_SOURCE needs to be defined so that O_CLOEXEC symbols can be found in system header files. The source does not compile without the patch in MeeGo 1.2 --- tools/alg-test.c |1 + tools/tap-test.c |1 + tools/wispr.c|1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff

[PATCH] gdhcp: Possible file descriptor leak.

--- gdhcp/common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdhcp/common.c b/gdhcp/common.c index 9514c7c..5ec24e9 100644 --- a/gdhcp/common.c +++ b/gdhcp/common.c @@ -536,11 +536,11 @@ int dhcp_send_raw_packet(struct dhcp_packet *dhcp_pkt, */ n

[PATCH] inet: Fix file descriptor leak when comparing subnets.

--- src/inet.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/inet.c b/src/inet.c index e368f38..76c82c6 100644 --- a/src/inet.c +++ b/src/inet.c @@ -1244,6 +1244,9 @@ connman_bool_t connman_inet_compare_subnet(int index, const char *host)

[PATCH] network: Disconnect network properly.

When network is removed (for example when ethernet cable is disconnected), then network needs to be disconnected also. The disconnect was not done at all because of the reference counting fixes in dhcp code. --- src/network.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH] network: Check device pointer when doing IPv6 autoconf

The device can disappear if network is disconnected while setting autoconf parameters. --- src/network.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index c0e6024..e010aaa 100644 --- a/src/network.c +++ b/src/network.c @@ -1027,6

[PATCH dhcpv6-sl v2 0/2] dhcpv6: Support stateless DHCPv6

Hi, this version fixes the issues found out in v1. The patchset has been reworked so that it is now streamlined with stateful DHCPv6 patcheset (coming soon to mailing list). Cheers, Jukka Jukka Rissanen (2): gdhcp: Generic stateless DHCPv6 support. dhcpv6: Support stateless DHCPv6

[PATCH dhcpv6-sl v2 1/2] gdhcp: Generic stateless DHCPv6 support.

The patch adds support for information-request DHCPv6 message. --- gdhcp/client.c | 503 gdhcp/common.c | 202 ++- gdhcp/common.h | 43 +- gdhcp/gdhcp.h | 24 +++- gdhcp/server.c |2 +- 5 files changed,

[PATCH dhcpv6-sf v1 05/10] dhcpv6: Request message implemented.

--- gdhcp/client.c | 36 - gdhcp/gdhcp.h |8 src/dhcpv6.c | 123 3 files changed, 166 insertions(+), 1 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index 10042c8..4be5374 100644 ---

[PATCH dhcpv6-sf v1 08/10] dhcpv6: Handle address expiration by restarting the stack.

--- gdhcp/client.c | 18 ++- gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 65 +++ src/network.c | 28 +-- 4 files changed, 100 insertions(+), 15 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c

[PATCH dhcpv6-sf v1 06/10] dhcpv6: Renew message implemented.

--- gdhcp/client.c | 46 - gdhcp/gdhcp.h |5 ++- src/connman.h |2 + src/dhcpv6.c | 125 +++- src/network.c |2 + 5 files changed, 177 insertions(+), 3 deletions(-) diff --git a/gdhcp/client.c

[PATCH dhcpv6-sf v1 07/10] dhcpv6: Rebind message implemented.

--- gdhcp/client.c | 48 - gdhcp/gdhcp.h |4 ++- src/dhcpv6.c | 107 --- 3 files changed, 150 insertions(+), 9 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index f1ce555..3e6b596 100644 ---

[PATCH dhcpv6-sf v1 10/10] dhcpv6: Allow address setting in IPv6 auto mode.

The DHCPv6 is used when doing autoconfiguration so we must allow address setting/unsetting in auto mode. --- src/ipconfig.c |6 +++--- src/network.c |4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index cced765..2443735 100644 ---

[PATCH dhcpv6-sf v1 00/10] dhcpv6: Support stateful DHCPv6

Hi, this patchset adds stateful DHCPv6 support. Cheers, Jukka Jukka Rissanen (10): inet: Return router advertisement packet length in callback. inet: Get router advertisement prefix option information. ipconfig: Return IPv6 privacy status. dhcpv6: Initial stateful DHCPv6 support

[PATCH dhcpv6-sf v1 09/10] dhcpv6: Release message impelemented.

--- gdhcp/client.c | 31 gdhcp/gdhcp.h |1 + src/connman.h |2 + src/dhcpv6.c | 61 src/network.c | 17 ++- 5 files changed, 111 insertions(+), 1 deletions(-) diff --git

[PATCH dhcpv6-sf v1 03/10] ipconfig: Return IPv6 privacy status.

--- src/connman.h |1 + src/ipconfig.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index efa38f4..f4059c2 100644 --- a/src/connman.h +++ b/src/connman.h @@ -250,6 +250,7 @@ int __connman_ipconfig_load(struct connman_ipconfig

[PATCH dhcpv6-sf v1 01/10] inet: Return router advertisement packet length in callback.

The length of the RA packet must be returned in callback, otherwise callback cannot check RA options. The prefix length RA option is needed in stateful DHCPv6 implementation. --- src/6to4.c|5 +++-- src/connman.h |2 +- src/inet.c|8 +--- src/network.c |3 ++- 4 files

[PATCH dhcpv6-sf v1 02/10] inet: Get router advertisement prefix option information.

--- src/connman.h |2 ++ src/inet.c| 50 ++ 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 97cd81b..efa38f4 100644 --- a/src/connman.h +++ b/src/connman.h @@ -137,6 +137,8 @@ typedef

[PATCH dhcpv6-sf v1 04/10] dhcpv6: Initial stateful DHCPv6 support.

This patch contains solicitation message support. --- gdhcp/client.c | 419 ++-- gdhcp/common.c | 25 gdhcp/common.h |2 + gdhcp/gdhcp.h | 15 ++ src/connman.h |2 + src/dhcpv6.c | 324

Re: [PATCH 01/10] ipconfig: Use DBG instead of connman_info for debug messages

Hi Arron, I would like to say NAK to this patch and the dnsproxy one also. I think we want to get information about these events and not hide them behind debug switch. Your -q option patch would suit perhaps you better if you want to avoid all printing. Cheers, Jukka On 11/07/2011 08:33

Re: [PATCH] network: Call indicate error function in error case

Hi Daniel, the patch looks good to me so ACK. On 11/15/2011 11:34 AM, Daniel Wagner wrote: From: Daniel Wagnerdaniel.wag...@bmw-carit.de Setting only one ipconfig type e.g. IPv4 is not enough. service.c:combine_state() will stay in associating state: src/service.c:service_indicate_state()

<    1   2   3   4   5   6   7   8   9   10   >