Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Satish Dutt
: Wednesday, May 17, 2017 5:32 AM To: Robert Varga Cc: controller-dev@lists.opendaylight.org; mdsal-...@lists.opendaylight.org Subject: Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ? On Tue, May 16, 2017 at 3:05 PM, Robert Varga

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Anil Vishnoi
On Tue, May 16, 2017 at 3:05 PM, Robert Varga wrote: > On 16/05/17 20:40, Anil Vishnoi wrote: > > Tom, > > > > I think it depends on the use case for which user is using cohort. For > > example If user have a use case where it sends very few rest request to > > the controller from northbound side

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Robert Varga
On 16/05/17 20:40, Anil Vishnoi wrote: > Tom, > > I think it depends on the use case for which user is using cohort. For > example If user have a use case where it sends very few rest request to > the controller from northbound side but want to make sure it runs all > the possible checks against

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Tom Pantelis
yeah I'm not saying it shouldn't be configurable - unfortunately, right now it's hard-coded. On Tue, May 16, 2017 at 2:40 PM, Anil Vishnoi wrote: > Tom, > > I think it depends on the use case for which user is using cohort. For > example If user have a use case where it sends very few rest reque

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Anil Vishnoi
Tom, I think it depends on the use case for which user is using cohort. For example If user have a use case where it sends very few rest request to the controller from northbound side but want to make sure it runs all the possible checks against that data to make sure that it can avoid any wrong c

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Tom Pantelis
yes - it is currently hard-coded to 5 sec. It was not intended for cohorts to take 5-20 sec to validate. Cohorts are supposed to be performant as the API javadocs stress, especially since they're currently invoked synchronously and thus block the Shard. On Mon, May 15, 2017 at 10:20 PM, Anil Vishn

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-16 Thread Satish Dutt
-...@lists.opendaylight.org Subject: Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ? I believe this is where it is set https://github.com/opendaylight/controller/blob/master/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-15 Thread Anil Vishnoi
I believe this is where it is set https://github.com/opendaylight/controller/blob/master/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/ShardDataTree.java#L106 Not sure if there is any way to configure it though any akka/cluster config kn

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-15 Thread Michael Vorburger
On Mon, May 15, 2017 at 5:06 PM, Satish Dutt wrote: > Hi Michael, > > > > Thanks for your response. I am writing a custom cohort class for some > validation purpose, which extends the DOMDataTreeCommitCohort of the > mdsal.dom.api package and overrides the canCommit(). canCommit() in my > cohort

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-15 Thread Satish Dutt
Hi Michael, Thanks for your response. I am writing a custom cohort class for some validation purpose, which extends the DOMDataTreeCommitCohort of the mdsal.dom.api package and overrides the canCommit(). canCommit() in my cohort does some validations and just return a Future object indicating s

Re: [controller-dev] [mdsal-dev] How to increase the timeout value for a commit operation to the data store ?

2017-05-15 Thread Michael Vorburger
Satish, On Mon, May 15, 2017 at 2:26 PM, Satish Dutt wrote: > Hi, > > > > Is there any way to increase the timeout value for a commit operation to > the datastore ? Sometimes I get timeout value during the commit operation > AFAIK, the 5s timeout you're experience below from a commit to the dat