Re: [concurrency-interest] LinkedBlockingDeque deadlock?

2009-07-15 Thread David Holmes - Sun Microsystems
Just to clarify ... Martin Buchholz said the following on 07/16/09 07:24: In summary, there are two different bugs at work here, and neither of them is in LBD. The hotspot team is working on the LBD deadlock. Not the "hotspot team", just me :) - I am looking into this in my role as j.u.c eval

hg: jdk7/tl/jdk: 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble

2009-07-15 Thread joe . darcy
Changeset: 2a1b1075f583 Author:darcy Date: 2009-07-15 14:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a1b1075f583 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble Reviewed-by: lancea, iris ! src/share/classes/java/lang/Double.java

Re: Code review request for 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble

2009-07-15 Thread Joseph D. Darcy
Hello. In response to a suggestion from Iris, I'll change the patch to use the phrase "the string" for both exceptions @throws descriptions. Thanks for the quick reviews, -Joe Lance J. Andersen wrote: Looks good Joe -Lance Joseph D. Darcy wrote: Hello. Please review this simple patch be

Re: [concurrency-interest] LinkedBlockingDeque deadlock?

2009-07-15 Thread Martin Buchholz
In summary, there are two different bugs at work here, and neither of them is in LBD. The hotspot team is working on the LBD deadlock. (As always) It would be good to have a good test case for the dead socket problem. Martin On Wed, Jul 15, 2009 at 12:24, Ariel Weisberg wrote: > Hi, > > I have

Re: [concurrency-interest] LinkedBlockingDeque deadlock?

2009-07-15 Thread Ariel Weisberg
Hi, I have found that there are two different failure modes without involving -XX:+UseMembar. There is the LBD deadlock and then there is the dead socket in between two nodes. Either failure can occur with the same code and settings. It appears that the dead socket problem is more common. The LBD

Re: Code review request for 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble

2009-07-15 Thread Lance J. Andersen
Looks good Joe -Lance Joseph D. Darcy wrote: Hello. Please review this simple patch below to document the long-standing behavior of parseFloat and parseDouble regarding null inputs. (Yes, the various string -> value methods have inconsistent behavior with respect to null inputs; however, a

Code review request for 6463998: Undocumented NullPointerExeption from Float.parseFloat and Double.parseDouble

2009-07-15 Thread Joseph D. Darcy
Hello. Please review this simple patch below to document the long-standing behavior of parseFloat and parseDouble regarding null inputs. (Yes, the various string -> value methods have inconsistent behavior with respect to null inputs; however, at this point the safest course of action is jus

hg: jdk7/tl/jdk: 6857789: (reflect) Create common superclass of reflective exceptions

2009-07-15 Thread joe . darcy
Changeset: aaf0cb20646e Author:darcy Date: 2009-07-15 12:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aaf0cb20646e 6857789: (reflect) Create common superclass of reflective exceptions Reviewed-by: martin ! src/share/classes/java/lang/ClassNotFoundException.java ! src/sh

Re: Reg : How to contribute

2009-07-15 Thread Lance J. Andersen
Ulf Zibis wrote: Am 15.07.2009 19:36, Lance J. Andersen schrieb: Ulf Zibis wrote: But does this script help me, to have an account on webrev server ? There is no webrev server, I just referred to http://cr.openjdk.java.net/ : General _This server_ provides storage and display of

hg: jdk7/tl/langtools: 6860795: NullPointerException when compiling a negative java source

2009-07-15 Thread maurizio . cimadamore
Changeset: 90d40dd5cfc7 Author:mcimadamore Date: 2009-07-15 17:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/90d40dd5cfc7 6860795: NullPointerException when compiling a negative java source Summary: Rich formatter shouldn't propagate visits on method symbols that ha

Re: Reg : How to contribute

2009-07-15 Thread Ulf Zibis
Am 15.07.2009 19:36, Lance J. Andersen schrieb: Ulf Zibis wrote: But does this script help me, to have an account on webrev server ? There is no webrev server, I just referred to http://cr.openjdk.java.net/ : General _This server_ provides storage and display of code review materials

Re: Reg : How to contribute

2009-07-15 Thread Frances Ho
Jessie (Jean-Christophe) has been working on a Java version of webrev. Jessie - can you share a bit of what it'll cover? -Frances On 07/15/09 07:55, Dalibor Topic wrote: Ulf Zibis wrote: but what to do with this script to make it work for me? I'm not sure I understand the question correc

Re: Reg : How to contribute

2009-07-15 Thread Lance J. Andersen
Ulf Zibis wrote: Am 15.07.2009 16:55, Dalibor Topic schrieb: Ulf Zibis wrote: but what to do with this script to make it work for me? I'm not sure I understand the question correctly - webrev is a shell script that uses ksh, so you could mark it as executable and run it using ksh,

Re: Reg : How to contribute

2009-07-15 Thread Andrew John Hughes
2009/7/15 Ulf Zibis : > Am 15.07.2009 16:55, Dalibor Topic schrieb: >> >> Ulf Zibis wrote: >> >>> >>> but what to do with this script to make it work for me? >>> >> >> I'm not sure I understand the question correctly - webrev is a shell >> script >> that uses ksh, so you could mark it as executable

Re: Reg : How to contribute

2009-07-15 Thread Ulf Zibis
Am 15.07.2009 16:55, Dalibor Topic schrieb: Ulf Zibis wrote: but what to do with this script to make it work for me? I'm not sure I understand the question correctly - webrev is a shell script that uses ksh, so you could mark it as executable and run it using ksh, for example. Da

Re: Reg : How to contribute

2009-07-15 Thread Andrew John Hughes
2009/7/15 Neal Gafter : > 2009/7/15 Dalibor Topic >> >> Neal, >> >> Are you interested in improving the developer guide? > > Unfortunately, I have no special access to what Sun is putting in place, so > I'm not the right person to be documenting things.  I still haven't figured > out, for example,

Re: Reg : How to contribute

2009-07-15 Thread Neal Gafter
2009/7/15 Dalibor Topic > Neal, > > Are you interested in improving the developer guide? > Unfortunately, I have no special access to what Sun is putting in place, so I'm not the right person to be documenting things. I still haven't figured out, for example, what process external contributors

Re: Reg : How to contribute

2009-07-15 Thread Dalibor Topic
Ulf Zibis wrote: > but what to do with this script to make it work for me? I'm not sure I understand the question correctly - webrev is a shell script that uses ksh, so you could mark it as executable and run it using ksh, for example. cheers, dalibor topic -- ***

Re: Reg : How to contribute

2009-07-15 Thread Ulf Zibis
Am 15.07.2009 16:45, Dalibor Topic schrieb: Ulf Zibis wrote: I think, it would be good idea to make the webrev tool available for external contributors too. It's the perfect tool for discussion on changesets. Hi Ulf, The webrev tool is available at http://blogs.sun.com/jcc/resource/we

Re: Fwd: Reg : How to contribute

2009-07-15 Thread Ulf Zibis
Andrew, thanks for the info. :-) Can you give a hint how to register on webrev server, and how to make it work? -Ulf Am 15.07.2009 16:41, Andrew John Hughes schrieb: 2009/7/15 Ulf Zibis : I think, it would be good idea to make the webrev tool available for external contributors too. I

Re: Fwd: Reg : How to contribute

2009-07-15 Thread Lance J. Andersen
I do agree with Ulf I think it would be useful to have webrev available from the openjdk project home page or a least a pointer to where to obtain a copy. While you are correct you can find copies via google search, having the tools that are useful accessible from the openjdk site would be

Re: Reg : How to contribute

2009-07-15 Thread Dalibor Topic
Ulf Zibis wrote: > I think, it would be good idea to make the webrev tool available for > external contributors too. It's the perfect tool for discussion on > changesets. Hi Ulf, The webrev tool is available at http://blogs.sun.com/jcc/resource/webrev cheers, dalibor topic -- *

Fwd: Reg : How to contribute

2009-07-15 Thread Andrew John Hughes
2009/7/15 Ulf Zibis : > Am 15.07.2009 16:26, Neal Gafter schrieb: >> >> On Wed, Jul 15, 2009 at 4:01 AM, Dalibor Topic > > wrote: >> >>    A good start is the OpenJDK developer guide - see >>    http://openjdk.java.net/guide/ to learn how the project works. >> >> >> Th

Re: Reg : How to contribute

2009-07-15 Thread Dalibor Topic
Neal, Are you interested in improving the developer guide? cheers, dalibor topic -- *** Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobil

Re: Reg : How to contribute

2009-07-15 Thread Ulf Zibis
Am 15.07.2009 16:26, Neal Gafter schrieb: On Wed, Jul 15, 2009 at 4:01 AM, Dalibor Topic > wrote: A good start is the OpenJDK developer guide - see http://openjdk.java.net/guide/ to learn how the project works. That set of pages is mostly filled with promi

Re: Reg : How to contribute

2009-07-15 Thread Neal Gafter
On Wed, Jul 15, 2009 at 4:01 AM, Dalibor Topic wrote: > A good start is the OpenJDK developer guide - see > http://openjdk.java.net/guide/ to learn how the project works. That set of pages is mostly filled with promises of the form "This section will contain...". For example

Re: Math trig intrinsics and compiler options

2009-07-15 Thread Christian Thalinger
gustav trede wrote: > Hello, You should better ask these questions on hotspot-dev. -- Christian

Math trig intrinsics and compiler options

2009-07-15 Thread gustav trede
Hello, Azeem Jiva told me an easy way to improve trig performance. Changing the intrinsics to use an existing but faster path gives me a boost of roughly 40% for the Math cos and sin on solaris x64. library_call.cpp bool LibraryCallKit::inline_math_native(vmIntrinsics::ID id) { switch (id) {

Re: Reg : How to contribute

2009-07-15 Thread Dalibor Topic
Ganesan Pugalendhi wrote: > Hi > > I have more then 6+ years of working experience in java (Java ME (3 > Years) and Java SE and EE (3 + yrs)), I have implemented RTP/RTCP stack > in j2me, designed and implemented Canvas based UI frame work for J2ME > clients and Architected many Java EE projects

hg: jdk7/tl/langtools: 6846972: cannot access member of raw type when erasure change overriding into overloading

2009-07-15 Thread maurizio . cimadamore
Changeset: ad07b7ea9685 Author:mcimadamore Date: 2009-07-15 10:25 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ad07b7ea9685 6846972: cannot access member of raw type when erasure change overriding into overloading Summary: fix of 6400189 caused a nasty problem in met

Re: Reg : How to contribute

2009-07-15 Thread Ulf Zibis
See: https://jdk-collaboration.dev.java.net/ http://openjdk.java.net/ http://openjdk.java.net/contribute/ -Ulf Am 15.07.2009 10:23, Ganesan Pugalendhi schrieb: Hi I have more then 6+ years of working experience in java (Java ME (3 Years) and Java SE and EE (3 + yrs)), I have implemented RTP

Reg : How to contribute

2009-07-15 Thread Ganesan Pugalendhi
Hi I have more then 6+ years of working experience in java (Java ME (3 Years) and Java SE and EE (3 + yrs)), I have implemented RTP/RTCP stack in j2me, designed and implemented Canvas based UI frame work for J2ME clients and Architected many Java EE projects. I like to contribute to JDK7 but i