updated review request for 7021582, use try-with-resources in jar/zip implementation and tests

Hi all, updated webrev is here: http://cr.openjdk.java.net/~smarks/reviews/7021582/webrev.1/ I've removed the pack200 files (i.e. those in src/share/classes/com/sun/java/util/jar/pack) so I can do more thorough deploy/install testing per Kumar's request. The change to PropMap.java, which gene

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

On 2/24/11 5:17 PM, Kumar Srinivasan wrote: All the changes look good, the regression test jdk/test/tools/pack200 and jdk/test/tools/jar must be run, as jprt does not run these by default, also suggest a full control build using jdk, deploy and install. Thanks for looking at the changes. What I

Re: Code Review for 7001933: Deadlock in java.lang.classloader.getPackage()

HI Valerie, Valerie (Yu-Ching) Peng said the following on 02/25/11 11:36: Can someone please review for 7001933: Deadlock in java.lang.classloader.getPackage()? http://cr.openjdk.java.net/~valeriep/7001933/webrev.00/ The fixes are straightforward - release the lock when delegating to the par

Code Review for 7001933: Deadlock in java.lang.classloader.getPackage()

Hi, Can someone please review for 7001933: Deadlock in java.lang.classloader.getPackage()? http://cr.openjdk.java.net/~valeriep/7001933/webrev.00/ The fixes are straightforward - release the lock when delegating to the parent. The change has been verified by the submitter. Thanks, Valerie

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

All the changes look good, the regression test jdk/test/tools/pack200 and jdk/test/tools/jar must be run, as jprt does not run these by default, also suggest a full control build using jdk, deploy and install. All looks okay to me except for src/share/classes/com/sun/java/util/jar/pack/PropMap.

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

[this is a resend of an earlier message, which apparently didn't go through] On 2/24/11 2:20 AM, Alan Bateman wrote: Stuart Marks wrote: Hi Sherman, all, Here's a webrev to convert code in the jar/zip implementation files and tests to use the new Java 7 try-with-resources construct. http://cr

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

On 2/24/11 2:20 AM, Alan Bateman wrote: All looks okay to me except for src/share/classes/com/sun/java/util/jar/pack/PropMap.java. At L129 it uses getResourceAsStream and that will return null if the properties file doesn't exist causing props.load to throw NPE. I realize the original code will

AUTO: I'm off on 25th Feb 2011 (returning 28/02/2011)

I am out of the office until 28/02/2011. Please contact Anshu Verma (ansve...@in.ibm.com) for any CL issues. Note: This is an automated response to your message "core-libs-dev Digest, Vol 46, Issue 39" sent on 25/2/11 0:00:46. This is the only notification you will receive while this person i

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

On 2/24/11 12:36 AM, Xueming Shen wrote: Stuart, Here are my comments on non-pack changes. I'm sure Kumar will look at those pack files later. GetMethodsReturnClones.java: ln#43 diamond conersion? Oh yes, I could do that. How could I have forgotten about diamond? :-) Available.java: it's no

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

On 2/23/11 11:11 PM, David Holmes wrote: Hi Stuart, Just taking a look as a curious observer ... Good comments, thanks. I'm somewhat dismayed by the lack of exception handling in the original code. Yes. As Josh observed in his initial "Automatic Resource Management" proposal [*] (precurso

Re: Review request for 7016707 "Remove the BootClassLoaderHook for jkernel support"

Mandy Chung wrote: 7016707: Remove the BootClassLoaderHook for jkernel support Webrev at: http://cr.openjdk.java.net/~mchung/7016707/webrev.00/ These changes looks fine to me. -Alan.

Re: Review request for 7016707 "Remove the BootClassLoaderHook for jkernel support"

Makefile change is fine. Sorry I wasn't able to look at the code changes. -kto On Feb 24, 2011, at 10:30 AM, Mandy Chung wrote: 7016707: Remove the BootClassLoaderHook for jkernel support Webrev at: http://cr.openjdk.java.net/~mchung/7016707/webrev.00/ The sun.jkernel.* classes have been

hg: jdk7/tl/jdk: 6835668: Use of /usr/include/linux/ files creates a dependence on kernel-headers

Changeset: 51ef29aafc1b Author:michaelm Date: 2011-02-24 18:35 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/51ef29aafc1b 6835668: Use of /usr/include/linux/ files creates a dependence on kernel-headers Reviewed-by: chegar ! src/solaris/native/java/net/NetworkInterface.c !

Review request for 7016707 "Remove the BootClassLoaderHook for jkernel support"

7016707: Remove the BootClassLoaderHook for jkernel support Webrev at: http://cr.openjdk.java.net/~mchung/7016707/webrev.00/ The sun.jkernel.* classes have been removed from JDK 7: http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/e4802c87e5c7 This fix is to remove sun.misc.BootClassLoaderHoo

hg: jdk7/tl/langtools: 7018753: tools/javac/varargs/warning/Warn5.java times out on slow machines

Changeset: 3e30c95da3c6 Author:jjh Date: 2011-02-24 08:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3e30c95da3c6 7018753: tools/javac/varargs/warning/Warn5.java times out on slow machines Summary: Use a single file manager for all JavacTasks Reviewed-by: jjg, mcima

Re: Review CR #6611830: UUID thread-safety and performance improvements

This change seems good all around. In addition to fixing the noted race, it removes a substantial amount of redundant instance footprint from a class whose instances are not infrequently collected in significant numbers-- fields most of which just served methods that are essentially never used in

Re: FW: [concurrency-interest] ForkJoin Improvements

David Holmes and others keep pushing the Fork-Join framework for inclusion in JDK7 while this framework is an utter calamity. http://www.coopsoft.com/ar/CalamityArticle.html The latest framework update makes it even more complex without addressing the fatal flaws (archaic work-stealing algorithms,

hg: jdk7/tl/jdk: 6849693: index of fdTable should be less than num. of fdTable in jdk7

Changeset: 1f41e41ef2db Author:chegar Date: 2011-02-24 13:42 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f41e41ef2db 6849693: index of fdTable should be less than num. of fdTable in jdk7 Reviewed-by: alanb ! src/solaris/native/java/net/linux_close.c

hg: jdk7/tl/jdk: 7020136: java/net/URLConnection/RedirectLimit.java fails intermittently

Changeset: c2c8f9c38fd1 Author:chegar Date: 2011-02-24 12:57 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2c8f9c38fd1 7020136: java/net/URLConnection/RedirectLimit.java fails intermittently Summary: Increase the socket timeout and clean up the test Reviewed-by: alanb ! te

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

Stuart Marks wrote: Hi Sherman, all, Here's a webrev to convert code in the jar/zip implementation files and tests to use the new Java 7 try-with-resources construct. http://cr.openjdk.java.net/~smarks/reviews/7021582/webrev.0/ I looked through the src/** changes (I don't have time to go thro

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

Hi Sherman, Xueming Shen said the following on 02/24/11 18:36: InfoZip.java.: ln#113/114 you probably don't need to separate out the "fis" in try-with-resources, the FileInputStream created should be closed by the ZipInputStream that it is embedded in. The reason to do this is in case the Zip

Re: review request for 7021582, use try-with-resources in jar/zip implementation and tests

Stuart, Here are my comments on non-pack changes. I'm sure Kumar will look at those pack files later. GetMethodsReturnClones.java: ln#43 diamond conersion? Available.java: it's not your change, but I believe we should do the try-with_resources on the ZipFile zfile as well. InfoZip.java.: