Some of these are actually supported by NetBeans, such as:
LeakingThisInConstructor
Regards,
Michael
On Sat, Nov 17, 2012 at 12:39 AM, Stuart Marks wrote:
> On 11/15/12 3:06 AM, Alan Bateman wrote:
>>
>> On 14/11/2012 22:44, Chris Hegarty wrote:
>>>
>>> - @SuppressWarnings("unused") Eclipse??
On 11/16/12 6:39 PM, Stuart Marks wrote:
The background is that the words that can be supplied to @SuppressWarnings
reside in an uncontrolled namespace. The JLS [1] defines only "unchecked" and
any others are compiler-specific. The set of words accepted here by javac is
the same as the words defi
On 11/15/12 3:06 AM, Alan Bateman wrote:
On 14/11/2012 22:44, Chris Hegarty wrote:
- @SuppressWarnings("unused") Eclipse???
Do we have precedent for adding these suppressions??
I don't see it in the -Xlint options that javac supports so it might be
specific to ECJ. I recall this topic cam
Changeset: 6f20caa6e1e9
Author:bchristi
Date: 2012-11-16 17:01 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f20caa6e1e9
7178922: (props) re-visit how os.name is determined on Mac
Reviewed-by: alanb, mchung, skovatch, serb
! src/solaris/native/java/lang/java_props_macosx.c
Looks good to me. I can push it for you. Who are the reviewers
besides me (it wasn't clear to me from the thread)?
Mandy
On 11/16/12 9:32 AM, Brent Christian wrote:
Any more comments on this?
-Brent
On 11/14/12 1:23 PM, Brent Christian wrote:
Thanks, Sergey.
It's good that we standardiz
Changeset: 0ee09f17361e
Author:khazra
Date: 2012-11-16 12:28 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ee09f17361e
8003518: (prefs) Tests in jdk/test/java/util/prefs should not be run
concurrently
Summary: Add java/util/prefs to exclusiveAccess.dirs in TEST.ROOT
Review
On 11/16/12 9:38 AM, David DeHaven wrote:
I cleaned it up quite a bit, I think it looks a lot better now:
http://cr.openjdk.java.net/~ddehaven/8001533/webrev.1/
The comments still need some attention, I'll get that first thing on the morrow.
-DrD-
I haven't done a detailed code review but I'm
Changeset: 843d3b191773
Author:jjh
Date: 2012-11-16 18:27 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/843d3b191773
8003357: Add support for jtreg -concurrency to langtools/test/Makefile
Reviewed-by: jjg
! test/Makefile
>> I cleaned it up quite a bit, I think it looks a lot better now:
>> http://cr.openjdk.java.net/~ddehaven/8001533/webrev.1/
>>
>> The comments still need some attention, I'll get that first thing on the
>> morrow.
>>
>> -DrD-
>>
> I haven't done a detailed code review but I'm wondering about
Any more comments on this?
-Brent
On 11/14/12 1:23 PM, Brent Christian wrote:
Thanks, Sergey.
It's good that we standardized on the recommended usage within the JDK
in order to stay ahead of a possible change to the value of ProductName
in /System/Library/CoreServices/SystemVersion.plist
But
Mandy,
Thanks Mandy!, that tip cleaned up the code quite a bit, it is generally
looking
a lot better.
David,
One minor fix the while loop can be converted to a for loop making it
slightly more compact, But I am fine either way.
-Class sc = mainClass.getSuperclass();
-wh
Looks fine to me.
Xuelei
On 11/16/2012 10:54 PM, Sean Mullan wrote:
> This change affects components in the security and core libs areas.
>
> This is a minor specification clarification to avoid the use of the terms
> "valid" and "invalid" when describing the syntax for wildcard names in
> java.
This change affects components in the security and core libs areas.
This is a minor specification clarification to avoid the use of the terms
"valid" and "invalid" when describing the syntax for wildcard names in
java.security.BasicPermission and various subclasses. This could be implied that
thes
On 16/11/2012 04:49, David DeHaven wrote:
:
I cleaned it up quite a bit, I think it looks a lot better now:
http://cr.openjdk.java.net/~ddehaven/8001533/webrev.1/
The comments still need some attention, I'll get that first thing on the morrow.
-DrD-
I haven't done a detailed code review but I'
14 matches
Mail list logo
