AnnotationParser optimization - JEP-149

2012-11-26 Thread Peter Levart
Hi all, This might not be much of an improvement, but it is very easy to do: --- a/src/share/classes/sun/reflect/annotation/AnnotationParser.java Thu Nov 15 15:40:03 2012 -0800 +++ b/src/share/classes/sun/reflect/annotation/AnnotationParser.java Tue Nov 27 08:39:58 2012 +0100 @@ -227,7 +227,7

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

2012-11-26 Thread Martin Buchholz
Rob, Thanks for taking on this big scary change. Our experience having run with the vfork based implementation on Linux has been very positive. This addresses a real need that is shared by all big processes that desire offspring. You might want to look through my comments from the last round of

Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

2012-11-26 Thread Mike Duigou
Hello all; In the original patch which added the basic lambda functional interfaces, CR#8001634 [1], none of the interfaces extended other interfaces. The reason was primarily that the javac compiler did not, at the time that 8001634 was proposed, support extension methods. The compiler now sup

hg: jdk8/tl/jdk: 8001634: Initial set of functional interface types

2012-11-26 Thread mike . duigou
Changeset: c2e80176a697 Author:mduigou Date: 2012-11-26 15:08 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2e80176a697 8001634: Initial set of functional interface types Summary: Add the core functional interfaces used by the JSR335 libraries. Reviewed-by: dholmes, briango

Re: Adding field to BatchUpdateException

2012-11-26 Thread Lance Andersen - Oracle
Hi Ulf, Thank you for the suggestion The current spec is silent on what happens if the update count overflows for any executeUpdate method. Today the driver vendors just pass in their array of UpdateCounts (or status) to BatchException (or overflow the return count from executeUpdate) if an

Re: Adding field to BatchUpdateException

2012-11-26 Thread Ulf Zibis
Hi Lance, I would throw an IllegalStateException if invoking e.g. getUpdateCounts on integer overflow. -Ulf Am 26.11.2012 20:44, schrieb Lance Andersen - Oracle: Hi Joe, Thank you for the sanity check. I had added the following to the top of the javadoc (still playing with the wording):

Re: Adding field to BatchUpdateException

2012-11-26 Thread Lance Andersen - Oracle
Hi Joe, Thank you for the sanity check. I had added the following to the top of the javadoc (still playing with the wording): As of Java SE 8, the method getLargeUpdateCount has been added to provide support for update counts that may be exceed Integer.MAX_VALUE and returned by the method Sta

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-26 Thread Mandy Chung
On 11/26/12 1:40 AM, Staffan Larsen wrote: A webrev for the changes going into 7u12 is here: http://cr.openjdk.java.net/~sla/8003322/webrev.jdk7.00/ The changes look fine for 7u12.Thanks for looking into the dynamic bytecode inst

Re: 8003949: LogManager, downgrade normative reference to ${java.home}/lib/logging.properties

2012-11-26 Thread Mandy Chung
On 11/25/12 2:07 PM, Alan Bateman wrote: ... The focus of this mail is java.util.logging.LogManager as it specifies that the default configuration is loaded from ${java.home}/lib/logging.properties. Clearly this file is changed in some environments, although running with java.util.logging.co

Re: 8003949: LogManager, downgrade normative reference to ${java.home}/lib/logging.properties

2012-11-26 Thread Alan Bateman
On 26/11/2012 15:18, Paul Sandoz wrote: Hi Alan, + * If neither of these properties is defined then the LogManager uses its + * default configuration. The default configuration is typically loaded from the + * properties file "{@code lib/logging.properties}" in the Java installation + * directo

Re: 8003949: LogManager, downgrade normative reference to ${java.home}/lib/logging.properties

2012-11-26 Thread Paul Sandoz
Hi Alan, + * If neither of these properties is defined then the LogManager uses its + * default configuration. The default configuration is typically loaded from the + * properties file "{@code lib/logging.properties}" in the Java installation + * directory. Will typical become atypical for Ope

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-26 Thread Alan Bateman
On 26/11/2012 09:40, Staffan Larsen wrote: A webrev for the changes going into 7u12 is here: http://cr.openjdk.java.net/~sla/8003322/webrev.jdk7.00/ I think the changes are fine for 7u12 and we look forward to a less invasive solutio

hg: jdk8/tl/jdk: 7162111: TEST_BUG: change tests run in headless mode [macosx] (open)

2012-11-26 Thread alexey . utkin
Changeset: 8970128e040d Author:uta Date: 2012-11-26 15:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8970128e040d 7162111: TEST_BUG: change tests run in headless mode [macosx] (open) Summary: In problem tests detection of AWT headless mode was introduced or AWT dependenc

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-26 Thread Alan Bateman
On 26/11/2012 10:38, Alexey Utkin wrote: I need the second reviewer. -uta One reviewer is fine. -Alan

Re: Review request: JDK-7162111 TEST_BUG: change tests run in headless mode [macosx] (open part - ver. 3)

2012-11-26 Thread Alexey Utkin
I need the second reviewer. -uta On 23.11.2012 15:57, Alan Bateman wrote: On 23/11/2012 11:40, Alexey Utkin wrote: I mean: # jdk_io -# 7162111 - these tests need to be updated to run headless -java/io/Serializable/resolveClass/deserializeButton/run.sh macosx-all -java/io/Serializable/se

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

2012-11-26 Thread Staffan Larsen
A webrev for the changes going into 7u12 is here: http://cr.openjdk.java.net/~sla/8003322/webrev.jdk7.00/ Thanks, /Staffan On 20 nov 2012, at 18:30, Mandy Chung wrote: > On 11/20/12 6:20 AM, Alan Bateman wrote: >> On 20/11/2012 14:10, Staffan Larsen wrote: >>> : >>> The original plan was for t