Changeset: 1e8d98012ab8
Author:joehw
Date: 2013-05-08 23:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1e8d98012ab8
8011653: Upgrade JDK8 to JAXP 1.5
Reviewed-by: alanb, dfuchs
! src/com/sun/org/apache/xalan/internal/XalanConstants.java
! src/com/sun/org/apache/xalan/in
Hi Thomas,
On 9/05/2013 1:28 AM, Thomas Schatzl wrote:
Hi,
please review the latest webrev for this patch that is available at
http://cr.openjdk.java.net/~tschatzl/7038914/webrev.2/
As mentioned, it incorporates the fix and reproducer from Peter Levart.
Fix is fine.
I'm not sure about t
Still looks good. :-)
On May 8 2013, at 22:27 , Henry Jen wrote:
> On 05/08/2013 09:17 PM, Mike Duigou wrote:
>> Looks good to me.
>>
>
> Thanks, we have a minor update to exclude changes for DirectoryStream.
>
> http://cr.openjdk.java.net/~henryjen/ccc/8006884.2/webrev/
>
> A quick review on
On 05/08/2013 09:17 PM, Mike Duigou wrote:
> Looks good to me.
>
Thanks, we have a minor update to exclude changes for DirectoryStream.
http://cr.openjdk.java.net/~henryjen/ccc/8006884.2/webrev/
A quick review on the update is really appreciated.
Cheers,
Henry
> FaultyFileSystem is I hope so
Looks good to me.
FaultyFileSystem is I hope something we can reuse in other tests.
Mike
On May 6 2013, at 09:56 , Henry Jen wrote:
> Hi,
>
> Updated based on feedback,
>
> http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/webrev/
> http://cr.openjdk.java.net/~henryjen/ccc/8006884.1/specdiff
Hi Remi,
In this context, the modifiers in question are only source-level modifiers.
Thanks,
-Joe
On 05/08/2013 03:52 PM, Remi Forax wrote:
Hi Joe,
does the spec has changed recently, or you should also add SYNTHETIZED
to parameter modifiers ?
Rémi
On 05/08/2013 10:20 PM, Joe Darcy wrote:
On 05/08/2013 03:26 PM, Mandy Chung wrote:
The change looks good to me. I also think it's a good idea to swap
out the comment for @jls tag for consistency.
Okay; you both convinced me :-)
Revised patch below, including a new comment explaining the
FOO_MODIFIERS fields and fooModifiers() meth
Good. They look fine.
-Max
On 5/9/13 10:31 AM, Xuelei Fan wrote:
Oops, here is the webrev:
http://cr.openjdk.java.net/~xuelei/8005598/webrev.00/
Xuelei
On 5/9/2013 10:30 AM, Xuelei Fan wrote:
Hi,
It's a correction of previous fix of JDK-8003265:
http://hg.openjdk.java.net/jdk8/tl/jdk/r
Oops, here is the webrev:
http://cr.openjdk.java.net/~xuelei/8005598/webrev.00/
Xuelei
On 5/9/2013 10:30 AM, Xuelei Fan wrote:
> Hi,
>
> It's a correction of previous fix of JDK-8003265:
>
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc
>
> Which introduced compiler warning and er
Hi,
It's a correction of previous fix of JDK-8003265:
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4472a641b4dc
Which introduced compiler warning and error, and backouted later.
Thanks,
Xuelei
On Wed, May 8, 2013 at 5:30 PM, Mike Duigou wrote:
>
> Direct-X-Buffer.java::
>
> - +#if[rw] public boolean isDirect() : Why would this be conditionalized
> with rw?
>
>
Welcome to the -X- files. Since you have conditional preprocessing and
inheritance happening at the same time, all readonly me
Looks fine Mandy
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
On May 8, 2013, at 8:13 PM, Mandy Chung wrote:
> Please review the simple change f
Hi Martin;
Some notes from a non-exhaustive (ran out of time before dinner) review.
Mike
AbstractStringBuilder::
- The impls like insert(int dstOffset, CharSequence s) makes me slightly uneasy
because the private value field escapes to an unknown class. Who knows what
evil (or foolishness) co
Please review the simple change for:
JDK-4487672 (proxy) Proxy constructor should check for null argument
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/4487672/webrev.00/
Thanks
Mandy
Hi Joe,
does the spec has changed recently, or you should also add SYNTHETIZED
to parameter modifiers ?
Rémi
On 05/08/2013 10:20 PM, Joe Darcy wrote:
Hello,
Please review my changes to address
JDK-8014249 Add Modifer.parameterModifiers()
Diff below.
The motivation is that since we now
The change looks good to me. I also think it's a good idea to swap out
the comment for @jls tag for consistency.
Mandy
On 5/8/2013 2:13 PM, Joe Darcy wrote:
Hi Mike,
The public methods use the @jls tags while the private fields use the
comments. (What probably happened was that the old "JLS
Hi,
Please help review the proposed change to update the tz data
in JDK8 from 2012i to 2013c.
Other than the tzdb data file update under make/sun/javazic/tzdata,
corresponding updates have also been made in TimeZoneNames***.java
for the newly added zones, Asia/Khandyga and Ust-Nera, and updated
Alan (et al): Ping.
On Wed, May 1, 2013 at 3:19 PM, Martin Buchholz wrote:
> Another version of this change is ready. No longer preliminary. Tests
> have been written.
> http://cr.openjdk.java.net/~martin/webrevs/openjdk8/getChars/
>
> This kind of change is particularly subject to feature cr
On 8 May 2013, at 21:56, Mike Duigou wrote:
>
> On May 7 2013, at 10:13 , Chris Hegarty wrote:
>
>> On 05/07/2013 05:04 PM, Mike Duigou wrote:
>>> The "currently" MIN_ARRAY_SORT_GRAN statement bothers me. Can we remove
>>> currently?
>>
>> No problem. That would read...
>>
>> "When the sub
Hi Mike,
The public methods use the @jls tags while the private fields use the
comments. (What probably happened was that the old "JLSv3" comments were
missed in the comments -> tags pass.)
I could swap out the comments for tags if you think that would be useful.
Thanks,
-Joe
On 05/08/2013
On May 7 2013, at 10:13 , Chris Hegarty wrote:
> On 05/07/2013 05:04 PM, Mike Duigou wrote:
>> The "currently" MIN_ARRAY_SORT_GRAN statement bothers me. Can we remove
>> currently?
>
> No problem. That would read...
>
> "When the sub-array length reaches a {@linlplain #MIN_ARRAY_SORT_GRAN
>
The substance of the change looks good to me.
Why are "JLS section 8.1.1" comments used in some places and @jls tags (which I
prefer since they are links) in other places?
Mike
On May 8 2013, at 13:20 , Joe Darcy wrote:
> Hello,
>
> Please review my changes to address
>
>JDK-8014249 Add
Hello,
Please review my changes to address
JDK-8014249 Add Modifer.parameterModifiers()
Diff below.
The motivation is that since we now have a reflective model of
parameters (JDK-8004729), the java.lang.reflect.Modifier class should
provide a parameterModifiers method similar to other "f
Hi Sherman,
I reviewed webrev and also checked out webrev.newECP. While it's good
to simplify the synchronization needed in ExtendedCharsets, maybe better
to separpate the ExtendedCharsets change from the fix for 8012326 that
would require a more detailed review (I can do that next).
Chars
On 05/08/2013 11:58 AM, Alan Bateman wrote:
On 04/05/2013 20:05, Xueming Shen wrote:
:
Another sync need is for the "init()", in which it may update the aliasMap,
classMap and aliasNameMap via charset() and deleteCharset() if those
special properties are defined. There are two sources for the c
On 04/05/2013 20:05, Xueming Shen wrote:
:
Another sync need is for the "init()", in which it may update the
aliasMap,
classMap and aliasNameMap via charset() and deleteCharset() if those
special properties are defined. There are two sources for the charset()/
deleteCharset(), one is from the
Alexey,
Thanks for working on the scary windows process stuff.
I only have time for superficial review.
It looks like you know what you're doing.
+String[] cmdArray = {
+"java",
+"-cp",
This looks like it's invoking whatever "java" is on the path. But there's
no g
Hi,
This is from our backlog after JDK-8005926. After ThreadLocalRandom
state was merged into Thread, we now have to deal with the false sharing
induced by heavily-updated fields in Thread. TLR was padded before, and
it should make sense to make Thread bear @Contended annotation to
isolate its fie
Bug description:
https://jbs.oracle.com/bugs/browse/JDK-7147084
http://bugs.sun.com/view_bug.do?bug_id=7147084
Here is the suggested fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.00/
Summary:
I would like to describe the bug synopsis, common Java approach to
Windows ha
Hi Lance,
Thanks for the info.
Hope you had a good break, and the transition back hasn't been too
extreme :)
Regards,
Neil
On Wed, 2013-05-08 at 12:33 -0400, Lance Andersen - Oracle wrote:
> Hi Neil,
>
> Just back from holiday and catching up (or trying to)
>
>
> On May 2, 2013, at 7:13 AM,
Changeset: c8f47674d105
Author:alanb
Date: 2013-05-08 18:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8f47674d105
8013652: (profiles) Add javax.script to compact1
Reviewed-by: mchung, dholmes
! makefiles/profile-rtjar-includes.txt
Hi Neil,
Just back from holiday and catching up (or trying to)
On May 2, 2013, at 7:13 AM, Neil Richards wrote:
>
> Hi Lance,
> I've been trying to identify the Java bug ids for the RFEs which
> implement JEP 170 (which, from what I can tell, should be in OpenJDK 8
> since milestone 6 [1]).
Hi,
please review the latest webrev for this patch that is available at
http://cr.openjdk.java.net/~tschatzl/7038914/webrev.2/
As mentioned, it incorporates the fix and reproducer from Peter Levart.
Bugs.sun.com:
http://bugs.sun.com/view_bug.do?bug_id=7038914
JIRA:
https://jbs.oracle.com/bug
Changeset: 780014a234fa
Author:jfranck
Date: 2013-05-08 14:10 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/780014a234fa
8013485: javac can't handle annotations with a from a previous
compilation unit
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/
On 05/08/13 04:57, Chris Hegarty wrote:
Doug,
David raises a good question here. Is this implementation detail still correct:
"The algorithm requires a working space equal to the size of the
original array."
All sort methods require working space of at most the size of the array
segment (wh
Doug,
David raises a good question here. Is this implementation detail still
correct:
"The algorithm requires a working space equal to the size of the
original array."
I did get clarifications on a number of the minor spec/implementation
details, but I don't think we discuss this one.
(I
36 matches
Mail list logo
