Hello, Kumar.
Thank you for the review.
> Is there a regression test for this somewhere ?
It's quite hard to create a regression test for this issue, as we would need
SWT for such test and we do not have any tests which use SWT currently.
I have tried to make a test without SWT using some appl
Looks good.
You could optimize it a bit by not doing the Arrays.asList() on every
methodExit event.
/Staffan
On 17 apr 2013, at 15:03, Mikael Auno wrote:
> Hi, I'd like some reviews on
> http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681
> (http://bugs.sun.com/view_bug.d
I'm not familiar with these particular APIs but in general making
defensive copies of mutable objects is good practice. In this case
however it is unclear what the impact may be on existing users of this
code. Eg:
com/sun/jndi/toolkit/ctx/Continuation.java
The "environment" is only stored for
Ping again, any one available to review this changeset?
Thanks,
Xuelei
On 5/13/2013 11:06 PM, Xuelei Fan wrote:
> On 5/13/2013 10:52 PM, Wang Weijun wrote:
>> I'll read them tomorrow.
> OK. It's not a urgent fix.
>
>> One question: are all of them designed to be call-by-value instead of
>> shar
On May 27 2013, at 06:05 , Doug Lea wrote:
> On 05/24/13 23:17, Mike Duigou wrote:
>
>> There's an awful lot here!
>
> (It's been a long time since jdk7 :-)
>
>>
>> - It was surprising (and somewhat disappointing) to see changes like the
>> following in various places. Is iterator creation t
Hi Aleksey,
Okay I have some suggested rewordings below and a couple of grammatical
corrections.
I've trimmed out parts that are unchanged.
On 27/05/2013 10:44 PM, Aleksey Shipilev wrote:
A {@code @Contended} field annotation may optionally include a
contention group tag. All fields with the
On 2013-05-27, at 9:27 AM, David Chase wrote:
> Here, seeing is believing (oh, but look, I trashed the output format on the
> warmup, I should fix that):
>
> FIRST, WITH SHORT WARMUP:
> dr2chase:zip $ $BB/java TimeChecksum
> -- Adler32 --
> Warmup... 8 1,312
Changeset: bbf6e6222726
Author:nloodin
Date: 2013-05-27 17:10 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbf6e6222726
6470730: Disconnect button leads to wrong popup message
Reviewed-by: dcubed, sla, egahlin
! src/share/classes/sun/tools/jconsole/VMPanel.java
Changeset: a2dc42667df3
Author:chegar
Date: 2013-05-27 14:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2dc42667df3
8015439: Minor/sync/cleanup of ConcurrentHashMap
Reviewed-by: chegar
Contributed-by: Doug Lea , Chris Hegarty
! src/share/classes/java/util/concurrent/C
Since my previous failed attempt to update the j.u.c. world, this review
is for the update to j.u.c.ConcurrentHashMap v8 from Doug's CVS.
http://cr.openjdk.java.net/~chegar/8005704/ver.00/specdiff/java/util/concurrent/package-summary.html
http://cr.openjdk.java.net/~chegar/8005704/ver.00/webrev/
On 2013-05-27, at 12:38 AM, David Holmes wrote:
> Hi David,
> That said I still have an issue with this code:
>
> 147 if (buf) {
> 148 /* Don't know for sure how big an unsigned long is, therefore
> 149 copy one at a time. */
> 150 int i;
> 151 fo
On 05/24/13 23:17, Mike Duigou wrote:
There's an awful lot here!
(It's been a long time since jdk7 :-)
- It was surprising (and somewhat disappointing) to see changes like the
following in various places. Is iterator creation that expensive? I'd hate to
have to go back to using old style
Changeset: b391ecea538e
Author:vromero
Date: 2013-05-27 13:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b391ecea538e
7030476: Fix conflicting use of JCTree/JCExpression
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/cl
Thanks!
Let's try to re-phrase this as follows (don't mind Javadoc formatting
glitches, I'll fix them in the upcoming webrev):
- 8< --
/*
An annotation expressing that objects and/or their fields are
expected to encounter memory con
On 05/27/13 04:57, Alan Bateman wrote:
Any objection if we move ahead with what Brent has now, at least as first step?
There are are other follow-on changes, the removal of String hash32 field/method
particular, that we are anxious to get in.
Yes, please do.
In which case, here's a problem t
Changeset: 0b8dab7fec54
Author:plevart
Date: 2013-05-27 09:41 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b8dab7fec54
7038914: VM could throw uncaught OOME in ReferenceHandler thread
Summary: Catch OutOfMemoryError in reference handler thread if caused by
allocation of a
Changeset: d78f91ab0e96
Author:uta
Date: 2013-05-27 15:18 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78f91ab0e96
8014394: (fs) WatchService failing when watching \\server\$d
Reviewed-by: alanb
! src/windows/classes/sun/nio/fs/WindowsConstants.java
! src/windows/classes/
On 26/05/2013 13:46, Doug Lea wrote:
On 05/26/13 08:08, Peter Levart wrote:
Clever idea. So your common TreeNode would extend LinkedHashMap.Entry.
Right. (Or renamings/refactorings of these).
And that begets other improvements in part by guaranteeing root
is first node of bin, so doesn't need
On 26/05/2013 12:04, Philippe Marschall wrote:
Hi
It would be nice if javax.xml.stream.XMLStreamReader and
javax.xml.stream.XMLStreamWriter could be made to extend
java.lang.AutoCloseable so that they can be used in a
try-with-resouces statement. The some does for XMLEventReader and
XMLEvent
Mike, David,
Given your feedback I'll slice'n'dice, where appropriate, and try to
make this more manageable for review. I'll follow up with separate
review emails, taking into account your comments.
-Chris.
On 27/05/2013 08:10, David Holmes wrote:
Hi Chris,
I'm adding this to the top becau
Changeset: 6fc7b51e83d6
Author:lagergren
Date: 2013-05-23 15:51 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6fc7b51e83d6
8012522: Clean up lexical contexts - split out stack based functionality in
CodeGenerator and generify NodeVisitors based on their LexicalContext t
Hi Chris,
I'm adding this to the top because now I've gone through it I have to
say that this really needs to be broken up. We have everything from
trivial doc punctuation fixes, through significant performance
enhancements, to streamification of various classes - with some actual
bugs fixed
22 matches
Mail list logo
