On 21/08/2013 01:04, Mike Duigou wrote:
:
The root repo test targets currently trigger off the repo name in order to know
whichrepo/test/Makefile to run. ie. jdk_util triggers running the
jdk/test/Makefile. Would it be possible to retain the repo prefix for the meta group
names? ie. jdk_core
On 21/08/2013 01:04, Dan Xu wrote:
Hi,
MaxPathLength.java testcase failed intermittently. And File.mkdirs()
does not throw any exceptions when it fails, which makes it even
harder for the diagnosis. As Alan suggested, I'd like to change it to
Files.createDirectories to get detailed
Hi David,
your change causes build problems with ubuntu 12.04. Result is:
make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles'
make[2]: *** No rule to make target
`/usr/local/src/jdk8tl/build/linux-x86-normal-server-release/images/lib/jfr.jar',
needed by `all'. Stop.
make[2]:
Hi Andreas,
On 21/08/2013 4:44 PM, Andreas Rieber wrote:
Hi David,
your change causes build problems with ubuntu 12.04. Result is:
make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles'
make[2]: *** No rule to make target
Hi David,
On 21.08.13 09:53, David Holmes wrote:
Hi Andreas,
On 21/08/2013 4:44 PM, Andreas Rieber wrote:
Hi David,
your change causes build problems with ubuntu 12.04. Result is:
make[2]: Entering directory `/usr/local/src/jdk8tl/jdk/makefiles'
make[2]: *** No rule to make target
Fix on the way. This exposed another piece that was missing from the
original change. But mea culpa for not doing an OPENJDK build. Sorry
about that.
Thanks,
David
On 21/08/2013 6:31 PM, Andreas Rieber wrote:
Hi David,
On 21.08.13 09:53, David Holmes wrote:
Hi Andreas,
On 21/08/2013 4:44
Changeset: eb18a483e772
Author:alanb
Date: 2013-08-21 09:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb18a483e772
8023351: Add TEST.groups in preparation to simplify rules in jdk/test/Makefile
Reviewed-by: lancea, mduigou
! test/TEST.ROOT
+ test/TEST.groups
The fix for 8023311 has exposed a second omission in the original fix
for 817570. In Profiles.gmk we filter out jfr.jar when JFR is not
enabled but that is currently applied to the profile3 jar list and needs
to be moved to the full JRE jar list.
webrev:
On 21/08/2013 10:13, David Holmes wrote:
:
webrev:
http://cr.openjdk.java.net/~dholmes/8023460/webrev/
Thanks - and apologies again for the build problem for OpenJDK.
It's good to get to bottom of the original issue. In general the
profiles build is somewhat complicated and easy for issues
On 20/08/2013 17:01, Ivan Gerasimov wrote:
Yes, you're right!
I've updated the test to be a shell script + Java application.
If java reported 'Invalid maximum heap size', the test is skipped.
Just check with JPRT, the test passes on both 64 and 32 bit platforms.
Would you please review the
On Aug 20, 2013, at 11:50 PM, Mike Duigou mike.dui...@oracle.com wrote:
- Additional seed material might be desirable for seeder. I worry about
how many of the actual bits are random. If no local host address is
available the seed might be fairly predictable. In the murmur3
implementation I
Changeset: 68be998c2596
Author:egahlin
Date: 2013-08-19 12:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68be998c2596
6358357: Division by zero in Threads tab when shrinking jconsole window
Reviewed-by: mchung, leifs, jbachorik
!
On 21/08/2013 7:22 PM, Alan Bateman wrote:
On 21/08/2013 10:13, David Holmes wrote:
:
webrev:
http://cr.openjdk.java.net/~dholmes/8023460/webrev/
Thanks - and apologies again for the build problem for OpenJDK.
It's good to get to bottom of the original issue. In general the
profiles build
On Aug 20, 2013, at 11:32 PM, Henry Jen henry@oracle.com wrote:
On 08/20/2013 12:58 PM, Jonathan Gibbons wrote:
Henry,
I think you should sort out the issues you are having with jtreg.
It is not yet clear to me that this is a jtreg issue as much as a test
or library issue.
Changeset: 3b8fed46b2a8
Author:dholmes
Date: 2013-08-21 05:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8fed46b2a8
8023460: OPENJDK build fails due to missing jfr.jar
Reviewed-by: alanb
! makefiles/Profiles.gmk
On 08/21/2013 05:43 AM, Paul Sandoz wrote:
On Aug 20, 2013, at 11:50 PM, Mike Duigou mike.dui...@oracle.com wrote:
- Additional seed material might be desirable for seeder. I worry
about how many of the actual bits are random.
Backing up a bit: I tried using a SecureRandom seed.
But then
Hi Joe, Paul
I rewrote the test in Paul's style without using testNG.
http://cr.openjdk.java.net/~jfranck/8022343/webrev.01/
Please review.
cheers
/Joel
On 2013-08-19, Joe Darcy wrote:
Hi Joel,
I agree the code looks fine.
However, I concur with the general sentiment of Paul test
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a
webrev:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/
I also added some tests related to characteristics associated with fixing
another bug.
Looking at the diffs will
I updated the webrev to adjust some tests that a JPRT run reporting as failing:
FAILED: java/util/Map/CheckRandomHashSeed.java
FAILED: java/util/Map/TreeBinSplitBackToEntries.java
The test TreeBinSplitBackToEntries needs to be revamped as the conditions under
which bins are converted to trees
On Aug 21, 2013, at 12:19 PM, Doug Lea d...@cs.oswego.edu wrote:
On 08/21/2013 05:43 AM, Paul Sandoz wrote:
On Aug 20, 2013, at 11:50 PM, Mike Duigou mike.dui...@oracle.com wrote:
- Additional seed material might be desirable for seeder. I worry
about how many of the actual bits are random.
On 20/08/2013 20:48, Henry Jen wrote:
:
We are using stream test framework on this to verify all style of stream
works, with that we will need to have library on bootclasspath, and that
current prevent us from put it in test/java/util/regex because of jtreg
limitation.
If no object, I'll push
On 19/08/2013 15:57, Henry Jen wrote:
Uh, this one was wrote to be a regular jtreg test running with main, not a
testNG test.
Thanks for looking into this.
Also I am wondering if this one still add any value, it was added to test the
API when we had it like
S super T ComparatorS
I've had a look at these two old bugs:
http://bugs.sun.com/view_bug.do?bug_id=7020857
http://bugs.sun.com/view_bug.do?bug_id=6909804
They are both listed in ProblemList.txt and reported as intermittent failures
in 2011 and 2009 respectively.
I've been searching our test history for
Looks good to me.
-Chris
On 21 Aug 2013, at 15:31, Markus Grönlund markus.gronl...@oracle.com wrote:
Thanks for taking a look at these old bugs Staffan.
Looks good (not a Reviewer).
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 21 augusti 2013 16:21
To:
Thanks Chris and Markus.
/Staffan
On 21 aug 2013, at 16:57, Chris Hegarty chris.hega...@oracle.com wrote:
Looks good to me.
-Chris
On 21 Aug 2013, at 15:31, Markus Grönlund markus.gronl...@oracle.com wrote:
Thanks for taking a look at these old bugs Staffan.
Looks good (not a
Changeset: 8996f47f738d
Author:sla
Date: 2013-08-21 17:19 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8996f47f738d
8023485: Remove com/sun/jdi/DoubleAgentTest.java and
com/sun/jdi/FieldWatchpoints.java from ProblemList.txt
Reviewed-by: chegar, mgronlun
!
I updated the webrev and replaced TreeBinSplitBackToEntries.java with:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/test/java/util/Map/MapBinToFromTreeTest.java.html
Paul.
On Aug 21, 2013, at 4:00 PM, Paul Sandoz paul.san...@oracle.com wrote:
I
Thanks for taking a look at these old bugs Staffan.
Looks good (not a Reviewer).
/Markus
-Original Message-
From: Staffan Larsen
Sent: den 21 augusti 2013 16:21
To: core-libs-dev@openjdk.java.net; serviceability-...@openjdk.java.net
serviceability-...@openjdk.java.net
Subject: RFR:
On 8/20/13 11:27 AM, Joe Darcy wrote:
On 08/20/2013 11:07 AM, Mike Duigou wrote:
Hello all;
This is a proposal to deprecate (Any votes for outright removal?)
Yes; take them out!
Me too! Just take 'em out. Unlike some other sun.misc APIs :-/ there are
already suitable public alternatives
Hearing significant consensus to remove rather than deprecate these two classes
I am revising this proposal remove rather than deprecate. The revised webrev
(which removes the classes) is here:
http://cr.openjdk.java.net/~mduigou/JDK-8023395/1/webrev/
I have verified that they are unused
Looks good.
-Joe
On 08/21/2013 11:33 AM, Mike Duigou wrote:
Hearing significant consensus to remove rather than deprecate these two classes
I am revising this proposal remove rather than deprecate. The revised webrev
(which removes the classes) is here:
Thanks Martin!
I need a sponsor to push this.
-Aleksey.
P.S. The support for multi-threaded tests in jtreg/library is one of the
things I'm eager to have.
On 08/21/2013 10:53 PM, Martin Buchholz wrote:
OK, approved!
I would do things differently, and there is the deeper problem that
2013/8/21 4:33 -0700, mike.dui...@oracle.com:
Hearing significant consensus to remove rather than deprecate these
two classes I am revising this proposal remove rather than
deprecate. The revised webrev (which removes the classes) is here:
Changeset: 60891d90327f
Author:henryjen
Date: 2013-08-20 14:23 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60891d90327f
8016846: Pattern.splitAsStream tests required
Reviewed-by: alanb, psandoz
Contributed-by: Ben Evans benjamin.john.ev...@gmail.com
+
Changeset: fad3b6673159
Author:mduigou
Date: 2013-08-21 12:03 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad3b6673159
8023306: Add replace() implementations to TreeMap
Reviewed-by: psandoz, alanb, chegar, bpb
! src/share/classes/java/util/TreeMap.java
Changeset:
On 08/20/2013 11:18 PM, Alan Bateman wrote:
On 21/08/2013 01:04, Dan Xu wrote:
Hi,
MaxPathLength.java testcase failed intermittently. And File.mkdirs()
does not throw any exceptions when it fails, which makes it even
harder for the diagnosis. As Alan suggested, I'd like to change it to
Changeset: 7de231613e4a
Author:jjg
Date: 2013-08-21 16:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7de231613e4a
8023515: import type-annotations updates
Reviewed-by: jjg
Contributed-by: wdi...@gmail.com
! src/share/classes/com/sun/source/tree/MethodTree.java
!
On 08/20/2013 02:21 AM, Paul Sandoz wrote:
[resending unsigned, sorry if a dup arrives later on]
On Aug 19, 2013, at 9:18 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review the webrev at
http://cr.openjdk.java.net/~henryjen/tl/8023275/0/webrev/
The patch adds override on
With respect to this issue
http://bugs.sun.com/view_bug.do?bug_id=6470700
the code of concern from java.lang.Math is
701private static Random randomNumberGenerator;
702
703private static synchronized Random initRNG() {
704Random rnd = randomNumberGenerator;
705return
On 8/21/13 5:37 PM, Brian Burkhalter wrote:
With respect to this issue
http://bugs.sun.com/view_bug.do?bug_id=6470700
the code of concern from java.lang.Math is
701private static Random randomNumberGenerator;
702
703private static synchronized Random initRNG() {
704Random rnd
Changeset: 2068190f8ac2
Author:emc
Date: 2013-08-21 20:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2068190f8ac2
7118412: Shadowing of type-variables vs. member types
4987840: What is the scope of an annotation?
Summary: Fixed issue with shadowing of type names.
On Aug 21, 2013, at 5:01 PM, David M. Lloyd wrote:
I don't think you'd want to introduce the overhead of synchronization here.
No, I don't. My example code was just that.
It may be better in this case to use this kind of lazy init pattern:
static final class Holder {
static
Changeset: 57e1266527dd
Author:jjg
Date: 2013-08-21 17:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/57e1266527dd
8022287: javac.sym.Profiles uses a static Map when it should not
Reviewed-by: ksrini
! src/share/classes/com/sun/tools/javac/sym/Profiles.java
+
On Aug 21, 2013, at 4:37 PM, Brian Burkhalter brian.burkhal...@oracle.com
wrote:
With respect to this issue
http://bugs.sun.com/view_bug.do?bug_id=6470700
the code of concern from java.lang.Math is
701private static Random randomNumberGenerator;
702
703private static
Changeset: eebb29618f50
Author:emc
Date: 2013-08-21 20:41 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/eebb29618f50
8023520: Add missing test for JDK-7118412
Summary: The test for JDK-7118412 was dropped from the changeset in a merging
accident.
Reviewed-by: jjg
+
There's a significant difference here: Random reads the field into a local
and then operates only on the local. Looking at the code, I only see one
possible (bizarre) circumstance where you can hit NPE. If code was
transformed to:
static double random() {
Random rnd =
Hi all,
Please review this small documentation change to the example I added to
RMISocketFactory a couple weeks ago [1]. This change fixes a problem
that Bernd Eckenfels pointed out [2] where the interface returned by
getLoopbackAddress() might not match the interface that localhost
resolves
On Aug 21 2013, at 17:01 , David M. Lloyd wrote:
On 8/21/13 5:37 PM, Brian Burkhalter wrote:
With respect to this issue
http://bugs.sun.com/view_bug.do?bug_id=6470700
the code of concern from java.lang.Math is
701private static Random randomNumberGenerator;
702
703private
48 matches
Mail list logo
