On 09/26/2013 01:27 AM, Christian Thalinger wrote:
http://cr.openjdk.java.net/~twisti/8019192/webrev/
8019192: StringIndexOutOfBoundsException: in Class.getSimpleName()
Reviewed-by:
This is a race in MemberName's name and type getters.
MemberName's type field is of type Object so it can hold
On 25/09/2013 15:19, Brent Christian wrote:
Please review this change for 8025173, HashMap.put() replacing an
existing key can trigger a resize().
A description of the problem can be found in the bug report:
http://bugs.sun.com/view_bug.do?bug_id=8025173
Thanks to Doug Lea for sending in the
Changeset: c5475f5d4647
Author:sundar
Date: 2013-09-24 20:43 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/c5475f5d4647
8025312: parseInt should convert 'radix' argument to ToInt32 even if empty
string is parsed
Reviewed-by: jlaskey, hannesw
!
Hi all,
I need to exclude some tests due a recent change to jstat that caused to
jstat to output the \ufffd for Double.NaN, which confused the tests. I
am working on a solution to this, but in the meantime I would like to
exclude the tests in order not cause unexpected failures.
Webrev:
On 09/16/2013 12:30 PM, Volker Simonis wrote:
src/share/lib/security/java.security-aix
- Provide default java.security-aix for AIX.
The login.configuration.provider property should be set to:
sun.security.provider.ConfigFile
See 8016848 for more info.
After you make this change,
Hi Sean,
anything new about this?
I fixed the copyright/indentation problems (the only change), so the
updated jaxws-webrev is located here:
http://cr.openjdk.java.net/~mkos/8025054/webrev-jaxws.01/
Since the timestamp (version number) changed too, I updated also the
JIRA issue:
Hi Erik,
Looks good!, the bug must be tagged with keyword noreg-build.
Kumar
Hi all,
I need to exclude some tests due a recent change to jstat that caused to
jstat to output the \ufffd for Double.NaN, which confused the tests. I
am working on a solution to this, but in the meantime I would
On 9/26/13 6:11 AM, Alan Bateman wrote:
On 25/09/2013 15:19, Brent Christian wrote:
The fix looks right to me.
Thanks.
One comment on the test is that testItr is
using raw types, is there any reason for thaht?
Pure laziness! Here, this one's nicer:
On 9/25/13 4:03 PM, Martin Buchholz wrote:
Looks good.
I would only suggest the stylistic improvement of using proper /**
javadoc comments even for private test methods instead of /*
The comments were meant as internal documentation and not real
javadoc. After dabbling with some doclint
Changeset: 9235ae08a449
Author:jlahoda
Date: 2013-09-26 20:07 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9235ae08a449
8025491: Javac regression test
tools/javac/T8003967/DetectMutableStaticFields.java failing
Summary: Making HtmlTree.NONENCODING_CHARS final
Changeset: 13eba2e322e6
Author:vromero
Date: 2013-09-26 19:06 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/13eba2e322e6
8025139: javac patch for using bootstrap compiler for debugging is not working
properly
Reviewed-by: jjg
! make/netbeans/langtools/build.xml
!
On Sep 26, 2013, at 1:22 AM, Peter Levart peter.lev...@gmail.com wrote:
On 09/26/2013 01:27 AM, Christian Thalinger wrote:
http://cr.openjdk.java.net/~twisti/8019192/webrev/
8019192: StringIndexOutOfBoundsException: in Class.getSimpleName()
Reviewed-by:
This is a race in MemberName's
On Sep 26, 2013, at 9:22 AM, Sergey Kuksenko sergey.kukse...@oracle.com wrote:
Hi All,
I updated fix.
You may find it here
http://cr.openjdk.java.net/~skuksenko/jsr335/8024635/webrev.01/
The change looks good. Since we use Objects.requireNonNull now we can remove
the null check comment:
On Sep 26, 2013, at 11:50 AM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 1:22 AM, Peter Levart peter.lev...@gmail.com wrote:
On 09/26/2013 01:27 AM, Christian Thalinger wrote:
http://cr.openjdk.java.net/~twisti/8019192/webrev/
8019192:
Changeset: 8f27030686a6
Author:bchristi
Date: 2013-09-26 11:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f27030686a6
8025173: HashMap.put() replacing an existing key can trigger a resize()
Summary: Ensure that HashMap is not resized if we're just replacing a value
On Sep 26, 2013, at 1:13 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 11:50 AM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 1:22 AM, Peter Levart peter.lev...@gmail.com wrote:
On 09/26/2013 01:27 AM, Christian
On Sep 26, 2013, at 2:28 PM, John Rose john.r.r...@oracle.com wrote:
On Sep 26, 2013, at 1:13 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 11:50 AM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 1:22 AM, Peter
Changeset: 17653c4c22ec
Author:sogoel
Date: 2013-09-26 15:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/17653c4c22ec
8011738: Write test to check for bootstrap attributes for lambda expressions in
class file
Reviewed-by: mcimadamore
+
On 9/24/2013 10:56 PM, Peter Levart wrote:
Just a thought. How does URLClassLoader do the class name - path to
resource translation? Perhaps there's already some code that does this
correctly and in a platform-specific way (haven't looked)...
sun.misc.ParseUtil.encodePath
Mandy
Hi Henry,
On 9/25/2013 12:37 AM, Henry Jen wrote:
Hi,
Please review the update webrev at
http://cr.openjdk.java.net/~henryjen/ccc/8023524/2/webrev/
The doPrivileged block looks okay. It'd be good to limit privileges
by calling the doPrivileged method with a specific set of Permissions.
In
Chris,
Since you touched getName(), maybe get rid of that superfluous null check
after expandFromVM? The code can just fall through.
Vitaly
Sent from my phone
On Sep 26, 2013 5:47 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 2:28 PM, John Rose
Why not add the required code when/if it's actually needed? It's not like
the pattern is tricky :) your call of course, just looks odd as-is.
Sent from my phone
On Sep 26, 2013 8:15 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
On Sep 26, 2013, at 5:11 PM, Vitaly Davidovich
On Sep 26, 2013, at 2:46 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
The problem I have with this is that some people might think the local
variable is the instance field. IDEs help here because they usually
highlight local variables and instance fields in different
The new diagnostics are generated by the new doclint feature which is
available from the javac and javadoc command lines.
When invoked from javadoc, it only checks the comments being used for
the docs that you are generating. So, if you are generating docs for
just your public and protected
On Sep 26, 2013, at 5:24 PM, Vitaly Davidovich vita...@gmail.com wrote:
Why not add the required code when/if it's actually needed? It's not like the
pattern is tricky :)
Of course the pattern is not tricky. The fact that expandFromVM calls down
into the VM which is filling in fields and
On Sep 19, 2013, at 9:57 AM, David Chase david.r.ch...@oracle.com wrote:
Recommended changes made:
http://cr.openjdk.java.net/~drchase/8022701/webrev.04/
Looks good. Thanks for using ASM.
Test with jtreg (for pass and for induced failure) on MacOS,
not sure what additional other
On Sep 19, 2013, at 2:31 PM, John Rose john.r.r...@oracle.com wrote:
On Sep 18, 2013, at 5:05 PM, Christian Thalinger
christian.thalin...@oracle.com wrote:
src/share/classes/java/lang/invoke/MethodHandles.java:
+ * methods as if they were normal methods, but the JVM verifier
On Sep 19, 2013, at 9:57 AM, David Chase david.r.ch...@oracle.com wrote:
Recommended changes made:
http://cr.openjdk.java.net/~drchase/8022701/webrev.04/
Good; reviewed.
Consider adding this tweak, which would close the loop on alternation between
the fooError and fooException versions:
+
28 matches
Mail list logo
