Re: JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/23/2013 06:37 PM, Brian Burkhalter wrote: > The results suggest that the effect of the equality test (val == > this) is insignificant. Significant performance improvement was > however observed for squaring of values with int array magnitude >

hg: jdk8/tl/jdk: 7122887: JDK ignores Gnome3 proxy settings

Changeset: c9562ac9b812 Author:dxu Date: 2013-10-23 22:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9562ac9b812 7122887: JDK ignores Gnome3 proxy settings Summary: Fix GConf and add to use GProxyResolver to handle network proxy resolution Reviewed-by: chegar ! src/sol

hg: jdk8/tl/langtools: 8023682: Incorrect attributes emitted for anonymous class declaration

Changeset: 119747cd9f25 Author:emc Date: 2013-10-24 01:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/119747cd9f25 8023682: Incorrect attributes emitted for anonymous class declaration Summary: Cause javac to emit type annotations on new instruction as well as anony

hg: jdk8/tl/langtools: 8006732: support correct bytecode storage of type annotations in multicatch

Changeset: d2fa3f7e964e Author:emc Date: 2013-10-23 23:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d2fa3f7e964e 8006732: support correct bytecode storage of type annotations in multicatch Summary: Fix issue with annotations being added before attribution, which c

Re: RFR: 8023862: deprecate HTTP proxying from RMI

On 10/23/13 3:13 PM, Mandy Chung wrote: On 10/21/2013 5:23 PM, Stuart Marks wrote: Please review the following spec change (deprecation) and change of a property default value. Briefly, RMI has some machinery that will attempt to tunnel RMI requests through HTTP under certain circumstances. Thi

hg: jdk8/tl/langtools: 8026936: Initialize LamdbaToMethod lazily and as required

Changeset: 31fe30e2deac Author:ksrini Date: 2013-10-23 15:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/31fe30e2deac 8026936: Initialize LamdbaToMethod lazily and as required Reviewed-by: jjg, rfield Contributed-by: jan.lah...@oracle.com ! src/share/classes/com/sun

JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

Please review this patch at your convenience: Issue: https://bugs.openjdk.java.net/browse/JDK-4891331 Webrev: http://cr.openjdk.java.net/~bpb/4891331/webrev/ This review request follows from this RFC thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022266.html More ext

RFR 8025003: Base64 should be less strict with padding

Hi, The current spec and implementation of Base64 decoder [1] is standard/rfc based, in which it interprets/decodes the ending padding character(s) correctly if present. The ending padding character(s) is not requested (liberal), but if present, the spec and implementation requests they MUST be e

hg: jdk8/tl/jdk: 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError

Changeset: d9d3705a992f Author:rfield Date: 2013-10-23 15:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d9d3705a992f 8025868: Several lang/LMBD JCK tests fail with java.lang.BootstrapMethodError Summary: Wildcard marker interfaces can cause duplicate implemented interface

Re: RFR: 8023862: deprecate HTTP proxying from RMI

On 10/21/2013 5:23 PM, Stuart Marks wrote: Hi all, Please review the following spec change (deprecation) and change of a property default value. Briefly, RMI has some machinery that will attempt to tunnel RMI requests through HTTP under certain circumstances. This is a maintenance burden a

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 23 October 2013 17:33, Alan Bateman wrote: >> I might have been tempted to conserve on classes and code duplication to >> share a serialization proxy between the classes and maybe even shorten the >> name. >> But it is hard to argue with the simplicity and directness of this design. > > I don't

hg: jdk8/tl/jdk: 8024688: further split Map and ConcurrentMap defaults eliminating looping from Map defaults, Map.merge fixes and doc fixes.

Changeset: f4129fcfacdc Author:mduigou Date: 2013-10-23 14:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4129fcfacdc 8024688: further split Map and ConcurrentMap defaults eliminating looping from Map defaults, Map.merge fixes and doc fixes. Reviewed-by: psandoz, dholmes

hg: jdk8/tl/langtools: 2 new changesets

Changeset: abc3eaccba73 Author:jlahoda Date: 2013-10-23 23:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abc3eaccba73 8027191: Fix for JDK-8026861 refers to an incorrect bug number Summary: Reverting changeset b05db8c815e8, so that it can be applied again with a co

Re: RFR (JAXP enableExtensionFunctions): 8004476 XSLT Extension Functions Don't Work in WebStart

looks OK joe On Oct 23, 2013, at 3:42 PM, huizhe wang wrote: > Hi Daniel, > > Thanks for the review and the detailed list. I've updated the webrev: > > http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/ > > Thanks, > Joe > > On 10/23/2013 11:25 AM, Daniel Fuchs wrote: >> Hi Joe, >> >> I b

hg: jdk8/tl/langtools: 8026770: javadoc creates invalid HTML in profile summary pages

Changeset: 8746caa5cf80 Author:bpatel Date: 2013-10-23 13:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8746caa5cf80 8026770: javadoc creates invalid HTML in profile summary pages Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWri

Re: RFR (JAXP enableExtensionFunctions): 8004476 XSLT Extension Functions Don't Work in WebStart

On 10/23/13 9:42 PM, huizhe wang wrote: Hi Daniel, Thanks for the review and the detailed list. I've updated the webrev: http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/ Looks good! -- daniel Thanks, Joe On 10/23/2013 11:25 AM, Daniel Fuchs wrote: Hi Joe, I believe all the private

hg: jdk8/tl/jdk: 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs

Changeset: ee7f1c78bec7 Author:coffeys Date: 2013-10-23 20:51 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee7f1c78bec7 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs Reviewed-by: chegar ! test/javax/xml/ws/clientjar/TestWsImpo

Re: RFR (JAXP enableExtensionFunctions): 8004476 XSLT Extension Functions Don't Work in WebStart

Hi Daniel, Thanks for the review and the detailed list. I've updated the webrev: http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/ Thanks, Joe On 10/23/2013 11:25 AM, Daniel Fuchs wrote: Hi Joe, I believe all the private FeatureManager could be declared final since asfar as I can tell t

Re: RFR : 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs

Sean, I have seen this test failing consistently on some systems, the use of system proxies would explain that. Your change, to make the test independent of the system proxies, looks good to me. -Chris. On 10/23/2013 08:27 PM, Seán Coffey wrote: Hi, this is a test stabilization fix for j

RFR : 8026405: javax/xml/ws/clientjar/TestWsImport.java failing on JDK 8 nightly aurora test runs

Hi, this is a test stabilization fix for jdk8-tl. It turns out that the wsimport tool sets java.net.useSystemProxies to true. This can cause connection issues to localhost for some windows environments depending on proxy configuration. Best solution here is to disable the systemProxies since

RFR: update to lambda metafactory spec

This webrev: http://cr.openjdk.java.net/~briangoetz/JDK-8019646/webrev/ contains minor changes to the lambda metafactory implementation, and a significant overhaul of its specification. There are only two behavioral changes, the rest of the changes are in exposition: - Metafactory no long

hg: jdk8/tl/jdk: 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java

Changeset: 88acc99132e2 Author:rfield Date: 2013-10-23 11:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88acc99132e2 8027176: Remove redundant jdk/lambda/vm/DefaultMethodsTest.java Reviewed-by: ksrini - test/jdk/lambda/vm/DefaultMethodsTest.java

Re: 8026863: regression in anonymous Logger.setParent method

Hi Mandy, Thanks for the review. I have taken the opportunity to further clarify the behavior of the various setters when the logger is an anonymous logger. The fix itself hasn't changed. Here is the new revision: best regards, --

Re: RFR (JAXP enableExtensionFunctions): 8004476 XSLT Extension Functions Don't Work in WebStart

Hi Joe, I believe all the private FeatureManager could be declared final since asfar as I can tell they are only set within the constructor. You could add 'final' to all declaration below: XSLTC.java: 53 private FeatureManager _featureManager; TransformerFactoryImpl.java: 232 priva

Re: RFR: 8026427: deprecate obsolete APIs from java.rmi

With the previous comments in mind, looks OK to me. Darryl On 10/21/2013 07:07 PM, Stuart Marks wrote: Hi all, Please review this small spec change to deprecate some obsolete RMI APIs, along with a bit of associated cleanup. There are no functional changes in this changeset. Bug: http

hg: jdk8/tl/langtools: 8022720: Method refeerences - private method should be accessible (nested classes)

Changeset: 32ea6ccb7607 Author:rfield Date: 2013-10-23 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/32ea6ccb7607 8022720: Method refeerences - private method should be accessible (nested classes) Reviewed-by: jjg, ksrini ! src/share/classes/com/sun/tools/javac

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 10/23/2013 12:33 PM, Alan Bateman wrote: I might have been tempted to conserve on classes and code duplication to share a serialization proxy between the classes and maybe even shorten the name. But it is hard to argue with the simplicity and directness of this design. I don't have a strong

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 10/23/2013 11:17 AM, Chris Hegarty wrote: Looks fine to me. Should all SerializationProxy classes have the same serialVersionUID ( = 7249069246863182397L ) ? Not only that, it is the same as that for the main classes themselves. It should simplify ability to check any errors in cases anyon

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 23/10/2013 15:32, roger riggs wrote: : The signature of the readObject methods usually has the return type Object even though in this case it should never be used. And a method comment would be nice saying why it always throws an exception. I checked Serializable and it defines readObject'

hg: jdk8/tl/nashorn: 3 new changesets

Changeset: 5df55690fd5b Author:sundar Date: 2013-10-23 17:30 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/5df55690fd5b 8027128: jdk.nashorn.api.scripting.JSObject should be an interface Reviewed-by: hannesw, attila, jlaskey + src/jdk/nashorn/api/scripting/AbstractJSObj

hg: jdk8/tl/corba: 5036554: unmarshal error on CORBA alias type in CORBA any

Changeset: a90e9efa4264 Author:coffeys Date: 2013-10-23 16:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/a90e9efa4264 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks ! src/share/classes/com/sun/corba/se/impl/corba/AnyImpl.java

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 23/10/2013 15:37, Paul Sandoz wrote: : Testing wise if you really want to use lambda expressions then they need to be explicitly marked as serializable otherwise it's gonna barf (as you probably found out): DoubleBinaryOperator plus = (DoubleBinaryOperator& Serializable) (x, y)

Re: RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

On 22/10/2013 23:56, Alexander Zuev wrote: Alan, i guess you're right, i have updated code to use the same method with fallback for creation .pack temporary file. New webrev can be found at http://cr.openjdk.java.net/~kizune/8020802/webrev.05 /Alex Thanks, this is better. A small suggesti

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 23/10/2013 15:22, Doug Lea wrote: On 10/23/2013 10:06 AM, Alan Bateman wrote: A minor difference with what is currently in the CVS is that I've added a link in the writeReplace javadoc to the proxy class. I adjusted accordingly. I'm not sure why just {@link ...} didn't suffice. I think

hg: jdk8/tl/jdk: 5036554: unmarshal error on CORBA alias type in CORBA any

Changeset: 2af3f5a61322 Author:coffeys Date: 2013-10-23 16:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2af3f5a61322 5036554: unmarshal error on CORBA alias type in CORBA any Reviewed-by: chegar, smarks + test/com/sun/corba/5036554/JavaBug.java + test/com/sun/corba/5036

Re: RFR : 5036554 : unmarshal error on CORBA alias type in CORBA any

Looks fine to me Sean. -Chris. On 23/10/2013 08:59, Seán Coffey wrote: Thanks for review Stuart. I meant to give the public link. Here it is for records : http://cr.openjdk.java.net/~coffeys/webrev.5036554.jdk8/webrev/ regard

hg: jdk8/tl/jdk: 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

Changeset: 3cdf6ca3ef47 Author:kizune Date: 2013-10-23 18:35 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3cdf6ca3ef47 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking Reviewed-by: alanb, ksrini ! src/share/classes/sun/tools

Re: RFR: 8004912: Repeating annotations - getAnnotationsByType is not working as expected

On 10/22/2013 03:20 PM, Peter Levart wrote: I think the problem could be solved in two ways: - by explicitly scanning the inheritance chain for the 1st class that has the annotations of type T present directly or indirectly (by containment). - by "canonicalizing" the representation of the re

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

Looks fine to me. Should all SerializationProxy classes have the same serialVersionUID ( = 7249069246863182397L ) ? -Chris. On 23/10/2013 15:06, Alan Bateman wrote: j.u.c.atomic.{Double,Long}.{Accumulator,Adder} extend a package-private class Striped64 that does striping on 64-bit values. T

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Hi Masayoshi, At that time I was asked to have regression test to validate each translation changes. With our new translation process for TimeZoneNames and new planned regression tests from Aleksej for JDK-8025051 , I believe we can remove t

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On Oct 23, 2013, at 4:06 PM, Alan Bateman wrote: > > j.u.c.atomic.{Double,Long}.{Accumulator,Adder} extend a package-private class > Striped64 that does striping on 64-bit values. This super type is > Serializable by way of extending Number. Striped64 doesn't contribute any > serial fields b

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

Hi Alan, That looks fine. The signature of the readObject methods usually has the return type Object even though in this case it should never be used. And a method comment would be nice saying why it always throws an exception. I might have been tempted to conserve on classes and code duplica

Re: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

On 10/23/2013 10:06 AM, Alan Bateman wrote: In practical terms this is a bit of a non-issue I suppose it is a good sign that people are mostly just fixing non-issues as freeze dates approach :-) The webrev with the proposed changes is here: http://cr.openjdk.java.net/~alanb/8026344/webrev/

hg: jdk8/tl/jdk: 8020758: HttpCookie constructor does not throw IAE when name contains a space

Changeset: f120672b91ef Author:chegar Date: 2013-10-23 14:38 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f120672b91ef 8020758: HttpCookie constructor does not throw IAE when name contains a space Reviewed-by: michaelm, msheppar ! src/share/classes/java/net/HttpCookie.java

hg: jdk8/tl/jdk: 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection

Changeset: 8c20e9ef8709 Author:sla Date: 2013-10-23 15:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c20e9ef8709 8026789: Update test/java/lang/instrument/Re(transform|define)BigClass.sh test to use NMT for memory leak detection Reviewed-by: dcubed ! test/ProblemList.t

8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

j.u.c.atomic.{Double,Long}.{Accumulator,Adder} extend a package-private class Striped64 that does striping on 64-bit values. This super type is Serializable by way of extending Number. Striped64 doesn't contribute any serial fields but its name does leak into the serial stream because there i

hg: jdk8/tl/jdk: 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because expect non-zero pools

Changeset: f4970c7abe93 Author:jbachorik Date: 2013-10-23 15:03 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4970c7abe93 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because expect non-zero pools Reviewed-by: mchung, sjiang ! test/java/lang/ma

Re: RFR [8024521] (process) Async close issues with Process InputStream

On 23/10/2013 12:41, Ivan Gerasimov wrote: Thank you Rob for offering the sponsor's help! Here's the exported patch: http://cr.openjdk.java.net/~igerasim/2commit/8024521-jdk8-Async-close-race.patch Alan, I reduced the default time gap to 20 seconds as you suggested. Thanks for dialing it down.

Re: RFR [8024521] (process) Async close issues with Process InputStream

Thank you Rob for offering the sponsor's help! Here's the exported patch: http://cr.openjdk.java.net/~igerasim/2commit/8024521-jdk8-Async-close-race.patch Alan, I reduced the default time gap to 20 seconds as you suggested. Sincerely yours, Ivan On 22.10.2013 23:14, Rob McKenna wrote: Happy

hg: jdk8/tl/langtools: 8026508: Invokedynamic instructions don't get line number table entries

Changeset: b05db8c815e8 Author:jlahoda Date: 2013-10-23 07:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b05db8c815e8 8026508: Invokedynamic instructions don't get line number table entries Summary: Setting or correcting positions for many trees produced by LambdaT

hg: jdk8/tl/jdk: 8025734: Use literal IP address where possible in SocketPermission generated by HttpURLPermission

Changeset: 1b0dfa631b6f Author:michaelm Date: 2013-10-23 11:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b0dfa631b6f 8025734: Use literal IP address where possible in SocketPermission generated by HttpURLPermission Reviewed-by: chegar ! src/share/classes/sun/net/www/p

Re: DecimalFormat regression bug in Java 8?

Thank you for your answer. I understand completely. However, while I fully agree the Java 8 formatting is correct, is still causes regressions in the product I'm working on, and I shall have to code a workaround for Java 8. Oh well. Coding is what we get paid for. Best regards, /Lennart Börj

hg: jdk8/tl/jdk: 7105883: JDWP: agent crash if there exists a ThreadGroup with null name

Changeset: c077a2810782 Author:egahlin Date: 2013-10-23 10:50 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c077a2810782 7105883: JDWP: agent crash if there exists a ThreadGroup with null name Reviewed-by: sla, jbachorik ! src/share/back/ThreadGroupReferenceImpl.c + test/co

Re: RFR : 5036554 : unmarshal error on CORBA alias type in CORBA any

Thanks for review Stuart. I meant to give the public link. Here it is for records : http://cr.openjdk.java.net/~coffeys/webrev.5036554.jdk8/webrev/ regards, Sean. On 23/10/2013 06:00, Stuart Marks wrote: Seems like a sensib