Re: JDK 8 (initial) RFR for JDK-8005294 : Consider default methods for additions to AnnotatedElement

Hi Joel, On 10/24/2013 09:08 AM, Joel Borggrén-Franck wrote: Hi Joe, I think this a desirable change. Some design questions inline, Also please note the related work going on here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022590.html On 24 okt 2013, at 15:31, Joe Dar

hg: jdk8/tl/jdk: 8026929: remove accelerators from policytool resources

Changeset: e9ec0ca5bab1 Author:weijun Date: 2013-10-25 08:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e9ec0ca5bab1 8026929: remove accelerators from policytool resources Reviewed-by: alexp, weijun Contributed-by: Leif Samuelsson ! src/share/classes/sun/security/tools/

hg: jdk8/tl/langtools: 8027220: DefaultMethodsTest: Change test to match spec

Changeset: 860f1d21763a Author:rfield Date: 2013-10-24 16:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/860f1d21763a 8027220: DefaultMethodsTest: Change test to match spec Reviewed-by: ksrini ! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/TestHarness.ja

JDK 8 RFR 6910473: BigInteger range

Please review at your convenience. --- Issues --- https://bugs.openjdk.java.net/browse/JDK-6910473 https://bugs.openjdk.java.net/browse/JDK-8021203 https://bugs.openjdk.java.net/browse/JDK-8021204 https://bugs.openjdk.java.net/browse/JDK-8022780 ---Webrev --- http://cr.openjdk.java.net/~bpb/69104

hg: jdk8/tl/jaxp: 8004476: XSLT Extension Functions Don't Work in WebStart

Changeset: 390e94b9a852 Author:joehw Date: 2013-10-24 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/390e94b9a852 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb ! src/com/sun/org/apache/xalan/internal/XalanConstants.java +

hg: jdk8/tl/jdk: 8004476: XSLT Extension Functions Don't Work in WebStart

Changeset: 05dbf105e70f Author:joehw Date: 2013-10-24 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05dbf105e70f 8004476: XSLT Extension Functions Don't Work in WebStart Reviewed-by: dfuchs, lancea, alanb + test/javax/xml/jaxp/transform/jdk8004476/SecureProcessingTest

hg: jdk8/tl/langtools: 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags

Changeset: 667843bd2193 Author:bpatel Date: 2013-10-24 11:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/667843bd2193 8006248: Since addition of -Xdoclint, javadoc ignores unknown tags Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/Configura

hg: jdk8/tl/jdk: 8025003: Base64 should be less strict with padding

Changeset: e7bdb2fcc7bc Author:sherman Date: 2013-10-24 11:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7bdb2fcc7bc 8025003: Base64 should be less strict with padding Summary: updated spec and implementation of mime decoder to be lenient for padding Reviewed-by: alanb

hg: jdk8/tl/jdk: 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms

Changeset: 66884b270b44 Author:twisti Date: 2013-10-24 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/66884b270b44 8026502: java/lang/invoke/MethodHandleConstants.java fails on all platforms Reviewed-by: iveresov, jrose ! src/share/classes/java/lang/invoke/MethodHandle

hg: jdk8/tl/jdk: 8027170: Annotations declared on super-super-class should be overridden by super-class.

Changeset: b8927cbfb893 Author:alundblad Date: 2013-10-24 18:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b8927cbfb893 8027170: Annotations declared on super-super-class should be overridden by super-class. Reviewed-by: jfranck Contributed-by: andreas.lundb...@oracle.co

hg: jdk8/tl/jdk: 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result

Changeset: 93e696ba5923 Author:jfranck Date: 2013-10-24 19:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93e696ba5923 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result Reviewed-

hg: jdk8/tl/jdk: 8019646: Clarify javadoc contract of LambdaMetafactory

Changeset: 5fa2fd782993 Author:briangoetz Date: 2013-10-24 13:06 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fa2fd782993 8019646: Clarify javadoc contract of LambdaMetafactory Reviewed-by: briangoetz, rfield Contributed-by: dan.sm...@oracle.com ! src/share/classes/java/l

hg: jdk8/tl/jdk: 8023862: deprecate HTTP proxying from RMI

Changeset: 808b9ef4f667 Author:smarks Date: 2013-10-24 10:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/808b9ef4f667 8023862: deprecate HTTP proxying from RMI Reviewed-by: mchung ! src/share/classes/java/rmi/server/RMISocketFactory.java ! src/share/classes/java/rmi/serve

Re: 8026863: regression in anonymous Logger.setParent method

On 10/23/2013 11:49 AM, Daniel Fuchs wrote: Hi Mandy, Thanks for the review. I have taken the opportunity to further clarify the behavior of the various setters when the logger is an anonymous logger. The fix itself hasn't changed. Here is the new revision:

Re: RFR: 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result

Looks fine Joel; thanks, -Joe On 10/24/2013 12:51 AM, Joel Borggrén-Franck wrote: Hi, Please review this fix for reflection for type annotations. The problem was that the reflection side expected a different encoding of nested (static) inner classes. Also the type of the receiver parameter f

Re: RFR: 8027170: Annotations declared on super-super-class should be overridden by super-class

Looks good Andreas. I can sponsor this. cheers /Joel On 24 okt 2013, at 17:18, Andreas Lundblad wrote: > Hi, > > Please review the fix for JDK-8027170 below. > > Description: > Class.getAnnotationsByType did not differentiate between annotations in > superclass and annotations in supersuper

Re: JDK 8 (initial) RFR for JDK-8005294 : Consider default methods for additions to AnnotatedElement

Hi Joe, I think this a desirable change. Some design questions inline, Also please note the related work going on here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022590.html On 24 okt 2013, at 15:31, Joe Darcy wrote: > Hello, > > Please review my initial implementatio

Re: JDK 8 (initial) RFR for JDK-8005294 : Consider default methods for additions to AnnotatedElement

Hi Peter, Joe, On 24 okt 2013, at 22:10, Peter Levart wrote: > Hi Joe, > > I see two problems with the implementation in AnnotatedElementSupport. The > first is the treatment of declared-only annotations where the code returns > either directly present or in-directly present repeatable annota

Re: RFR: 8004912: Repeating annotations - getAnnotationsByType is not working as expected

Hi Andreas, I think this is correct now. By coincidence, Joe Darcy is trying to implement default methods in interface AnnotatedElement and I think those two attempts could be merged. The s.r.a.AnnotationSupport static methods: getDirectlyAndIndirectlyPresent & getAssociatedAnnotations could

Re: RFR 8025003: Base64 should be less strict with padding

On 23/10/2013 23:42, Xueming Shen wrote: : Here is the webrev http://cr.openjdk.java.net/~sherman/8025003/webrev/ I've looked through the changes. The method rename make sense as it is a MIME Encoder. Also I think having the MIME Decoder be lenient is reasonable too. There will be cases whe

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Agreed. It was unnecessary, but it was the practice at that time. thanks, -michael On 13?10?24? 01:55 ??, Masayoshi Okutsu wrote: The test detected the translation changes as regression, but that was unnecessary? I prefer to remove this test rather than changing the data. Thanks, Masayoshi

Re: JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

Thanks, Joe. I'll update the @implNote accordingly before integration assuming the Windows numbers corroborate the other results. Brian On Oct 24, 2013, at 1:09 AM, Joe Darcy wrote: > I approve the code implementation changes going back contingent on the > Windows i7 performance results being

Re: JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

On Oct 23, 2013, at 11:23 PM, Alan Eliasen wrote: > In short, these patches look good and effective, and will make many > cases faster for many users without slowing down existing cases > appreciably, and without users having to change their programs. The > code impact is minor and easily under

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch locat

Re: JDK 8 (initial) RFR for JDK-8005294 : Consider default methods for additions to AnnotatedElement

Hi Joe, I see two problems with the implementation in *AnnotatedElementSupport*. The first is the treatment of declared-only annotations where the code returns either directly present or in-directly present repeatable annotations, but not both. So in the following example: @Ann(1) @AnnCont({

hg: jdk8/tl/jdk: 8024521: (process) Async close issues with Process InputStream

Changeset: e2ec05b2ed94 Author:igerasim Date: 2013-10-23 15:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2ec05b2ed94 8024521: (process) Async close issues with Process InputStream Reviewed-by: psandoz, martin, alanb, robm ! src/solaris/classes/java/lang/UNIXProcess.jav

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch located here: http://cr.openjdk.java.net/~aefimov/8026772/8026772_jdk8.patch. Thank you, Aleksej On 10/24/2013 04:27

hg: jdk8/tl/jdk: 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable

Changeset: 700d62b8d9cc Author:alanb Date: 2013-10-24 13:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/700d62b8d9cc 8026344: j.u.c.a *Adder and *Accumulator extend a package private class that is Serializable Reviewed-by: rriggs, psandoz, chegar Contributed-by: d...@cs.o

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Alan, I have added this test to ProblemList.txt and keep the test update: http://cr.openjdk.java.net/~aefimov/8026772/webrev.01/. I suppose, with such resolution we can safely close this minor bug. And we will decide this test destiny in 8025051. Thanks, Aleksej On 10/24/2013 04:00 PM, Alan B

Re: RFR [8024521] (process) Async close issues with Process InputStream

On 24/10/2013 01:02, Martin Buchholz wrote: I include an improved test, that drops the repro time by an order of magnitude, to around 20 seconds, but still too long and non-portable to make this a well-behaved jtreg test. I suggest checking in this version, except that I would still make this

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

On 24/10/2013 10:05, Aleksej Efimov wrote: Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questio

RFR: 8027170: Annotations declared on super-super-class should be overridden by super-class

Hi, Please review the fix for JDK-8027170 below. Description: Class.getAnnotationsByType did not differentiate between annotations in superclass and annotations in supersuperclass. This is however required by the definition of associated annotations. The patch addresses this issue by modifyi

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questionable test, but add some replacement for it.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

The test detected the translation changes as regression, but that was unnecessary? I prefer to remove this test rather than changing the data. Thanks, Masayoshi On 10/24/2013 12:12 AM, Michael Fang wrote: Hi Masayoshi, At that time I was asked to have regression test to validate each transla

Re: JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

Hi Brian, I approve the code implementation changes going back contingent on the Windows i7 performance results being similar. I would change the @implNote to something less specific: "An implementation may offer better algorithmic performance when {@code val == this}." Thanks for running

hg: jdk8/tl/jdk: 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads

Changeset: e6bc0dca294b Author:sla Date: 2013-10-15 12:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6bc0dca294b 8009681: TEST_BUG: MethodExitReturnValuesTest.java may fail when there are unexpected background threads Reviewed-by: sla, allwin Contributed-by: mikael.a...

RFR: 8023651: j.l.r.Constructor.getAnnotatedReceiverType() and j.l.r.Constructor.getAnnotatedReturnType() for inner classes return incorrect result

Hi, Please review this fix for reflection for type annotations. The problem was that the reflection side expected a different encoding of nested (static) inner classes. Also the type of the receiver parameter for a inner class constructor should be the outer this. I have added some test cases f

JDK 8 (initial) RFR for JDK-8005294 : Consider default methods for additions to AnnotatedElement

Hello, Please review my initial implementation changes for JDK-8005294 : Consider default methods for additions to AnnotatedElement http://cr.openjdk.java.net/~darcy/8005294.0/ (Specification aspects of the review are taking place over at http://mail.openjdk.java.net/pipermail/enhance