On 10/30/2013 02:57 AM, Joe Darcy wrote:
On 10/29/2013 06:37 PM, Joe Darcy wrote:
Hi Joel,
On 10/29/2013 09:20 AM, Joel Borggrén-Franck wrote:
Hi Joe, Peter,
On 29 okt 2013, at 07:09, Joe Darcy wrote:
Your comments, along with some spec refinements from the other
OpenJDK list, are reflecte
Hi
Please review:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8027316-distinct-unordered/webrev/
The fix ensures that the distinct operation, for a parallel stream, is not a
full barrier if the upstream is unordered (and not already distinct, otherwise
it is a no-op).
Thanks,
Paul.
On 10/30/13 1:14 AM, huizhe wang wrote:
I updated the webrev to also fix the error message that showed the
actual number of attributes parsed rather than the limit itself.
http://cr.openjdk.java.net/~joehw/jdk8/8024378/webrev/
Thanks,
Joe
Hi Joe,
Looks good to me. I see another change, which
Hi Stuart,
This looks great.
Best regards
-- daniel (not a reviewer)
On 10/30/13 2:57 AM, Stuart Marks wrote:
Hi all,
Please review the following specification change to deprecate RMI/JRMP
static stubs. This change consists only of deprecations and spec
clarifications. There are no actual AP
On 10/30/13 3:06 AM, Mandy Chung wrote:
I have added the test cases to verify dependency on javax.crypto and
also a class in a SE package (javax.activity in the test case). The
updated webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/
Looks good. What's the purpose of
Changeset: 5d1bda6c1fe3
Author:jbachorik
Date: 2013-10-30 14:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d1bda6c1fe3
8027058: sun/management/jmxremote/bootstrap/RmiBootstrapTest.sh Failed to
initialize connector
Summary: Dynamically discover the first available port i
Hello,
I'd like to repeat my proposal to add @FunctionalInterface to
java.util.concurrent.Callable,
since that looks like a "pure" functional interface to me!
On 30/10/2013 02:06, Mandy Chung wrote:
I have added the test cases to verify dependency on javax.crypto and
also a class in a SE package (javax.activity in the test case). The
updated webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/webrev.01/
Mandy
I've looked through the upd
Please review this fix to correct the JDK8 build Configure script.
It reverts a recent change to common/autoconf/basics.m4 that was causing a
build failure on Solaris.
Bug: https://bugs.openjdk.java.net/browse/JDK-8027567
Webrev: http://cr.openjdk.java.net/~vinnie/8027567/
Changeset: 9a5048dc7c0d
Author:chegar
Date: 2013-10-30 14:41 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a5048dc7c0d
8026880: NetworkInterface native initializing code should check fieldID values
Reviewed-by: alanb
! src/solaris/native/java/net/NetworkInterface.c
! src/w
Hi Vinnie,
I have seen this issue myself, kind of funny ;-)
...
configure: Found GNU make at /java/devtools/i386/bin/make, however this
is not version 3.81 or later. (it is: GNU Make 3.81). Ignoring.
configure: error: Cannot find GNU make 3.81 or newer! Please put it in
the path, or add e.g. M
Changeset: b04b124418d8
Author:ykantser
Date: 2013-10-30 13:44 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b04b124418d8
809: Intermittent test failures in sun/tools/jstatd
Reviewed-by: sla, egahlin, jbachorik, allwin
+ test/lib/testlibrary/jdk/testlibrary/Asserts.java
On 10/30/2013 3:54 AM, Daniel Fuchs wrote:
On 10/30/13 3:06 AM, Mandy Chung wrote:
I have added the test cases to verify dependency on javax.crypto and
also a class in a SE package (javax.activity in the test case). The
updated webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/web
On 10/30/2013 7:38 AM, Alan Bateman wrote:
On 30/10/2013 02:06, Mandy Chung wrote:
I have added the test cases to verify dependency on javax.crypto and
also a class in a SE package (javax.activity in the test case). The
updated webrev:
http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8027481/
Thanks Chris.
So reverting to the previous version of builds.m4 will fix this issue on
Solaris but will undo
the fix for 8026528 on Windows. Maybe Eric can advise.
On 30 Oct 2013, at 15:05, Chris Hegarty wrote:
> Hi Vinnie,
>
> I have seen this issue myself, kind of funny ;-)
>
> ...
> co
Changeset: aa91bc6e8480
Author:mchung
Date: 2013-10-30 08:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa91bc6e8480
8027481: jdeps to handle classes with the same package name and correct profile
for javax.crypto.*
Reviewed-by: alanb, dfuchs
! src/share/classes/c
On 10/30/2013 2:58 AM, Daniel Fuchs wrote:
On 10/30/13 1:14 AM, huizhe wang wrote:
I updated the webrev to also fix the error message that showed the
actual number of attributes parsed rather than the limit itself.
http://cr.openjdk.java.net/~joehw/jdk8/8024378/webrev/
Thanks,
Joe
Hi Joe,
Hi Joe,
I think this is all OK
Best
Lance
On Oct 30, 2013, at 11:40 AM, huizhe wang wrote:
>
> On 10/30/2013 2:58 AM, Daniel Fuchs wrote:
>> On 10/30/13 1:14 AM, huizhe wang wrote:
>>> I updated the webrev to also fix the error message that showed the
>>> actual number of attributes parsed rath
It seems the problem is with the grep tool used to parse the version
string. /usr/xpg4/bin/grep doesn't handle '\(3\.8[12]\)\|\(4\.\)' the
same as gnu grep. In jprt it finds /usr/sfw/bin/ggrep which works
better. I will see if I can figure out something that works with both.
/Erik
On 2013-10-
I found a solution that's also more readable. Posting inline since it's
so small a change:
diff -r 4f2011496393 common/autoconf/basics.m4
--- a/common/autoconf/basics.m4
+++ b/common/autoconf/basics.m4
@@ -514,7 +514,7 @@
if test "x$IS_GNU_MAKE" = x; then
AC_MSG_NOTICE([Found potenti
Changeset: 04778b00286a
Author:joehw
Date: 2013-10-30 08:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/04778b00286a
8024378: StAX parser shall support JAXP properties
Reviewed-by: dfuchs, lancea
!
src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerIm
Thanks Erik. We’re seeing the issue in TL so it’d be great to get this fixed
today.
Would you like to take ownership of this issue or shall I push your fix to TL?
On 30 Oct 2013, at 16:00, Erik Joelsson wrote:
> I found a solution that's also more readable. Posting inline since it's so
> small
I'm leaving for the day pretty soon, so feel free to push this to tl if
you have time.
If you do, don't forget to run common/autoconf/autogen.sh and to also
submit the closed generated-configure.
/Erik
On 2013-10-30 17:07, Vincent Ryan wrote:
Thanks Erik. We’re seeing the issue in TL so it’
Sure. I’ll re-run autogen.sh and submit an updated webrev.
Thanks.
On 30 Oct 2013, at 16:15, Erik Joelsson wrote:
> I'm leaving for the day pretty soon, so feel free to push this to tl if you
> have time.
>
> If you do, don't forget to run common/autoconf/autogen.sh and to also submit
> the
On 10/30/2013 12:52 AM, Peter Levart wrote:
On 10/30/2013 02:57 AM, Joe Darcy wrote:
On 10/29/2013 06:37 PM, Joe Darcy wrote:
Hi Joel,
On 10/29/2013 09:20 AM, Joel Borggrén-Franck wrote:
Hi Joe, Peter,
On 29 okt 2013, at 07:09, Joe Darcy wrote:
[snip]
I retract my previous comments
Changeset: 550244957351
Author:mfang
Date: 2013-10-30 09:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/550244957351
6192407: s10_70, ko, s1/dvd, minor misspelling under "Select Software
Localizations"
Reviewed-by: yhuang
! src/share/classes/sun/util/resources/ko/LocaleN
Looks good to me.
In the test,
> Integer one = Stream.iterate(1, i -> i +
> 1).unordered().parallel().distinct().findAny().get();
> assertEquals(one.intValue(), 1);
The implementation is probably make sure this will return 1, but is that what
we spec to do? I sort of think it can have various
The source changes look fine to me, I'm happy to be listed as a reviewer
for this. ( generated-configure.sh, I just assume is ok once
common/autoconf/autogen.sh is run ).
-Chris.
On 30/10/2013 16:24, Vincent Ryan wrote:
Sure. I’ll re-run autogen.sh and submit an updated webrev.
Thanks.
On 3
On 10/30/2013 9:41 AM, Joe Darcy wrote:
Good suggestion; I've made the recommended change:
http://cr.openjdk.java.net/~darcy/8005294.7/
I looked through the change and it looks fine. The change in
AnnotationSupport.java is no longer needed.
Mandy
Looks OK to me.
Thanks for including a comment in the tests. :-)
Mike
On Oct 30 2013, at 02:30 , Paul Sandoz wrote:
> Hi
>
> Please review:
>
> http://cr.openjdk.java.net/~psandoz/tl/JDK-8027316-distinct-unordered/webrev/
>
> The fix ensures that the distinct operation, for a parallel st
On Oct 30, 2013, at 5:54 PM, Henry Jen wrote:
> Looks good to me.
>
Thanks.
> In the test,
>
>> Integer one = Stream.iterate(1, i -> i +
>> 1).unordered().parallel().distinct().findAny().get();
>> assertEquals(one.intValue(), 1);
>
> The implementation is probably make sure this will ret
On 10/30/2013 09:56 AM, Mandy Chung wrote:
On 10/30/2013 9:41 AM, Joe Darcy wrote:
Good suggestion; I've made the recommended change:
http://cr.openjdk.java.net/~darcy/8005294.7/
I looked through the change and it looks fine. The change in
AnnotationSupport.java is no longer needed.
Changeset: 2a714dabb624
Author:jbachorik
Date: 2013-10-30 17:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a714dabb624
8020467: Inconsistency between usage.getUsed() and isUsageThresholdExceeded()
with CMS Old Gen pool
Reviewed-by: mchung, brutisso
! test/java/lang/man
Hi,
On 30 okt 2013, at 18:15, Joe Darcy wrote:
> On 10/30/2013 09:56 AM, Mandy Chung wrote:
>>
>> On 10/30/2013 9:41 AM, Joe Darcy wrote:
>>> Good suggestion; I've made the recommended change:
>>>
>>> http://cr.openjdk.java.net/~darcy/8005294.7/
>>
>> I looked through the change and it looks
Yes, the intent the JSR166 EG had for Callable was "a deferred
computation" in the same way Runnable is "a deferred task".
On 10/30/2013 10:03 AM, Gernot Neppert wrote:
Hello,
I'd like to repeat my proposal to add @FunctionalInterface to
java.util.concurrent.Callable,
since that looks like a "
Changeset: 067355edfbf8
Author:vinnie
Date: 2013-10-30 17:31 +
URL: http://hg.openjdk.java.net/jdk8/tl/rev/067355edfbf8
8027567: JDK 8 build failure: the correct version of GNU make is being rejected
Reviewed-by: chegar, erikj
! common/autoconf/basics.m4
! common/autoconf/gener
Thanks for the review Chris.
For the record, here’s the updated webrev:
http://cr.openjdk.java.net/~vinnie/8027567/webrev.01/
On 30 Oct 2013, at 16:57, Chris Hegarty wrote:
> The source changes look fine to me, I'm happy to be listed as a reviewer for
> this. ( generated-configure.sh, I jus
Changeset: 537fa895fd74
Author:vromero
Date: 2013-10-30 18:09 +
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/537fa895fd74
8027327: jar files related to test test/tools/javac/ExtDirs/ExtDirTest.java
should be removed from the repo
Reviewed-by: ksrini
! test/tools/javac
Changeset: 62a67e0875ff
Author:briangoetz
Date: 2013-10-30 14:12 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/62a67e0875ff
8024930: Re-enable disabled bridging tests
Reviewed-by: psandoz, rfield
! test/tools/javac/lambdaShapes/org/openjdk/tests/separate/Compiler.java
Changeset: 7bc67bed3c14
Author:michaelm
Date: 2013-10-30 18:37 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7bc67bed3c14
8027570: NullPointerException in URLPermission.hashCode()
Reviewed-by: chegar
! src/share/classes/java/net/URLPermission.java
! test/java/net/URLPermiss
PING!
This change has been granted CCC approval. The final version of the webrev is
here:
http://cr.openjdk.java.net/~bpb/6910473/webrev.6/
It would be good to have a definitive JDK 8 Reviewer approval of this, or to
resolve any straggling objections should there be any.
Thanks,
Brian
On Oc
Hi Brian and Dima,
I've looked over the webrev.
The code changes look fine. From a correctness standpoint, the tests
look good; however, I still have concerns about the resource usage even
of the tests that don't try to run with an 8 Gb heap since they do
allocate a single object that is abou
Hi Joe,
So this would be approved provided: 1) "@test" -> "@ test" in the new tests
(add a space between "@" and "test"), and 2) an issue is filed to convert these
back to JTREG tests in JDK 9?
Thanks,
Brian
On Oct 30, 2013, at 12:35 PM, Joe Darcy wrote:
> The code changes look fine. From a
On 10/30/2013 12:42 PM, Brian Burkhalter wrote:
Hi Joe,
So this would be approved provided: 1) "@test" -> "@ test" in the new
tests (add a space between "@" and "test"), and 2) an issue is filed
to convert these back to JTREG tests in JDK 9?
Correct.
Cheers,
-Joe
Thanks,
Brian
On Oct
8024635: Caching MethodType's descriptor string improves lambda linkage
performance
Summary: Better interpreted and compiled performance of operations in
MethodType important to LambdaMetafactory.
Reviewed-by: jrose, twisti, ?
Contributed-by: skuksenko
http://cr.openjdk.java.net/~jrose/8024635/w
On Oct 30, 2013, at 1:12 PM, Joe Darcy wrote:
>> So this would be approved provided: 1) "@test" -> "@ test" in the new tests
>> (add a space between "@" and "test"), and 2) an issue is filed to convert
>> these back to JTREG tests in JDK 9?
>
> Correct.
I have updated the webrev accordingly
h
Changeset: b098ee22aa97
Author:erikj
Date: 2013-10-24 10:43 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b098ee22aa97
8009280: JCE jurisdiction policy files not copied into jdk/lib/security
Reviewed-by: tbell, ihse
! common/makefiles/JavaCompilation.gmk
Changeset: 3c48e11c390
Changeset: d6d8aeb2c2d4
Author:amurillo
Date: 2013-10-19 08:52 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6d8aeb2c2d4
8026928: new hotspot build - hs25-b56
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: 384c92148c68
Author:amurillo
Date: 2013-10-21
Changeset: 110c4fe4c354
Author:erikj
Date: 2013-10-24 10:43 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/110c4fe4c354
8009280: JCE jurisdiction policy files not copied into jdk/lib/security
Reviewed-by: tbell, ihse
! makefiles/BuildJdk.gmk
! makefiles/CompileJavaClasses.gm
Hi All,
Here is a simple change to fix the test failure reported in JDK-8027155.
Due to the code change in JDK-8025128, this test also needs to be updated.
Bug: https://bugs.openjdk.java.net/browse/JDK-8027155
Webrev: http://cr.openjdk.java.net/~dxu/8027155/webrev/
Thanks,
-Dan
Changeset: ddb0b681654a
Author:briangoetz
Date: 2013-10-29 12:31 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddb0b681654a
8027318: Lambda Metafactory: generate serialization-hostile read/writeObject
methods for non-serializable lambdas
Reviewed-by: rfield, psandoz
! src/
Changeset: f731d096530f
Author:wetmore
Date: 2013-10-30 16:49 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f731d096530f
8027526: CheckTipsAndVersions.java failing occasionally
Reviewed-by: mullan, mchung
! test/java/security/Signature/SignatureGetAlgorithm.java
Thumbs up.
Mandy
On 10/30/2013 4:43 PM, Dan Xu wrote:
Hi All,
Here is a simple change to fix the test failure reported in
JDK-8027155. Due to the code change in JDK-8025128, this test also
needs to be updated.
Bug: https://bugs.openjdk.java.net/browse/JDK-8027155
Webrev: http://cr.openjdk.j
Hi Andreas,
Approved; thanks,
-Joe
On 10/29/2013 3:26 AM, Andreas Lundblad wrote:
Hi,
Please review the fix for JDK-8016725 below.
Description:
DefaultMethodModeling.java and Equals.java in
jdk/test/java/lang/reflect/Method interfered with each other since
both tests defines a class named 'A
Changeset: e8894e3224d9
Author:darcy
Date: 2013-10-30 17:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8894e3224d9
8005294: Consider default methods for additions to AnnotatedElement
Reviewed-by: jfranck, plevart, mchung, abuckley, sogoel
! src/share/classes/java/lang/r
Hi Stuart,
Approved; deprecate away!
-Joe
On 10/29/2013 06:57 PM, Stuart Marks wrote:
Hi all,
Please review the following specification change to deprecate RMI/JRMP
static stubs. This change consists only of deprecations and spec
clarifications. There are no actual API changes (classes, met
Changeset: 1ea1b24c1a04
Author:smarks
Date: 2013-10-30 18:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ea1b24c1a04
8023863: deprecate support for statically-generated stubs from RMI (JRMP)
4449028: exportObject() javadoc should specify behavior for null socket
factorie
Changeset: 0734e1584d9d
Author:bpb
Date: 2013-10-30 17:45 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0734e1584d9d
6910473: java.math.BigInteger.bitLength() may return negative "int" on large
numbers
8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infini
58 matches
Mail list logo
