Looks good to me
Stephen
On 17 Dec 2013 06:48, "roger riggs" wrote:
> Please review this change to explicitly document the behavior of
> equals and hashCode for java.time.chrono concrete types.
> The behavior is not changed.
>
> (They had been documented but the javadoc was not inherited during a
Looks fine AFAICT
Stephen
On 17 Dec 2013 09:23, "roger riggs" wrote:
> Hi Sherman,
>
> Thanks for the comments, corrected and updated the webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-time-serialization/
>
> On 12/16/2013 1:00 PM, Xueming Shen wrote:
>
>> On 12/16/2013 09:02 AM, roger rig
I've updated the documentation per Paul's suggestions. Specifically, in
addition to the existing put() and get() methods the new Map methods
putIfAbsent()
getOrDefault()
compute()
computeIfAbsent()
computeIfPresent()
merge()
are all documented to perform a single access of the entry (assuming th
On 12/14/2013 9:38 AM, Peter Levart wrote:
Hi,
Daniel reminded me of a couple of issues the 4th revision of the patch
would have when backporting to 7u. So here's another variant that
tries to be more backport-friendly:
http://cr.openjdk.java.net/~plevart/jdk8-tl/jul.Handler.sealed/webrev.05
Hi Sherman,
Thanks for the comments, corrected and updated the webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-serialization/
On 12/16/2013 1:00 PM, Xueming Shen wrote:
On 12/16/2013 09:02 AM, roger riggs wrote:
Please review these changes to java.time serialization.
The format of the
Hi,
This is a quick fix for a whitespace buffer that was not adjusted
properly in one of the two cases. The buffer, whiteSpaceLookup, is
filled in two cases and adjusted properly the 2nd time. The code is
moved into a method storeWhiteSpace so that it's shared for the 1st case
as well.
Not
On 12/16/2013 09:02 AM, roger riggs wrote:
Please review these changes to java.time serialization.
The format of the serialized data is unchanged; deserialization
uses readObject instead of readResolve to flag invalid values.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-serializatio
Roger,
The source changes look good to me, and in line with the Serialization proxy
idiom (ignoring the Externalizable stuff).
-Chris.
On 16 Dec 2013, at 17:02, roger riggs wrote:
> Please review these changes to java.time serialization.
> The format of the serialized data is unchanged; deser
Please review this change to explicitly document the behavior of
equals and hashCode for java.time.chrono concrete types.
The behavior is not changed.
(They had been documented but the javadoc was not inherited during an
earlier refactoring).
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-t
Please review these changes to java.time serialization.
The format of the serialized data is unchanged; deserialization
uses readObject instead of readResolve to flag invalid values.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-time-serialization/
Thanks, Roger
Hi Mandy,
Looks good.
cheers
/Joel
On 2013-12-14, Mandy Chung wrote:
> Hi Peter,
>
> Thanks for the review. This code path is critical in this core
> reflection implementation and I want to resolve this bug with a low
> risk fix in an update release and thus the proposed fix. Thanks
> for t
On 12/14/13 6:38 PM, Peter Levart wrote:
Hi,
Daniel reminded me of a couple of issues the 4th revision of the patch
would have when backporting to 7u. So here's another variant that tries
to be more backport-friendly:
http://cr.openjdk.java.net/~plevart/jdk8-tl/jul.Handler.sealed/webrev.05/
Th
12 matches
Mail list logo