Hi,
Thank you all for the reviews! I have prepared a final version that has
incorporated all the comments.
http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-vfinal/
- Ioi
On 8/9/14, 1:02 AM, Ioi Lam wrote:
Hi,
Thanks a lot to everyone for the very useful comments. I have updated
the w
Hi,
The real problem would be fields strikelist, graybits and the like not
inUse per se. They are not volatile either and there might not be proper
happens before edges, so they could easily be updated out of order. For
instance getGrayBits may throw a NPE.
IMO, inUse is overall a poor choice to
Sounds like a good idea. I’ll add something in the next version of the patch.
Thanks,
Brian
On Aug 12, 2014, at 6:42 AM, Paul Benedict wrote:
> I'd like to propose some sort of comment (non-javadoc) preceding the methods
> to explain the pattern. Without the institutional day-to-day knowledge
Hi,
Please find below a fix for:
8054480: Test java/util/logging/TestLoggerBundleSync.java fails:
Unexpected bundle name: null
This test has been reported to fail from time to time with the
following stack:
java.lang.RuntimeException: Unexpected bundle name: null
at TestLogger
Hi Ioi and Mandy,
Please see comments below.
On 08/11/2014 11:10 PM, Ioi Lam wrote:
On 8/11/14, 4:01 PM, Mandy Chung wrote:
On 8/11/14 2:15 PM, Ioi Lam wrote:
http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v3/
I would like to avoid adding private methods for VM to call
as fewer as p
On 11/08/2014 22:29, Brian Burkhalter wrote:
On Aug 11, 2014, at 1:10 PM, Alan Bateman wrote:
This looks okay except SSLSocketImpl#isLayered (not clear why the override is
needed).
This is needed as it may be required to instrument
sun.security.ssl.SSLSocketImpl.closeSocket() in which the k
(Please forgive me if this should go to the AWT list or somesuch. It
seems to me like this is not really a graphics-related issue, but one
of Java concurrency.)
This is in JDK9, sun.font.GlyphList. There is a non-volatile boolean
inUse, and it is not always written in a synchronized block. It i
I'd like to propose some sort of comment (non-javadoc) preceding the
methods to explain the pattern. Without the institutional day-to-day
knowledge, I don't think it is apparent to an outside reader why these
methods are crafted as such.
The comment can be as simple as:
// wrap native call to allo
fyi,
There's a Perl script normalizer.pl that detects/fixes most of the
simple tab/white space issues.
The script is in the /make/scripts/normalizer.pl
Roger
On 8/12/2014 3:48 AM, Andrej Golovnin wrote:
Hi Otávio,
I think you should fix the indentation in a lot of classes. You use the
tab-c
Hi,
it appears I might have been unclear that this was a (re-)review request
- not a request
for approval - since we need to make the public API introduced in
8041972 private for 8u.
After some confusion on my part, it turns out the appropriate place to
re-review these
changes are actually
Interesting, language features for modules, won't necessarily involve
ClassLoader's (my assumptions were based on existing systems) although you'd
expect modules to have their own ProtectionDomain.
An alternative to isolates, is separate processes with jvm class sharing
enabled.
I'll keep an e
No TAB, no \r, and no trailing space are hard requirements enforced by jcheck.
Otherwise it's only styles, including 4-space-indentation. "{" at the end of a
line, 8-space wrap indentation...
--Max (an Oracle dev)
On Aug 12, 2014, at 15:48, Andrej Golovnin wrote:
> As far as I know we should
Hi Otávio,
I think you should fix the indentation in a lot of classes. You use the
tab-character for the indentation. As far as I know we should use the space
character for the indentation in the JDK sources (Oracle devs feel free to
correct me if I'm wrong. And it would be really nice if the styl
On 12/08/2014 4:29 PM, Ioi Lam wrote:
On 8/10/14, 7:16 PM, David Holmes wrote:
Hi Ioi,
We seem to have lost core-libs-dev so I added them back.
A couple of minor follow ups.
On 9/08/2014 6:02 PM, Ioi Lam wrote:
Hi,
Thanks a lot to everyone for the very useful comments. I have updated
the
14 matches
Mail list logo
