RFR: 8059206: (tz) Support tzdata2014i

Hi, Can I ask for review of new tzdata - 2014i integration fix to JDK9. One change in this release is that new time zone was added - "Pacific/Bougainville". The localized names still needs to be translated - the appropriate comment was added to JDK-8057004. Testing results: JPRT tests: jdk_o

Re: Request for review/advice from langtools team Re: Covariant overrides on the Buffer Hierarchy redux

Hi Paul, Sorry for the delay. So if I understand this correctly, we get 4 warnings (and because of -Werror a build failure) in langtools when compiling vs Jdk 9, but need the casts because we bootstrap with Jdk 8. Looks good to me but I would prefer if you filed a bug on me for Jdk 10 for rem

Re: RFR: 8059206: (tz) Support tzdata2014i

Hi Aleksej, src/java.base/share/classes/sun/util/resources/TimeZoneNames*.java: +{"Pacific/Bougainville", new String[] {"Bougainville Standard Time", "BST", + "Bougainville Summer Time", "BST", +

Re: RFR: 8059206: (tz) Support tzdata2014i

Hi Masayoshi, Thank you for the review. Ok, I will change the "Summer Time" to "Daylight Time" before the push. Best Regards, Aleksej On 10/28/2014 04:46 PM, Masayoshi Okutsu wrote: Hi Aleksej, src/java.base/share/classes/sun/util/resources/TimeZoneNames*.java: +{"Pacific/Bougainvi

Re: Lower overhead String encoding/decoding

On 26/10/2014 21:10, Richard Warburton wrote: : Thanks for taking the time to look at this - most appreciated. I've pushed the latest iteration to http://cr.openjdk.java.net/~rwarburton/string-patch-webrev-8/ . I think this i

Re: Lower overhead String encoding/decoding

On 10/28/2014 03:52 PM, Alan Bateman wrote: On 26/10/2014 21:10, Richard Warburton wrote: : Thanks for taking the time to look at this - most appreciated. I've pushed the latest iteration to http://cr.openjdk.java.net/~rwarburton/string-patch-webrev-8/

RFR 8062288: Minor re-org of java/sql testing tests

Hi all, I need a reviewer for this change which moves the java/sql testng tests into its own directory making it consistent with the javax/sql testing tests I also kicked off a jtreg which just completed successfully Webrev is at http://cr.openjdk.java.net/~lancea/8062288/webrev.00/ Best Lanc

Re: RFR 8062288: Minor re-org of java/sql testing tests

Hi Lance, Looks good to me. Best, Joe On 10/28/2014 10:12 AM, Lance Andersen wrote: Hi all, I need a reviewer for this change which moves the java/sql testng tests into its own directory making it consistent with the javax/sql testing tests I also kicked off a jtreg which just completed suc

Re: RFR 8062288: Minor re-org of java/sql testing tests

Hi Lance, Looks fine. Roger On 10/28/2014 1:12 PM, Lance Andersen wrote: Hi all, I need a reviewer for this change which moves the java/sql testng tests into its own directory making it consistent with the javax/sql testing tests I also kicked off a jtreg which just completed successfully

RFR 9: 8048124: Read hijra-config-umalqura.properties as a resource

Hi, One change missing from the previous webrev is to copy the Hijrah calendar data to its location as a resource. It is in the top level repository, so it was not covered by the earlier webrev. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-config-8049376-top/ Issue: 8048124:

Re: RFR: 8062194: java.util.jar.Attributes should use insertion-ordered iteration

Xueming, I understand that getting CCC approval is a fair amount of work. At your option, we could leave the spec unchanged and do without CCC, given that Attributes' iteration order has changed in every past release. Or we could split the spec change off as a separate improvement. On Mon, Oct 2

Re: RFR: 8062194: java.util.jar.Attributes should use insertion-ordered iteration

Martin, I can help the CCC, it is fair quick these days given this is a really simple update, just couple days. -Sherman On 10/28/2014 11:09 AM, Martin Buchholz wrote: Xueming, I understand that getting CCC approval is a fair amount of work. At your option, we could leave the spec unchanged

Re: RFR: 8062194: java.util.jar.Attributes should use insertion-ordered iteration

On 28/10/2014 18:09, Martin Buchholz wrote: Xueming, I understand that getting CCC approval is a fair amount of work. At your option, we could leave the spec unchanged and do without CCC, given that Attributes' iteration order has changed in every past release. Or we could split the spec change

Re: [9] [8u40] RFR (M): 8059877: GWT branch frequencies pollution due to LF sharing

John, thanks for the feedback! See my answers inline. Updated version: http://cr.openjdk.java.net/~vlivanov/8059877/webrev.02/ The algorithm looks fine, as long as the count is small. (Otherwise we might want to spend effort recompiling the DontInline LF. Yes, the intention is to have it sma

Re: RFR 9: 8048124: Read hijra-config-umalqura.properties as a resource

On 28/10/2014 17:44, roger riggs wrote: Hi, One change missing from the previous webrev is to copy the Hijrah calendar data to its location as a resource. It is in the top level repository, so it was not covered by the earlier webrev. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hijrah-

Re: [9] [8u40] RFR (M): 8059877: GWT branch frequencies pollution due to LF sharing

Good, I'm happy. Reviewed. — John On Oct 28, 2014, at 12:04 PM, Vladimir Ivanov wrote: > John, thanks for the feedback! > See my answers inline.

remote: Permission denied (publickey). -- anyone else getting this

Anyone have an idea as to the following error after pulling a clean workspace. Also getting this on a previous workspace... hg outgoing -v comparing with ssh://lan...@hg.openjdk.java.net/jdk9/dev/jdk running ssh lan...@hg.openjdk.java.net 'hg -R jdk9/dev/jdk serve --stdio' remote: Permission den

Re: RFR (M) 8061651 - Interface to the Lookup Index Cache to improve URLClassPath search time (round 3)

Hi Ioi, This sounds ok. Thanks, Jiangli On 10/27/2014 09:57 PM, Ioi Lam wrote: On 10/27/14, 7:52 PM, Jiangli Zhou wrote: Hi Ioi, I have a question for following code in AppClassLoader.loadClass(). If a class is 'known to not exist' for the AppClassLoader (not in the AppClassLoader and par

RFR 7156085: ArrayIndexOutOfBoundsException throws in UTF8Reader of SAXParser

Hi Joe, I'd like you to do a code review. http://cr.openjdk.java.net/~martin/webrevs/openjdk9/xerces-UTF8Reader-supplementary-characters/ https://bugs.openjdk.java.net/browse/JDK-7156085#comment-13569882 https://issues.apache.org/jira/browse/XERCESJ-1257 As usual, I don't know what I'm doing in

Re: RFR (M) 8061651 - Interface to the Lookup Index Cache to improve URLClassPath search time (round 3)

Ioi, Looks good! Thanks to all who have contributed! A couple of minor comments/questions: 1. jvm.h (hotspot and jdk) All three APIs talk about loader_type, but the code uses loader. 2. Launcher.java To the best of my understanding - the call to findLoadedClass does not require synchronizing

Re: RFR (M) 8061651 - Interface to the Lookup Index Cache to improve URLClassPath search time (round 3)

Hi Karen, I haven't been tracking the details of this and am unclear on the overall caching strategy however ... On 29/10/2014 8:49 AM, Karen Kinnear wrote: Ioi, Looks good! Thanks to all who have contributed! A couple of minor comments/questions: 1. jvm.h (hotspot and jdk) All three APIs

Re: RFR (M) 8061651 - Interface to the Lookup Index Cache to improve URLClassPath search time (round 3)

On 10/28/14, 7:34 PM, David Holmes wrote: Hi Karen, I haven't been tracking the details of this and am unclear on the overall caching strategy however ... On 29/10/2014 8:49 AM, Karen Kinnear wrote: Ioi, Looks good! Thanks to all who have contributed! A couple of minor comments/questions:

Re: RFR (M) 8061651 - Interface to the Lookup Index Cache to improve URLClassPath search time (round 3)

On 29/10/2014 4:04 PM, Ioi Lam wrote: On 10/28/14, 7:34 PM, David Holmes wrote: Hi Karen, I haven't been tracking the details of this and am unclear on the overall caching strategy however ... On 29/10/2014 8:49 AM, Karen Kinnear wrote: Ioi, Looks good! Thanks to all who have contributed!