Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Daniel Fuchs
Hi Bernd, I will make some measurements - I don't expect that the cost of the new accessor will matter much as from my early measurements [1] it's not that far from the cost of System.currentTimeMillis(). best regards, -- daniel [1]

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Daniel Fuchs
Hi Peter, On 2/14/15 10:36 AM, Peter Levart wrote: Hi Daniel, The millis property in your proposal just changes one part of LogRecord's notion of time (it doesn't change/reset the nanoAdjustment part). From compatibility standpoint, your ptoposal is changing the semantics of millis

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Daniel Fuchs
Hi Stephen, Thanks a lot for your feedback, it is really helpful! On 2/14/15 11:28 AM, Stephen Colebourne wrote: Elements of the date/time handling here don't really work. Logging is essentially a UTC only problem, using a time-zone is slow and unecessary. This indicates that all uses of

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Daniel Fuchs
Hi Jason, On 2/13/15 10:57 PM, Jason Mehrens wrote: Daniel, In the XMLFormatter.format you can get rid of the double call to getNanoAdjustment() since you have stored the value in the local var 'nanos'. Thanks for spotting that, will do. For the new XMLFormatter constructor what do you

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Peter Levart
Hi Daniel, The millis property in your proposal just changes one part of LogRecord's notion of time (it doesn't change/reset the nanoAdjustment part). From compatibility standpoint, your ptoposal is changing the semantics of millis property. Previously millis was the sole property of

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Stephen Colebourne
Elements of the date/time handling here don't really work. Logging is essentially a UTC only problem, using a time-zone is slow and unecessary. This indicates that all uses of ZonedDateTime should be replaced with either Instant or an OffsetDateTime using ZoneOffset.UTC. Any string format should

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Peter Levart
Hi Daniel, On 02/14/2015 01:38 PM, Daniel Fuchs wrote: Hi Peter, On 2/14/15 10:36 AM, Peter Levart wrote: Hi Daniel, The millis property in your proposal just changes one part of LogRecord's notion of time (it doesn't change/reset the nanoAdjustment part). From compatibility standpoint,

Re: JEP 238: Multi-Version JAR Files

2015-02-14 Thread Peter Levart
On 02/12/2015 09:52 PM, Paul Sandoz wrote: Hi In connection with the JEP there is also a design document to help the discussion: http://cr.openjdk.java.net/~psandoz/jdk9/MultiVersionJar-8u60-9-design.md We are especially interesting in hearing feedback from library developers, tool/IDE

Re: RFR: 8072645: java.util.logging should use java.time to get more precise time stamps

2015-02-14 Thread Peter Levart
On 02/14/2015 04:33 PM, Peter Levart wrote: Well, internally I think it should be stored as an Instant. So you don't have to reconstruct Instant objects at each call to getInstant(). Serialization of LogRecord is not a frequent requirement, so the overhead should be moved to it, rather than

Re: JEP 238: Multi-Version JAR Files

2015-02-14 Thread Peter Levart
On 02/12/2015 09:52 PM, Paul Sandoz wrote: Hi In connection with the JEP there is also a design document to help the discussion: http://cr.openjdk.java.net/~psandoz/jdk9/MultiVersionJar-8u60-9-design.md Hi Paul, Thinking about this proposal, I can't escape the feeling that the design

RFR: JDK-8073152: Update Standard/ExtendedCharsets to work with module system

2015-02-14 Thread Xueming Shen
Hi, Please help review the changes for JDK-8073152 Issue: https://bugs.openjdk.java.net/browse/JDK-8073152 Webrev: http://cr.openjdk.java.net/~sherman/8073152/webrev/ This change is to re-organize how the standard and extended charsets repository are built for the jdk/jre images. Before

Re: RFR: 8073093: AARCH64: C2 generates poor code for ByteBuffer accesses

2015-02-14 Thread Dean Long
On 2/14/2015 12:07 AM, Andrew Haley wrote: On 02/13/2015 10:52 PM, Dean Long wrote: My understanding is that whether or not aarch64 allows unaligned accesses is based on a system setting, so this change is too simplistic. Disabling unaligned access would be a really perverse thing to do, and

Re: RFR: 8073093: AARCH64: C2 generates poor code for ByteBuffer accesses

2015-02-14 Thread Andrew Haley
On 02/14/2015 12:09 AM, John Rose wrote: We also need Unsafe.getIntMisaligned, etc., which wire through to whatever second-best mechanism the platform offers. Indeed. I'm intending to prototype a design for those next week. OK? Andrew.

Re: RFR: 8073093: AARCH64: C2 generates poor code for ByteBuffer accesses

2015-02-14 Thread Andrew Haley
On 02/13/2015 10:52 PM, Dean Long wrote: My understanding is that whether or not aarch64 allows unaligned accesses is based on a system setting, so this change is too simplistic. Disabling unaligned access would be a really perverse thing to do, and I suspect that GCC and glibc already assume