Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

On Apr 8, 2015, at 7:52 PM, David Holmes wrote: > > Meta-question: if this is non-Java code then what does/should "simpleName" > even mean? "Returns the simple name of the underlying class as given in the > source code." If there is no (java) source code does this have any meaning? > Should it

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

Hi Remi, On 9/04/2015 4:10 PM, Rémi Forax wrote: Hi David, The problem is that j.l.i.MethodType.toString uses getSimpleName and j.l i.WrongMethodTypeException uses MethodType.toString. So if getSimpleName returns a blank string, you destroy the debuggability of any invokedynamic/methodhandle c

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

Hi David, The problem is that j.l.i.MethodType.toString uses getSimpleName and j.l i.WrongMethodTypeException uses MethodType.toString. So if getSimpleName returns a blank string, you destroy the debuggability of any invokedynamic/methodhandle calls. regards, Rémi Le 9 avril 2015 04:52:15 CEST

Re: [9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

Hi Vladimir, On 9/04/2015 1:41 AM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8057919/webrev.00/jdk http://cr.openjdk.java.net/~vlivanov/8057919/webrev.00/hotspot https://bugs.openjdk.java.net/browse/JDK-8057919 The logic to compute simple name (Class.getSimpleName()) for inner

Re: RFR: 8076549: Update JAX-WS RI integration to latest version (2.2.11-b150402.1412)

Hi, Can I kindly ask for a review of this JAX-WS update? With Best Regards, Aleksej On 04/03/2015 06:20 PM, Aleksej Efimov wrote: Hello, Can I have a review for a JDK9 bulk update of JAX-B/WS from upstream projects. Webrev: http://cr.openjdk.java.net/~aefimov/8076549/9/00/ More details in is

Re: RFR: 8076090: jimage extract + recreate broken again

Forwarding to core-libs-dev for review (bcc jdk9-dev) On 4/8/2015 11:02 AM, Jim Laskey (Oracle) wrote: The fix addresses problem with the jimage tool rebuilding meta data on windows systems (\ in path.) Including new test to verify that jimage tool does successfully extract and recreate. JBS

[9] RFR (S): Class.getSimpleName() should work for non-JLS compliant class names

http://cr.openjdk.java.net/~vlivanov/8057919/webrev.00/jdk http://cr.openjdk.java.net/~vlivanov/8057919/webrev.00/hotspot https://bugs.openjdk.java.net/browse/JDK-8057919 The logic to compute simple name (Class.getSimpleName()) for inner/nested/local classes is tightly coupled with Java naming s

[9] Review Request: 8076264 [macosx] Launching app on MacOSX requires enclosing class

Hello. Please review the fix for jdk 9. After the fix we clear all errors caused by getCanonicalName() on the mainclass and leave JAVA_MAIN_CLASS_ empty. This empty case will be handled in the NSApplicationAWT.m. Plus small cleanup suggested in the bug report(jstring->jclass). Bug: https://bug

Re: [9] RFR (M): 8057967: CallSite dependency tracking scales devastatingly poorly

Any volunteers to review VM part? Latest webrev: http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/hotspot/ http://cr.openjdk.java.net/~vlivanov/8057967/webrev.01/jdk/ Best regards, Vladimir Ivanov On 4/1/15 11:56 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8057967

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Thanks! On 07.04.2015 20:13, Roger Riggs wrote: Thanks, looks fine. Roger On 4/7/2015 1:00 PM, alexander stepanov wrote: Hello Roger, Thank you for the notes, fixed: http://cr.openjdk.java.net/~avstepan/8039440/webrev.01/src/java.corba/share/classes/org/omg/CORBA/portable/package.html.udiff

Re: Review Request for 8039440: Tidy warnings cleanup for org/omg

Thanks! On 07.04.2015 20:48, Lance Andersen wrote: Hi Alexander, InTypeCode.java you might want to use {@code} vs so that you do not have to use > < Otherwise it is OK Best Lance On Apr 7, 2015, at 1:00 PM, alexander stepanov > wrote: Hello Roger

Re: native2ascii be removed from JDK?

Note that the JDK build itself uses native2ascii for the man pages. I have no idea why or if this is actually necessary. Here is the code: define install-ja-manpage $(MKDIR) -p $(@D) $(CAT) $< \ | $(NATIVE2ASCII) -encoding eucJP \ | $(SED) 's/@@VERSION@@