Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

Hi Alan, Sherman, Thanks for taking a look! I understand and totally agree with improving module separation. Another quick test was just done on my Linux box for all available locales, and found several more which will cause ExceptionInInitializerError on JDK9, but worked with JDK8. ar_AE ar_A

RFR(s): 8132206: move ScanTest.java into OpenJDK

Hi all, Please review this small change to add a test for java.util.Scanner into OpenJDK. This test was inadvertently omitted from OpenJDK when the regression tests were migrated into the open. Bug: https://bugs.openjdk.java.net/browse/JDK-8132206 Webrev: http://cr.openjdk.ja

Re: SelectableChannels and Process API

Hi Peter, Sorry to have taken so long to get back to this thread on SelectableChannels for process I/O. Working on the pipelines idea got me back to thinking about this proposal. One bit of spec/implementation to address is the state of the In/Out/Err streams of the process when using Redire

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

yes, gb18030 needs to be in linux/unix std-solaris/unix as well. -sherman On 07/28/2015 09:51 AM, Volker Simonis wrote: Hi Jonathan, Alan, this is a known problem and we've already discussed it intensively. Please have a look at: 8081674: EmptyStackException at startup if running with extend

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

Volker, If fine with you I will re-open the gb18080 specific bug and fix it by adding the gb18030 into stdcs-solaris/linux and aix (does aix have a gb18030 locale?). And keep the 8087171 open for a more general solution, such as using iconv for a "IconvCharset" -Sherman On 07/28/2015 09:51

Re: RFR(XS): 8132475 : The commands in the modular images are executable by the owner only (once again)

On 28/07/2015 19:32, Volker Simonis wrote: Hi, could you please review this tiny change: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132475/ https://bugs.openjdk.java.net/browse/JDK-8132475 After "8080511: Refresh of jimage support" the executable commands in jdk/bin and jre/bin are only

Re: RFR(XS): 8132475 : The commands in the modular images are executable by the owner only (once again)

Hi Volker, Looks good, and thanks for the test. Roger On 7/28/2015 2:32 PM, Volker Simonis wrote: Hi, could you please review this tiny change: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132475/ https://bugs.openjdk.java.net/browse/JDK-8132475 After "8080511: Refresh of jimage suppo

RFR(XS): 8132475 : The commands in the modular images are executable by the owner only (once again)

Hi, could you please review this tiny change: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132475/ https://bugs.openjdk.java.net/browse/JDK-8132475 After "8080511: Refresh of jimage support" the executable commands in jdk/bin and jre/bin are only executable by the file owner. This means tha

Re: RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

On 7/28/2015 10:32 AM, Daniel Fuchs wrote: On 28/07/15 19:20, huizhe wang wrote: Hi Daniel, On 7/28/2015 8:22 AM, Daniel Fuchs wrote: Hi, Please find below a fix for yet another cleanup for jaxp: Thanks for yet another cleanup! And, there is a lot more to come :-) 8130059: jaxp: Investi

Re: RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

On 28/07/15 19:20, huizhe wang wrote: Hi Daniel, On 7/28/2015 8:22 AM, Daniel Fuchs wrote: Hi, Please find below a fix for yet another cleanup for jaxp: Thanks for yet another cleanup! And, there is a lot more to come :-) 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/inte

Re: RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

Hi Daniel, On 7/28/2015 8:22 AM, Daniel Fuchs wrote: Hi, Please find below a fix for yet another cleanup for jaxp: Thanks for yet another cleanup! And, there is a lot more to come :-) 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java https:/

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

Hi Jonathan, Alan, this is a known problem and we've already discussed it intensively. Please have a look at: 8081674: EmptyStackException at startup if running with extended or unsupported charset https://bugs.openjdk.java.net/browse/JDK-8081674 and: 8087161: Fails to start up initialize syst

Re: ProcessBuilder support for pipelines

On Tue, Jul 28, 2015 at 2:36 AM, Florian Weimer wrote: > On 07/28/2015 02:48 AM, Martin Buchholz wrote: > > In the past, when I contemplated doing this, I generally thought that > there > > wasn't enough value in such a feature for the effort, given that one can > > start a subprocess shell that

Re: RFR: JDK-8062849 -- Optimize EnumMap.equals

Looks good. It would be slightly more consistent with original author's style to write if (em.size != size) On Tue, Jul 28, 2015 at 9:14 AM, Steve Drach wrote: > Please review the following simple fix for the issue reported in > https://bugs.openjdk.java.net/browse/JDK-8062849 < > https://bugs

RFR: JDK-8062849 -- Optimize EnumMap.equals

Please review the following simple fix for the issue reported in https://bugs.openjdk.java.net/browse/JDK-8062849 . - # HG changeset patch # User sdrach # Date 143193 25200 # Fri Jul 24 15:33:13 2015 -0700 # Node ID e57b1

RfR - 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java

Hi, Please find below a fix for yet another cleanup for jaxp: 8130059: jaxp: Investigate removal of com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java https://bugs.openjdk.java.net/browse/JDK-8130059 http://cr.openjdk.java.net/~dfuchs/webrev_8130059/webrev.00/ EnvironmentChe

Re: RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

On 28/07/2015 10:50, 陆传胜(传胜) wrote: Hello, The issue was found on one of my Linux boxes which uses locale zh_CN.GB18030 by default, a simple patch was made to fix it, may I have it reviewed ? webrev: http://cr.openjdk.java.net/~luchsh/webrev-8132459/ bug: https://bugs.openjdk.java.n

Re: One more minor addition to ProcessBuilder

Hi David, ok, it seems very minimal if implemented like a writeable file: public static abstract class Redirect { +private static final File nullFile = AccessController.doPrivileged( +(PrivilegedAction) () -> { +return new File((System.getPropert

Re: ProcessBuilder support for pipelines

Hi Martin, Doing the plumbing for this is pretty minimal as you've noticed from the webrev. No native code is modified and it extends the existing redirect logic. I think this is pretty useful and cheap and will work across platforms. I use emacs every day too but somehow it seems dated. Roge

Re: Custom spliterator for Collections.nCopies(n, obj).stream()

Hi Tagir, I would agree with you out about changing to use unordered() except that it is a List that is returned, whose Spliterator is specified to report ORDERED. I don’t particular want to add a special spliterator for this case to avoid some profile pollution. Will it not just push the pollu

Re: RFR: JDK-8114832 it.next on ArrayList throws wrong type of Exception after remove(-1)

On 27 Jul 2015, at 20:53, Martin Buchholz wrote: > > > On Mon, Jul 27, 2015 at 1:19 AM, Paul Sandoz wrote: > > My guiding principle here was that argument validation should not result in > side-effects. Thus the state of a collection should remain unchanged if an > exception is thrown due to

Re: References to non-existing methods in java.util.stream comments

On 28 Jul 2015, at 10:48, Tagir F. Valeev wrote: > Hello! > > Although it's not the part of public API, there are references to > non-existing methods in SliceOps.java and Streams.java: > > http://hg.openjdk.java.net/jdk9/dev/jdk/file/f160dec9a350/src/java.base/share/classes/java/util/stream/S

RFR: 8132459: ExceptionInInitializerError from 'java -version' on Linux under zh_CN.GB18030 locale

Hello,   The issue was found on one of my Linux boxes which uses locale zh_CN.GB18030 by default, a simple patch was made to fix it, may I have it reviewed ?   webrev: http://cr.openjdk.java.net/~luchsh/webrev-8132459/ bug: https://bugs.openjdk.java.net/browse/JDK-8132459   JBS seems to be

Re: ProcessBuilder support for pipelines

On 07/28/2015 02:48 AM, Martin Buchholz wrote: > In the past, when I contemplated doing this, I generally thought that there > wasn't enough value in such a feature for the effort, given that one can > start a subprocess shell that supports pipelines. Does this feature pull > its weight? Feeding

References to non-existing methods in java.util.stream comments

Hello! Although it's not the part of public API, there are references to non-existing methods in SliceOps.java and Streams.java: http://hg.openjdk.java.net/jdk9/dev/jdk/file/f160dec9a350/src/java.base/share/classes/java/util/stream/SliceOps.java#l141 // @@@ OOMEs will occur for LongStream.longs()

Custom spliterator for Collections.nCopies(n, obj).stream()

Hello! Current implementation of Collections.nCopies().stream() is as follows: http://hg.openjdk.java.net/jdk9/dev/jdk/file/f160dec9a350/src/java.base/share/classes/java/util/Collections.java#l5066 public Stream stream() { return IntStream.range(0, n).mapToObj(i -> element); } @Override pub

Re: ProcessBuilder support for pipelines

I find this kinda cute. Seems like a reasonable addition to me. -Chris. On 27 Jul 2015, at 15:48, Roger Riggs wrote: > On most operating systems, creating pipelines of processes is simple and > direct. > That same function is missing from the Java Process support and can be > provided by > ja

Re: One more minor addition to ProcessBuilder

On 28 Jul 2015, at 01:28, Martin Buchholz wrote: > Seems reasonable. Agreed. -Chris. > On Mon, Jul 27, 2015 at 11:09 AM, David M. Lloyd > wrote: > >> Roger & co.: >> >> Since you're already on the topic of manipulating pipes, I thought I'd >> mention one very small yet very useful potentia