Re: [PING] Potential infinite waiting at JMXConnection#createConnection

Hi Jaroslav and core-libs-dev, Thank Jaroslav for your kindness! For core-libs-dev members, links the information about this issue. * details of problem http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-April/002152.html * patch

RFR:8146489:@since tag missed

Hi all, Please review a fix for BugID - https://bugs.openjdk.java.net/browse/JDK-8146489 Issue - while fixing JDK8142936 , I forgot to add @since 9 tag. webrev - http://cr.openjdk.java.net/~ntv/8146489/webrev.00/ -- Thanks and Regards, Nadeesh TV

Re: RFR 9: JDK-8146028 : Common Cleaner for finalization replacements in java.base

Hi Roger, Some early feedback: I see that prior to your changes, MeteredStream.close() would be called by finalize. This will no longer be the case after http://cr.openjdk.java.net/~rriggs/webrev-cleaning-finalizers/index.html I see that MeteredStream has a subclass (KeepAliveStream) that

Re: RFR:8146489:@since tag missed

+1 Thanks, Roger On 1/5/2016 2:17 PM, Lance Andersen wrote: +1 On Jan 5, 2016, at 2:08 PM, nadeesh tv wrote: Hi all, Please review a fix for BugID - https://bugs.openjdk.java.net/browse/JDK-8146489 Issue - while fixing JDK8142936 , I forgot to add

RFR: JDK-8068803:Performance of LocalDate.plusDays could be better

Hi all, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8068803 web rev : http://cr.openjdk.java.net/~ntv/8068803/webrev.00/ Special thanks for Stephen for providing the source code patch -- Thanks and Regards, Nadeesh TV

Re: RFR: JDK-8068803:Performance of LocalDate.plusDays could be better

Hi Nadeesh, LocalDate.java: +1374: For the most common case of dom > 0 && <= 28, I would have explicitly and immediately returned the new LocalDate. if (dom > 0 && dom <= 28) { return LocalDate.of(year, month, (int) dom); } ... TCKLocalDate.java: - Since the test_plusDays_normal is

Re: RFR:8146489:@since tag missed

+1 On Jan 5, 2016, at 2:08 PM, nadeesh tv wrote: > Hi all, > Please review a fix for > BugID - https://bugs.openjdk.java.net/browse/JDK-8146489 > Issue - while fixing JDK8142936 , I forgot to add @since 9 tag. > webrev -

Re: RFR 9: JDK-8146028 : Common Cleaner for finalization replacements in java.base

On 5 Jan 2016, at 18:24, Roger Riggs wrote: > The follow on work to adding the Cleaner is to replace uses of finalization > with uses of the Cleaner. > For the 'easy' cases in the java.base module, it is useful to introduce a > private Cleaner for the > java.base

RFR 9: JDK-8146028 : Common Cleaner for finalization replacements in java.base

The follow on work to adding the Cleaner is to replace uses of finalization with uses of the Cleaner. For the 'easy' cases in the java.base module, it is useful to introduce a private Cleaner for the java.base module. It is proposed to be held weakly, to allow it to terminate on a lightly

RFR [9] 8146484: Examine sun.misc.MessageUtils

sun.misc.MessageUtils provides low-level access for writing “error” messages to stdout and stderr. It is, effectively, used in just one place in the JDK, String coding, when the specific encoding is not available. Since this is the only usage, the minimal functionality required by String coding

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

On 6 Jan 2016, at 04:20, David Holmes wrote: > Hi Chris, > > Hotspot comment change looks okay.:) Thanks David. > I see a lot of hotspot tests that include > > @modules java.base/sun.misc > > but I don't understand why it is present in the few cases I looked at eg:

Re: RFR [9] 8145544: Move sun.misc.VM to jdk.internal.misc

Hi Chris, Hotspot comment change looks okay.:) I see a lot of hotspot tests that include @modules java.base/sun.misc but I don't understand why it is present in the few cases I looked at eg: hotspot/test/gc/g1/TestShrinkAuxiliaryData15.java so not sure when it needs to be converted to

Re: RFR [9] 8146484: Examine sun.misc.MessageUtils

Looks good. On 1/5/16 9:28 PM, Chris Hegarty wrote: sun.misc.MessageUtils provides low-level access for writing “error” messages to stdout and stderr. It is, effectively, used in just one place in the JDK, String coding, when the specific encoding is not available. Since this is the only

Re: [PING] PoC for JDK-4347142: Need method to set Password protection to Zip entries

Yuji, I'm not convinced that the ZipCryption is a public interface we'd like to expose, at least for now, given the proprietary nature of the "strong encryption" defined by PKWARE. As I said in my previous email, it might be desired to hide the "passwd/encryption" support for the

Re: RFR 7183985: Class.getAnnotation() throws an ArrayStoreException when the annotation class not present

Hi Liam, I think you need to do skipMemberValue the correct number of times so that the cursor in buf is correct, or? I modified your test slightly to provoke an AnnotationTypeMismatchException that I think shouldn't be there: @AnnotationAnnotation({@ClassArrayAnnotation({Missing.class,

Re: RFR 9: JDK-8146028 : Common Cleaner for finalization replacements in java.base

Hi Daniel, webrev updated to revert changes to MeteredStream as too risky. http://cr.openjdk.java.net/~rriggs/webrev-cleaning-finalizers/index.html On 1/5/2016 1:45 PM, Daniel Fuchs wrote: Hi Roger, Some early feedback: I see that prior to your changes, MeteredStream.close() would be called

Re: RFR 9: JDK-8146028 : Common Cleaner for finalization replacements in java.base

Hi Chris, On 1/5/2016 2:33 PM, Chris Hegarty wrote: On 5 Jan 2016, at 18:24, Roger Riggs wrote: The follow on work to adding the Cleaner is to replace uses of finalization with uses of the Cleaner. For the 'easy' cases in the java.base module, it is useful to