Re: RFR 9: 8145459 Cleaner - use Reference.reachabilityFence

> On 20 Jan 2016, at 16:14, Roger Riggs wrote: > > Please review this update to the Cleanable implementations to use > Reference.reachabilityFence: > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-fence-8145459/ > Yay, +1 Paul.

Re: Moving sun.misc.VM

On 20/01/2016 15:18, Sanne Grinovero wrote: Hello all, while testing latest Java 9 build 9-ea+101-2016-01-13-182959.javare.4276.nc with some popular OSS libraries, I noticed that sun.misc.VM is gone and this will cause some issues. This is causing compilation failures of type "cannot find

Re: RFR - 8132734: java.util.jar.* changes to support multi-release jar files

Hi, This is a repeat of the RFR I sent last Wed (Jan 13). CCC had some suggestions to improve the code that was previously approved during review. As a consequence, I had to make significant changes to the API, and I believe the code need further review. Please review the latest iteration

Re: RFR: JDK-8144144 - ORB destroy() leaks filedescriptors after unsuccessful connection

Hi Mark, SelectorImpl.java: line 125, could you use a 2 arg method call to dprint. It'll print the stacktrace instead : dprint(".close: selector.close: " + t); --> dprint(".close: selector.close", t); The "while (!isClosed()) " change introduces a new hot lock on closed variable.

Re: RFR 9: 8145459 Cleaner - use Reference.reachabilityFence

> On Jan 20, 2016, at 7:14 AM, Roger Riggs wrote: > > Please review this update to the Cleanable implementations to use > Reference.reachabilityFence: > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-fence-8145459/ +1 Mandy

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

On 01/20/2016 03:19 PM, Peter Levart wrote: > So if we add 32k (or whatever the max. possible > overhead of TLS is) to the existing 32k, that should be the default for > reaper thread. I'm not sure how many thread-local variables are possible in theory, but I suspect it's unlimited. In

Re: RFR: JDK-8144144 - ORB destroy() leaks filedescriptors after unsuccessful connection

Hi, an update has been made to the webrev http://cr.openjdk.java.net/~msheppar/8144144/webrev.03/ an anomaly was found in the select loop of the SelectorImpl.run() method some defensive programming, for selector null references, have been added, also. regards Mark On 08/01/2016 17:49,

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi, On 01/20/2016 03:09 PM, Roger Riggs wrote: Hi David, I read an old description; I was expecting the value of the property to be the stack size for the reaper. That would allow more control and less waste when it needed to be overridden. Set it to zero if the default size is desired.

Re: Ephemerons

Hi Peter, This is interesting and useful for cases when key/value in a reference chain cycle. This seems worth exploring for a future release. I don’t have any cycle to study this in depth and begin any discussion unfortunately at this time. Have you tried prototype Ephemerons with

Re: Moving sun.misc.VM

Hi! How about: int findIntegerCacheHighPropValue() { int test = 128; // minimum mandated by JLS is 127 while (Integer.valueOf(test) == Integer.valueOf(test)) { test++; } return test - 1; } Since this runs through and hits the cache until the last step, it should be

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi Peter, David, on serviceability-dev [1], was of the opinion that a simple increase would be too temporary. Roger [1] On 1/20/2016 10:19 AM, Peter Levart wrote: Hi, On 01/20/2016 03:09 PM, Roger Riggs wrote: Hi David, I read an old description; I was expecting the value of the

Moving sun.misc.VM

Hello all, while testing latest Java 9 build 9-ea+101-2016-01-13-182959.javare.4276.nc with some popular OSS libraries, I noticed that sun.misc.VM is gone and this will cause some issues. This is causing compilation failures of type "cannot find symbol". Similarly the same projects are using

Re: Moving sun.misc.VM

Hi Claes, excellent idea, I'll point them to this thread. Sanne - Original Message - > Hi! > > How about: > > int findIntegerCacheHighPropValue() { > int test = 128; // minimum mandated by JLS is 127 > while (Integer.valueOf(test) == Integer.valueOf(test)) { >

Re: GNU-style options for the Jar Tool

On 19/01/2016 16:54, Chris Hegarty wrote: GNU-style options for Jar Tool Prompted by the impending addition of new options for both multi-release jars and jigsaw, it became immediately obvious that we were running out of single characters that could be used to represent these new options. I'd

Re: RFR 8065076/9, test/java/net/SocketPermission/SocketPermissionTest.java failed intermittently

On 20 Jan 2016, at 06:36, Chris Hegarty wrote: > Felix, > > On 14 Jan 2016, at 06:07, Felix Yang wrote: > >> Hi all, >> please review the fix for >> test/java/net/SocketPermission/SocketPermissionTest.java, which fails >> frequently with

RFR 9: 8145459 Cleaner - use Reference.reachabilityFence

Please review this update to the Cleanable implementations to use Reference.reachabilityFence: Webrev: http://cr.openjdk.java.net/~rriggs/webrev-fence-8145459/ Thanks, Roger

Re: RFR:8146218: Producing streams in java.time?

I'm happy with the logic and specification of this proposal. I think it will be a useful addition. I'll let the Oracle team chime in to do a further review. thanks Stephen On 16 January 2016 at 13:31, Tagir F. Valeev wrote: > Hello! > > Thanks for review! Here's the

Re: GNU-style options for the Jar Tool

Looks good! I suggest we use -h (in addition to or instead of -?) for help. I believe saying "GNU-style" means the boolean short options (e.g. -t, -v) can be combined (like -tv) to specify multiple actions, but maybe the

Re: Moving sun.misc.VM

Hello, thanks for clarifying about some APIs being considered "critical". No, I'm not seeing lots of usage: actually just one instance so far so it should be possible to patch already with minimal impact. I'm understanding that this API will be hidden. Will there be an alternative? In this case

Re: RFR 9: 8145459 Cleaner - use Reference.reachabilityFence

On 20 Jan 2016, at 15:14, Roger Riggs wrote: > Please review this update to the Cleanable implementations to use > Reference.reachabilityFence: > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-fence-8145459/ Looks good to me Roger. -Chris. > Thanks, Roger >

[9u-dev] 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

Hi All, Please review my fix related to java doc. MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods- MethodHandles.Lookup.findSpecial() throws IllegalAccessException if the target method is static. Bug link- https://bugs.openjdk.java.net/browse/JDK-8138578

[9u-dev] 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods

Hi All, Please review my fix related to java doc. MethodHandles.Lookup.findVirtual() Javadoc fails to consider private methods of an interface. MethodHandles.Lookup.findVirtual() throws IllegalAccessException if the method MH is being created for is private and declared in an interface.

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi David, I read an old description; I was expecting the value of the property to be the stack size for the reaper. That would allow more control and less waste when it needed to be overridden. Set it to zero if the default size is desired. Roger On 1/20/2016 12:05 AM, David Holmes wrote: