RFR: 8160954: (spec) Runtime.Version regex and $PRE/$OPT issues

Hi. Please review changes to address the following closely related bugs: 8160954: (spec) Runtime.Version regex and $PRE/$OPT issues https://bugs.openjdk.java.net/browse/JDK-8160954 8148822: (spec) Regex in Runtime.Version and JEP 223 should match https://bugs.openjdk.java.net/bro

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

Hi, Thanks for the comments.. Webrev's updated in place with comments so far. (Including David's and Amy's) http://cr.openjdk.java.net/~rriggs/webrev-reflection-factory-8164908/ http://cr.openjdk.java.net/~rriggs/webrev-reflection-factory-iiop-8164908/ On 10/20/2016 8:21 AM, Alan Bateman w

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

Hi Amy, Thanks for the suggestions. I will fix them in the next update. I've had some issues with port in use errors and am looking for best practices in starting the servers and their cleanup. Roger On 10/20/2016 11:54 AM, Amy Lu wrote: On 10/20/16 11:32 PM, Amy Lu wrote: On 10/20/16 3:5

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

Hi David, Thanks for the reminder, I'll include readObjectNoData in the next update. (fyi, readObject, readObjectNoData, and writeObject must be private methods.) Roger On 10/20/2016 9:12 AM, David M. Lloyd wrote: On 10/19/2016 02:59 PM, Roger Riggs wrote: The support in sun.reflect.Refle

Re: RFR: jsr166 jdk9 integration wave 12

> On 19 Oct 2016, at 19:33, Martin Buchholz wrote: > > > > On Wed, Oct 19, 2016 at 3:44 PM, Paul Sandoz > wrote: > >> On 18 Oct 2016, at 13:58, Martin Buchholz > > wrote: >> >> Latest webrev defers potential new methods: >>/* TO

Re: RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de,de_DE,en_US.

Looks good, Rachna. Naoto On 10/20/16 1:27 AM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names and D

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

On 10/20/16 11:32 PM, Amy Lu wrote: On 10/20/16 3:59 AM, Roger Riggs wrote: The support in sun.reflect.ReflectionFactory for custom serialization, such as IIOP input and output streams, is being expanded beyond the necessary constructor of a serializable class to include access to the private m

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

On 10/20/16 3:59 AM, Roger Riggs wrote: The support in sun.reflect.ReflectionFactory for custom serialization, such as IIOP input and output streams, is being expanded beyond the necessary constructor of a serializable class to include access to the private methods readObject, writeObject, read

Re: [9] RfR: 8165271: Fix use of reflection to gain access to private fields

>> Please review the new patch version: >> http://cr.openjdk.java.net/~ddehaven/8165271/jdk.1/ >> > > Looks okay but I think the new interface should be named > “JavaNetURLClassLoaderAccess” (matching “URLClassLoader") I originally had that but changed it to look more consistent with the other

Re: RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de,de_DE,en_US.

+1 Looks fine On 10/20/2016 5:06 AM, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 10/20/2016 5:27 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.0

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

On 10/19/2016 02:59 PM, Roger Riggs wrote: The support in sun.reflect.ReflectionFactory for custom serialization, such as IIOP input and output streams, is being expanded beyond the necessary constructor of a serializable class to include access to the private methods readObject, writeObject, rea

Re: RFR: jsr166 jdk9 integration wave 12

Ah, I see. Thanks for answering my questions Martin. Sounds like there's no real benefit then to using guava-testlib in this changeset instead of CollectionTest. And even if the benefit of using it was considered to be high enough in the future, it would probably need its own JSR, since I presume

Re: RFR 9: 8164908: ReflectionFactory support for IIOP and custom serialization

On 19/10/2016 20:59, Roger Riggs wrote: The support in sun.reflect.ReflectionFactory for custom serialization, such as IIOP input and output streams, is being expanded beyond the necessary constructor of a serializable class to include access to the private methods readObject, writeObject, rea

Re: RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de,de_DE,en_US.

Looks good to me. Masayoshi On 10/20/2016 5:27 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names

RFR 8167646: Better invalid FilePermission

Please review the code change at http://cr.openjdk.java.net/~weijun/8167646/webrev.00/ A new flag invalid is added so invalid FilePermissions (invalid Path) do not equal or imply or is implied by anything else except for itself. Thanks Max

RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de,de_DE,en_US.

Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names and Day names one by one, as they can be duplicate. Thanks, Rachna