Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Hi Paul, Good idea. Although the downside is the test will depend on java.management and jdk.management modules, I think it's acceptable. Also disable to run ParallelPrefix.java in concurrency. Please check the new webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.01/ Thank you -Haml

Re: RFR 8181104 Fix specs for updateAndGet and related methods

Looks good! + * accesses are guaranteed to be bitwise atomic only for references + * and primitive values of at most 32 bits, and impose no observable I might sneak in another "for" before "primitive". And of course, some year we should have a real updated memory model ... On Mon, Jun 12, 201

RFR 8181104 Fix specs for updateAndGet and related methods

Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8181104-updateAndGet-atomicty-ordering/webrev/index.html This patch fixes two spec issues: 1) j.u.concurrent.atomic.* classes now defer to VarHandles and package doc was removed. This inadvertently removed a clause about the memory order effects

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

I'm hoping Xueming will review as well. +char asciiCheck; +for (asciiCheck = 0, p = str; *p != '\0'; p++) { +asciiCheck |= *p; +} +len = (p - str); Probably conversion from ptrdiff_t to int needs a cast. Someday we might need to worry about input string longer than 2^31,

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

Hi Martin, thanks for reviewing! On 2017-06-12 22:14, Martin Buchholz wrote: +/* Optimized for char set UTF-8 */ "charset" is a (poor misnomer!) jargon term, not two words. I got that from the existing use of "char set" in this file, but will fix it in all places. --- +for (b = str

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Hi Roman, Overall looks OK. A couple of minor comments - JAXBContext for methods such as createValidator() I would suggest adding the @Deprecated annotation - jdk.xml.bind and jdk.xml.ws have been updated via http://hg.openjdk.java.net/jdk9/dev/jaxws/rev/0d797e800441

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

Hi Chris, I haven't noticed your email and have already pushed 8181761. from my point of view, FileUtils depending on Platform class is not a bug, but having lots of seemed to be unrelated @build action is a bug, I added your comment to 8181915

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

+/* Optimized for char set UTF-8 */ "charset" is a (poor misnomer!) jargon term, not two words. --- +for (b = str[len]; b != '\0'; len++, b = str[len]) { +if (isAscii && b & 0x80) { +isAscii = JNI_FALSE; +} +} I would write this more like const signed char *

RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

Hi again, after an embarrassing attempt at using HotSpot's modified UTF-8 utilities as a drop-in implementation for real UTF-8 a few weeks ago, I've exploredvarious better (read: actually working) alternatives. While I've experimented with a few different implementations[1], my favored approach

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Hi Hamlin, Do you know if it is possible to adjust the array sizes based on max memory thresholds? For example in the os.maxMemory is less than 2g then omit the LARGE_ARRAY_SIZE from the test (assuming that reduces the memory pressure, which it likely should). Paul. > On 12 Jun 2017, at 02:3

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 12/06/17 15:04, Alan Bateman wrote: ... For now, yes, I think these are okay. As part of the clean-up then it would be good to update FileUtils to not use Platform and that would avoid needing to build jdk.test.lib.Platform in several of these tests. I wrote the original FileUtils. Why w

Re: RFR(M) : 8181761: add explicit @build actions for jdk.test.lib classes in all :tier2 tests

On 12/06/2017 07:09, Igor Ignatyev wrote: Hi Alan, I've filed https://bugs.openjdk.java.net/browse/JDK-8181915 to clean up w/ this mess w/ dependencies in testlibrary classes. just to double check, can I consider this fix and the fixes for tier1[1-2], tier3[3-4] reviewed by you? [1] htt

Re: JDK 10 RFR of JDK-8181394: Refactor shell test java/nio/file/Files/walkFileTree/find.sh to java

On 12/06/2017 09:35, Amy Lu wrote: On 6/7/17 11:04 AM, Amy Lu wrote: On 6/6/17 9:49 PM, Alan Bateman wrote: http://cr.openjdk.java.net/~amlu/8181394/webrev.01 CreateFileTree is also used by other tests, no change. This looks much better. At some point we might decide to remove the cleanUp

(10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8179242 webrev: http://cr.openjdk.java.net/~mli/8179242/webrev.00/ Thank you -Hamlin the test takes about 700M on linux 64, so propo

Re: JDK 10 RFR of JDK-8181395: Refactor several java/nio locale related shell tests to java

On 6/7/17 2:14 PM, Amy Lu wrote: webrev: http://cr.openjdk.java.net/~amlu/8181395/webrev.00/ Hi, Alan Is this fine to go? Thanks, Amy On 6/9/17 12:46 AM, Amy Lu wrote: On 6/8/17 10:48 PM, Alan Bateman wrote: On 07/06/2017 16:14, Amy Lu wrote: Defaul.java System.out.println(Charset.default

Re: JDK 10 RFR of JDK-8181394: Refactor shell test java/nio/file/Files/walkFileTree/find.sh to java

On 6/7/17 11:04 AM, Amy Lu wrote: On 6/6/17 9:49 PM, Alan Bateman wrote: http://cr.openjdk.java.net/~amlu/8181394/webrev.01 CreateFileTree is also used by other tests, no change. This looks much better. At some point we might decide to remove the cleanUp method as it can often be useful to le

(10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181912 webrev: http://cr.openjdk.java.net/~mli/8181912/webrev.00/ Thank you -Hamlin

(10) RFR of JDK-8181478,Refactor java/io shell tests to plain java tests

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181478 webrev: http://cr.openjdk.java.net/~mli/8181478/webrev.00/ Thank you -Hamlin