Hi,
forwarding this RFR to awt-dev. Please have a look.
Thanks
Christoph
From: Baesken, Matthias
Sent: Freitag, 30. Juni 2017 16:59
To: core-libs-dev@openjdk.java.net
Cc: Langer, Christoph
Subject: RFR: 8183286 : Some java/awt and javax/swing tests miss headful jtreg
Hi Sean,
Thank you for your comments.
I fixed the copyright and updated webrev:
http://cr.openjdk.java.net/~horii/8182743/webrev.03/
> * The bug ID referenced in mail/webrev links is wrong. It should be
> 8182743 ?
Yes, they should be 8182743. I fixed both.
Regards,
Ogata
Seán Coffey
Hello,
This review would be better conducted on awt-dev and swing-dev.
Thanks,
-Joe
On 6/30/2017 7:59 AM, Baesken, Matthias wrote:
Hello all ,
could you please review the following small change.
Some java/awt and javax/swing tests miss the headful jtreg keyword
The change JDK-8129822
Hi Roger,
looks good. Reviewed from my side.
Best regards
Christoph
From: Roger Riggs [mailto:roger.ri...@oracle.com]
Sent: Freitag, 30. Juni 2017 17:03
To: Langer, Christoph ; Core-Libs-Dev
Subject: Re: RFR 10 8183019: Diagnostics for
Hi Tony,
thanks for your interest in the OpenJDK AIX port. The AIX port has
been contributed by SAP in collaboration with our colleagues from IBM.
It is based on SAP's internal, commercially licensed SAP JVM which is
in productive use since more than 10 years.
We (from SAP) do nightly builds and
Hi,
I am one of the maintainers of the BullFreeware web-site where RPMs of
OpenSource packages for AIX are available (for free):
http://www.bullfreeware.com .
I'd like to know:
- what is the status of this port of OpenJDK on AIX (is it usable in
production ?),
- where are the sources and
Hi Christoph,
Thanks for the review.
webrev updated in place:
http://cr.openjdk.java.net/~rriggs/webrev-onexit-8183019/
On 6/30/2017 2:24 AM, Langer, Christoph wrote:
Hi Roger,
the change looks good overall.
One thing that I probably don't fully understand:
Line 265: while
Hello all ,
could you please review the following small change.
Some java/awt and javax/swing tests miss the headful jtreg keyword
The change JDK-8129822 ( https://bugs.openjdk.java.net/browse/JDK-8129822 )
introduced a jtreg keyword to mark tests as requiring a "headful" (as opposed
to
Ogata,
minor comments from me.
* The bug ID referenced in mail/webrev links is wrong. It should be
8182743 ?
* The copyright change in Charset-X-Coder.java.template is the wrong
format. You can simply replace 2013 with 2017.
Regards,
Sean.
On 29/06/17 19:49, Kazunori Ogata wrote:
Hi
Hi Roger,
the change looks good overall.
One thing that I probably don't fully understand:
Line 265: while (blines.isEmpty() && A_alive == A.isAlive()) {
Isn't this a bit dangerous for the case that A isn't alive any more, also
wasn't at the time A_alive was initialized and blines is empty
10 matches
Mail list logo