Re: RFR 8176838: Remove :compact1, :compact2. :compact3, :needs_jre test groups.

On 16/11/2017 17:20, Alexandre (Shura) Iline wrote: Hi. Please take a look on suggested change of removing obsolete test groups. Bug: https://bugs.openjdk.java.net/browse/JDK-8176838 Webrev: http://cr.openjdk.java.net/~shurailine/8176838/webrev.01 Looks good (and great to see this going away a

Re: Faster Math ?

Hello, Some context first: - Marlin renderer is now the default JDK & JFX renderer. Please consider improving the performance of following 2 Math functions: cbrt, acos. - I work for the public research in astrophysics by making software for astronomy as java desktop apps (javaws + scientific compu

RFR: 8189102: All tools should support -?, -h and --help

Hi, please review this change. I also filed a CSR for this: http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8189102 CSR: https://bugs.openjdk.java.net/browse/JDK-8191477 See the webrev for a detailed description of the changes.

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

On 17/11/2017 02:18, Xueming Shen wrote: Hi, Please help review the change for JDK-8189611. issue: https://bugs.openjdk.java.net/browse/JDK-8189611 webrev: http://cr.openjdk.java.net/~sherman/8189611/webrev Just a few initial comments/questions on the API additions: 1. getRealName is very wel

Re: RFR(XS): 8191442: Regression in LambdaFormBuffer.replaceFunctions

Looks good. Best regards, Vladimir Ivanov On 11/17/17 2:54 AM, Claes Redestad wrote: Hi, in JDK-8184777, we accidentally changed behavior of replaceFunctions from testing identity to testing equality, causing a small startup regression on some sensitive benchmarks in the process[1]. Patch

Re: RFR(XS): 8191442: Regression in LambdaFormBuffer.replaceFunctions

Thanks for reviewing! /Claes On 2017-11-17 13:52, Vladimir Ivanov wrote: Looks good. Best regards, Vladimir Ivanov On 11/17/17 2:54 AM, Claes Redestad wrote: Hi, in JDK-8184777, we accidentally changed behavior of replaceFunctions from testing identity to testing equality, causing a small

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

On 11/17/17, 3:35 AM, Alan Bateman wrote: On 17/11/2017 02:18, Xueming Shen wrote: Hi, Please help review the change for JDK-8189611. issue: https://bugs.openjdk.java.net/browse/JDK-8189611 webrev: http://cr.openjdk.java.net/~sherman/8189611/webrev Just a few initial comments/questions on the

RFR 8180437 Remaining renames of CAS misnomer "swap" => "set"

Please review a minor cleanup of internal naming: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8180437-cas-swap-to-set/webrev/ Paul.

RFR: 8066870 Add Readable::transferTo(Appendable)

Hi Roger and Alan, I incorporated the latest feedback using version 1) from this latest post: http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-November/050004.html The actual webrev is here: http://cr.openjdk.java.net/~reinhapa/reviews/8066870/webrev.00 -Patrick

Re: RFR: 8189102: All tools should support -?, -h and --help

Goetz, I understand why you might want to ensure that a basic set of help options is supported, but I don't understand why that justifies removing older options, like "-help" for many tools. In addition, I notice the CSR says: *Compatibility Risk Description:*

Re: RFR 8180437 Remaining renames of CAS misnomer "swap" => "set"

Looks good to me! On Fri, Nov 17, 2017 at 9:48 AM, Paul Sandoz wrote: > Please review a minor cleanup of internal naming: > > http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8180437-cas- > swap-to-set/webrev/ > > Paul. >

Re: RFR: JDK-8189611: JarFile versioned stream and real name support

On 11/17/2017 08:53 AM, Xueming Shen wrote: 3. Is ZipFile.entryNameStream really needed? Just asking because zf.stream().map(ZipEntry::getName) is possible today. It's not a "must" for sure. The motivation behind this is that my observation of most normal use scenario inside JDK is that only

Re: RFR: 8189102: All tools should support -?, -h and --help

JShell changes — The code change is fine. The help change in the properties file is not consistent with the other items, note:--help-extra, -X Print help on… so this should be: —help, -h, -? Or, if there is a tool-wide standard, then the —help-extra entry should be chang

8181175 Stream.concat behaves like terminal operation

Hi, Please review this small specification classification for Stream.concat: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8181175-concat-eager-binding/webrev/src/java.base/share/classes/java/util/stream/Stream.java.sdiff.html A CSR will be created. I decided to call out that Stream.concat bind

Re: [10] RFR 6354947: [Fmt-*] DecimalFormat ignores FieldPosition settings on input, contrary to Javadocs

+1 Naoto On 11/16/17 10:52 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-6354947 Bug: https://bugs.openjdk.java.net/browse/JDK-6354947 Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191014 Fix: Clarified handling of t

Re: 8181175 Stream.concat behaves like terminal operation

Hi Paul, The normative text about binding to the source and subsequent modifications to the source possibly not being reflected in the stream makes sense. I'm having trouble understanding the API note though. What does "optimal" mean? What about concatenating multiple streams would not be opt

Re: RFR(m): 8177290 add copy factory methods for unmodifiable List, Set, Map

Late to the party, but these lines rub me the wrong way: @return the new {@code List} @return the new {@code Set} @return the new {@code Map} The word "new" is a loaded term, which usually means (or can be easily mistaken to mean) that a new object identity is guaranteed. Thus, "new" shouldn't b

Re: RFR(m): 8177290 add copy factory methods for unmodifiable List, Set, Map

On Nov 3, 2017, at 1:26 AM, Patrick Reinhart wrote: > >> >> On 11/1/2017 4:29 PM, Patrick Reinhart wrote: >>> In this case I would prefer a non static copyOf() method on the list >>> to create a unmodifiable list/set/map, where the optimal factory >>> method can be called. This would also solve