Re: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4

On 4.6.2018 19:40, mandy chung wrote: Hi Jan, On 5/31/18 2:11 AM, Jan Lahoda wrote: Hi, I'd like to upgrade the JOpt Simple library we are using to version 5.0.4. Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 Complete webrev: http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/compl

Re: RFR JDK-8066709 Make some JDK system properties read only

On 04/06/2018 20:59, Roger Riggs wrote: Hi Alan, Updated webrev in place: http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709/ The splitting of the note into @apiNote and @implNote mostly looks good. I think it should be "cached by the Java virtual machine" rather than "cached in

Re: RFR JDK-8200530: '\r' is not supported as "newline" in java.util.jar.Manifest.

Attributes.java:380 nit - assign c at decl - only test len if decremented >> byte c; if ((c = lbuf[--len]) != '\n' && c != '\r') { throw new IOException("line too long"); } if (len > 0 && lbuf[len-1] == '\r') { -

RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

Hi All, Native memory allocation for DBBs is tracked in java.nio.Bits, but that only includes what the user thinks they are allocating. When the VM adds extra memory to the allocation amount this extra bit is not represented in the Bits total. A cursory glance shows, minimum, that we round th

Re: RFR: JDK-8202788: Explicitly reclaim cached thread-local direct buffers at thread exit

Hey Alan, Any thoughts on this? (with apologies for the ping) Tony — Tony Printezis | @TonyPrintezis | tprinte...@twitter.com On May 30, 2018 at 5:16:44 PM, Peter Levart (peter.lev...@gmail.com) wrote: I thought there would be some hint from Alan about which of the two paths we should ta

Re: RFR JDK-8066709 Make some JDK system properties read only

Hi Stuart, On 6/4/2018 9:52 PM, Stuart Marks wrote: On 6/4/18 6:32 AM, Roger Riggs wrote: Please review a change to make the values of java.home, user.home, user.dir, and user.name effectively read-only for internal use.  The values are cached during initialization and the cached values are

Re: RFR JDK-8066709 Make some JDK system properties read only

Hi Max, On 6/4/2018 7:24 PM, Weijun Wang wrote: Hi Roger Thanks for the explanation. Another question: Before this change, a SecurityException might be thrown when getProperty() is called, does you new code simulate this behavior? Or in these cases this is unnecessary? Many of the usages wer

Re: RFR JDK-8066709 Make some JDK system properties read only

Hi Lance, The "unless otherwise specified" part is important so reworeded as: * Changing any standard system property may have unpredictable results * unless otherwise specified. Thanks, Roger On 6/4/2018 4:39 PM, Lance Andersen wrote: Hi Roger, In System.java — changing a

Re: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4

On 31/05/18 10:11, Jan Lahoda wrote: Hi, I'd like to upgrade the JOpt Simple library we are using to version 5.0.4. Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 Complete webrev: http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/ Delta webrev only showing (all) JDK cha

Re: RFR JDK-8066709 Make some JDK system properties read only

Hi Alan, On 6/5/2018 2:19 AM, Alan Bateman wrote: On 04/06/2018 20:59, Roger Riggs wrote: : Are the changes to SocksSocketImpl correct? I may have missed something but the original called System.getProperty("user.dir") in a privileged block so I'm wondering if getUserNameChecked is needed.

Re: RFR JDK-8066709 Make some JDK system properties read only

Hi Alan, On 6/5/2018 5:06 AM, Alan Bateman wrote: On 04/06/2018 20:59, Roger Riggs wrote: Hi Alan, Updated webrev in place: http://cr.openjdk.java.net/~rriggs/webrev-static-property-8066709/ The splitting of the note into @apiNote and @implNote mostly looks good. I think it should be "cached

Re: RFR JDK-8200530: '\r' is not supported as "newline" in java.util.jar.Manifest.

Thanks Jim! webrev has been updated as suggested. http://cr.openjdk.java.net/~sherman/8200530/webrev -sherman On 06/05/2018 05:17 AM, Jim Laskey wrote: Attributes.java:380 nit - assign c at decl - only test len if decremented byte c; if ((c = lbuf[--len]) != '\n'&&

Re: [11] RFR: 8202026 8193552 8204269 : ISO 4217 Amendment #165 # 166 #167 Update

Looks good. Naoto On 6/4/18 11:30 PM, li.ji...@oracle.com wrote: Hi Naoto, I removed the obsoleted currency LTL and LVL from tablea1.txt, added them into otherCodes in ValidateISO4217.java. new webrev as below: http://cr.openjdk.java.net/~ljiang/8202026/webrev.03/ Thanks, Leo On 05/06/201

Re: RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

On Tue, Jun 5, 2018 at 3:46 PM, Adam Farley8 wrote: > Hi All, > > Native memory allocation for DBBs is tracked in java.nio.Bits, but that > only includes what the user thinks they are allocating. > Which is exactly what I would expect as a user... > When the VM adds extra memory to the allocatio

Re: RFR 8203768 : Avoid reallocation in java.base/unix/classes/java/lang/ProcessImpl.java

On Mon, Jun 4, 2018 at 10:31 PM, Ivan Gerasimov wrote: > But suppose available() incorrectly claims that a million bytes are > available, but you only read 10. Then there's a tradeoff - the cost of > reallocation versus the risk that the mostly empty backing array will be > retained for a long t

Re: RFR JDK-8203872: Upgrading JDK with latest available LSR data from IANA

Looks good. Naoto On 6/4/18 10:13 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8203872. Bug: https://bugs.openjdk.java.net/browse/JDK-8203872 Webrev: http://cr.openjdk.java.net/~nishjain/8203872/webrev.01/ Fix: Updated the LSR data to the version 2017-08-15 Regards, Nishit Jain

Re: RFR: JDK-8203891: Upgrade JOpt Simple to 5.0.4

On 6/5/18 12:29 AM, Jan Lahoda wrote: Yes, that would work as well, but there are already invocations like this in the test. So I opted for using "--libs=" + ... and similar, so that both variants are covered by the test. That is fine to keep it as is. The change looks good. Mandy

Re: RFR: 8201608 fix broken links in javax/sql/rowset/package.html and javax/sql/rowset/spi/package.html

Hi Lance, Can the name change be done using  hg rename to preserve the continuity? Also, while you are there, how about converting to {@code...} etc. Thanks, Roger On 6/4/18 7:22 AM, Lance Andersen wrote: Hi, Bug 8201608 highlights a few broken links in javax/sql/rowset/package.html and j

Re: Durations in existing JDK APIs

JDK-8204375: Add TimeUnit#convert(Duration)

Re: RFR(s): 8204243: remove Thread.destroy() and Thread.stop(Throwable)

[adding serviceability-dev] Hi serviceability folks, I'm in the process of removing Thread.destroy() and Thread.stop(Throwable) from the Java SE API. Alan and David have pointed out that there are some cross-references to Thread.stop(Throwable) in the JDWP and JVMTI specs, as well as in the J

Re: RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

On 06/05/2018 12:10 PM, Thomas Stüfe wrote:> On Tue, Jun 5, 2018 at 3:46 PM, Adam Farley8 wrote: Hi All, Native memory allocation for DBBs is tracked in java.nio.Bits, but that only includes what the user thinks they are allocating. Which is exactly what I would expect as a user... I agre

Re: RFR(s): 8204243: remove Thread.destroy() and Thread.stop(Throwable)

Hi Stuart, This all looks fine to me. One minor nit in threadPrimitiveDeprecation.html is whether the new statements you reference a particular Java version? It reads a little oddly to go through all the explanation and then say "Thread.x has been removed". In the spirit of @since you might s

Implementations of PrimitiveIterator.OfInt#forEachRemaining(IntConsumer) doesn't check IntConsumer for null

Hello. I observe that implementations of `forEachRemaining` method inside java.lang.CharSequence doesn't always compare IntConsumer parameter with null. Is there any reason why there is no nonNull check? Performance? Andrey Turbanov.