thanks .. I guess you are deferring review of the rest of it to someone
from swing.
In that Swing area I have a minor update to the fix :
http://cr.openjdk.java.net/~prr/8211031.1 [*]
since I just realised (meaning just thought to check :-)), that the
private method
classExists() is called onl
On 9/20/18, 2:46 PM, Stuart Marks wrote:
On 9/19/18 11:48 AM, Joe Wang wrote:
After much discussion and 10 iterations of reviews, this proposal has
evolved from what was the original isSameContent method to a mismatch
method. API-wise, a compare method was also considered as it looked
like
Hi Sergey,
thanks for your review.
-- Igor
> On Sep 19, 2018, at 2:25 PM, Sergey Bylokhov
> wrote:
>
> Looks fine.
>
> On 19/09/2018 10:18, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8210894/webrev.00/index.html
>>> 1188 lines changed: 252 ins; 591 del; 345 mod;
>> Hi all
On 9/21/18 4:32 AM, Alan Bateman wrote:
On 20/09/2018 21:56, mandy chung wrote:
:
FWIW. It reads to me that the launcher mode should not be set to
LM_CLASS
when parsing -cp option as it does not know the mode until all
options are
parsed. Then set to LM_CLASS if mode == LM_UNKNOWN (if no
Removal of module-info.java.extra is good.
Mandy
On 9/21/18 1:13 PM, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031
webrev: http://cr.openjdk.java.net/~prr/8211031/
Removing some obsolete code which is the reason for a qualified export
from java.base to java.desktop.
Hi Igor,
I think it would be better to postpone this; we currently have at least
two different snapshots of the API in various JDK repo - the one you are
looking at has been added by Paul in order to test condy; Valhalla has
another (slightly tweaked) version to deal with value type support.
Bug: https://bugs.openjdk.java.net/browse/JDK-8211031
webrev: http://cr.openjdk.java.net/~prr/8211031/
Removing some obsolete code which is the reason for a qualified export
from java.base to java.desktop. I also cleaned up some commented out
debugging code.
See the bug evaluation for more det
Oops! I also meant to take the test off of the ProblemList:
test/jdk/ProblemList.txt
*** 515,526
# jdk_instrument
java/lang/instrument/RedefineBigClass.sh
8065756 generic-all
java/lang/instrument/RetransformBigClass.sh
8065756 generic-all
- java/lang/instrument/BootClassPath/Boo
Hi Alan,
Thanks for the response and apologies for failing to notice you had
posted it some days ago (doh!).
Jonathan Halliday has already explained how Red Hat might want to use
this API. Well, what he said, essentially! In particular, this model
provides a way of ensuring that raw byte data is
The example of ISS is a good one. It is analogous to the question of
"when is it right to write a class, and when it is right to write a
function?" And the answer is, of course, "it depends." ISS was an
obvious grouping, but even there there was significant disagreement
during its design abo
Thank you Stephen for your inputs. Based on that, here is the updated webrev
for review :
http://cr.openjdk.java.net/~rpatil/8166138/webrev.02/
Thanks,
Pallavi Sonal.
-Original Message-
From: Stephen Colebourne
Sent: Thursday, September 20, 2018 6:38 PM
To: core-libs-dev
Subject: R
On 20/09/2018 21:56, mandy chung wrote:
:
FWIW. It reads to me that the launcher mode should not be set to LM_CLASS
when parsing -cp option as it does not know the mode until all options are
parsed. Then set to LM_CLASS if mode == LM_UNKNOWN (if not set).
But this requires closer inspection of
Hi James,
It sounds like the project is being very active. Glad to hear that! No matter
how good a mailing list is, in practice, it cannot be the best mailing list for
every topic there is. core-libs-dev is no exception. It's good to see you've
found another way to make progress on the project.
T
- Mail original -
> De: "Alan Bateman"
> À: "Jim Laskey" , "core-libs-dev"
>
> Envoyé: Vendredi 21 Septembre 2018 12:22:42
> Objet: Re: RFR - JDK-8203442 String::transform (Code Review)
> On 18/09/2018 18:52, Jim Laskey wrote:
>> Please review the code for String::transform. The goal is
On 18/09/2018 18:52, Jim Laskey wrote:
Please review the code for String::transform. The goal is to provide a String
instance method to allow function application of custom transformations applied
to an instance of String.
webrev: http://cr.openjdk.java.net/~jlaskey/8203442/webrev/index.html
j
Hi all,
Please help review the changes for JDK-8199776 to JDK8u:-
Master Bug: https://bugs.openjdk.java.net/browse/JDK-8199776
Webrev: http://cr.openjdk.java.net/~rpatil/8199776/webrev.00/
Background:-
We have bug JDK-8197398 fixed in jdk 12 where Files.walkFileTree walk
indefinitel
16 matches
Mail list logo
