Re:

Hi Vladimir, > >> >> The test suite was described in this paper >> >> Jon L. Bentley, M. Douglas McILroy >> “Engineering a Sort Function”, 1993 >> >> I use Java version (a little bit extended), see attachment. >> What you need is to specified sorting classes in IntSorter.java >> and run BentleyBa

Re: RFR JDK-8211051: jdeps usage of --dot-output doesn't provide valid output for modular jar

+1 -Sundar On 15/11/18, 5:42 AM, Mandy Chung wrote: This is a small fix to jdeps --dot-output option that should name the dot file with the filename of the modular JAR rather than its module name. http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8211051/webrev.00/ Thanks Mandy

[12]RFR 8210408: Refactor java.util.ResourceBundle:i18n shell tests to plain java tests

Hello, Please help review the fix for refactor java.util.ResourceBundle:i18n shell tests to plain java tests. Thank you. Shell Tests: test/java/util/ResourceBundle/modules/appbasic2/appbasic2.sh test/java/util/ResourceBundle/modules/xmlformat/xmlformat.sh test/java/util/ResourceBundle/modules/

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi, Does --limit-modules work as intended, are there any tests? With a command such as: jpackager -Djlink.debug=true create-image \     --input out/artifacts \     --output out \     --limit-modules java.base \     --main-jar Hello-jar/Hello.jar \     --class Main It complains that: Exception:

Re: RFR of JDK-8211974,move testlibrary/java/util/jar/CreateMultiReleaseTestJars.java to a separate testlibrary

Hi Hamlin, Although I understand your reasoning, I do share Amy's concerns on doing less than the RFEs ask for (as w/ 8211972). so I'd suggest you to split your patch into 4 separate patches and RFRs, one per original RFE. this won't just return sanity to reviewers and review, reduce chance of

Re: RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

Looks fine to me. P.S. Looks like your doccheck has already started to pay off. > On 15 Nov 2018, at 00:01, Jonathan Gibbons > wrote: > > Please review the removal of two extraneous in HttpClient.java. > > $ hg diff -R open > diff -r 40098289d580 > src/java.net.http/share/classes/java/net/

Re: 6516099: InputStream.skipFully(int k) to skip exactly k bytes

Hi Brent / Daniel, > On Nov 9, 2018, at 4:41 PM, Brent Christian > wrote: > > On 11/9/18 2:04 PM, Brian Burkhalter wrote: >> An updated patch is at >> http://cr.openjdk.java.net/~bpb/6516099/webrev.06/ >> >>

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Brent, On 11/14/2018 06:54 PM, Brent Christian wrote: Hi, Roger * I like Mandy's idea of not combining the cli/VM props and the well-known props into a single array.  Maybe we could then avoid copying between arrays (System.c L166). yes, it would avoid the copy. * The name "Raw" doesn'

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Mandy, On 11/14/2018 05:18 PM, Mandy Chung wrote: Hi Roger, The system property initialization long for a clean up. Thanks for looking at it.  This is a good start.  I think it'd be good to make further improvement. 140 cmdProps = JVM_GetProperties(env); Instead of prepending the predefined

Re: RFR: XXXS: JDK-8213913: Redundant HTML in java.se/module-info.java

+1 Mandy On 11/14/18 4:20 PM, Jonathan Gibbons wrote: Please review the remove of an unnecessary tag from java.se/module-info.java that is showing up in "tidy" reports by doccheck. $ hg diff -R open diff -r 8934429cfb0b src/java.se/share/classes/module-info.java --- a/src/java.se/share/clas

Re: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

Hello Martin. I know your point, but it's default encoding issue. User cannot start OpenJDK JDK9/10/11/12 on ja_JP(IBM29626C) and zh_TW(IBM964) locale on AIX. But IBM964 cannot be used for default encoding in current setting. This fix is really required on OpenJDK for AIX. Ichiroh Takiguchi O

Re: RFR: XXXS: JDK-8213913: Redundant HTML in java.se/module-info.java

+1 > On Nov 14, 2018, at 7:20 PM, Jonathan Gibbons > wrote: > > Please review the remove of an unnecessary tag from > java.se/module-info.java that is showing up in "tidy" reports by doccheck. > > $ hg diff -R open > diff -r 8934429cfb0b src/java.se/share/classes/module-info.java > --- a/src/

RFR: XXXS: JDK-8213913: Redundant HTML in java.se/module-info.java

Please review the remove of an unnecessary tag from java.se/module-info.java that is showing up in "tidy" reports by doccheck. $ hg diff -R open diff -r 8934429cfb0b src/java.se/share/classes/module-info.java --- a/src/java.se/share/classes/module-info.java Wed Nov 14 16:11:21 2018 -0800 +++ b

RFR JDK-8213909: jdeps --print-module-deps should report missing dependences

This patch improves `jdeps --print-module-deps`, `--list-deps` and `--list-reduced-deps` to report missing dependences and also do transitive dependence analysis as the default. Webrev at: http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8213909/webrev.00/ $ jdeps --class-path libs --print-modul

Re: RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

*1 > On Nov 14, 2018, at 7:01 PM, Jonathan Gibbons > wrote: > > Please review the removal of two extraneous in HttpClient.java. > > $ hg diff -R open > diff -r 40098289d580 > src/java.net.http/share/classes/java/net/http/HttpClient.java > --- a/src/java.net.http/share/classes/java/net/http/Ht

RFR JDK-8211051: jdeps usage of --dot-output doesn't provide valid output for modular jar

This is a small fix to jdeps --dot-output option that should name the dot file with the filename of the modular JAR rather than its module name. http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8211051/webrev.00/ Thanks Mandy

Re: RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

+1 -Joe On 11/14/2018 4:01 PM, Jonathan Gibbons wrote: Please review the removal of two extraneous in HttpClient.java. $ hg diff -R open diff -r 40098289d580 src/java.net.http/share/classes/java/net/http/HttpClient.java --- a/src/java.net.http/share/classes/java/net/http/HttpClient.java Wed

Re: RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

Looks fine. Mandy On 11/14/18 4:01 PM, Jonathan Gibbons wrote: Please review the removal of two extraneous in HttpClient.java. $ hg diff -R open diff -r 40098289d580 src/java.net.http/share/classes/java/net/http/HttpClient.java --- a/src/java.net.http/share/classes/java/net/http/HttpClient.j

RFR: XXS: JDK-8213910: Invalid HTML in java.net.http.HttpClient

Please review the removal of two extraneous in HttpClient.java. $ hg diff -R open diff -r 40098289d580 src/java.net.http/share/classes/java/net/http/HttpClient.java --- a/src/java.net.http/share/classes/java/net/http/HttpClient.java Wed Nov 14 12:25:15 2018 -0800 +++ b/src/java.net.http/share/

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi, Roger * I like Mandy's idea of not combining the cli/VM props and the well-known props into a single array. Maybe we could then avoid copying between arrays (System.c L166). * The name "Raw" doesn't really speak to me. It's OK as an inner class, though I wonder if everything could be d

Re: FYI: new javadoc tag to document system properties

Hello, For future CSR requests involving system properties, please document the properties using these javadoc facilities. Thanks, -Joe On 11/14/2018 2:27 PM, Jonathan Gibbons wrote: This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (

FYI: new javadoc tag to document system properties

This is an FYI to announce some initial, long-overdue support in javadoc for documenting system properties (JDK-5076751). Currently, system properties are just documented using ad-hoc narrative text, which is fine if you know where to look for any given property. JDK 12 introduces a new inlin

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Roger, The system property initialization long for a clean up. Thanks for looking at it.  This is a good start.  I think it'd be good to make further improvement. 140 cmdProps = JVM_GetProperties(env); Instead of prepending the predefined set of properties with cmdProps, I suggest to separat

Re: Reflection, TYPE_USE annotation on THROWS on inner class constructor, Java 9+

Hi Michael, Thanks for the report. I have created: https://bugs.openjdk.java.net/browse/JDK-8213905 to track it, Vicente On 11/9/18 10:13 AM, Michael Rasmussen wrote: Hi When adding a TYPE_USE annotation with runtime retention to the throws exception clause of a constructor of an inner cla

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Coleen, yes, the changes to the jvm.h functions should have a CSR. I created a CSR to track the interface change.   https://bugs.openjdk.java.net/browse/JDK-8213895 Thanks, Roger On 11/14/2018 11:22 AM, coleen.phillim...@oracle.com wrote: Hi Roger, the VM changes to this look great to me

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Thanks for the comments Weijun. As per other review thread, I'm now recording all properties set via Security.setProperty(String, String). regards, Sean. On 14/11/2018 01:11, Weijun Wang wrote: Confused. Aren't all Security properties security-related? This is not about normal system prope

Re: RFR: 8148188: Enhance the security libraries to record events of interest

Hi Sean, comments inline.. On 13/11/2018 18:53, Sean Mullan wrote: Looking good, a couple of comments/questions: * src/java.base/share/classes/java/security/Security.java The isJdkSecurityProperty method could return false positives, for example there may be a non-JDK property starting with

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Mandy, The change does not make a measurable change in startup time. The number of bytecodes executed in initPhase1 dropped from 60k to 50k out of 850k. Thanks, Roger On 11/14/2018 12:25 PM, Mandy Chung wrote: Hi Roger, Does this change improve the startup performance? initProperties is d

Re: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

Ichiroh, IBM/AIX people should reach consensus on how to handle IBM charsets. I'm going to add some IBM people who might know or care. (I haven't used AIX in 20 years) On Wed, Nov 14, 2018 at 10:23 AM, Ichiroh Takiguchi < taki...@linux.vnet.ibm.com> wrote: > Hello. > > Martin Buchholz suggested

Re: [12] RFR: 8213818: @return has already been specified

Looks fine! Thanks, Roger On 11/14/2018 02:11 PM, naoto.s...@oracle.com wrote: Hi, Please review an XS fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8213818 The fix is located at: http://cr.openjdk.java.net/~naoto/8213828/webrev.00/ which is just removing a duplicate

[12] RFR: 8213818: @return has already been specified

Hi, Please review an XS fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8213818 The fix is located at: http://cr.openjdk.java.net/~naoto/8213828/webrev.00/ which is just removing a duplicate @return statement. Naoto

Fwd: Re: RFR: 8212794 IBM-964 and IBM-29626C are required for AIX default charset

Hello. Martin Buchholz suggested me via bugs.openjdk.java.net, I should not touch non AIX side. So I rewrote another code. Could you review the fix again ? Bug:https://bugs.openjdk.java.net/browse/JDK-8212794 Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.01/ I don't want to

Re: Problems with AES-GCM native acceleration

CCing to core-libs and security. Based on last comment corresponding java code may need to be re-factored. It is not simple. To trigger x64 AES instructions usage early (before JIT compilation kicks in) we may consider call optimized code from Interpreter similar to CRC32 code. It is also very

Re: RFR (JDK 12/java.base) 8213325: (props) Properties.loadFromXML does not fully comply with the spec

Hi Daniel, You're right. It isn't strictly necessary. It was there only because it was in a pair with startDTD as in the original SAX interface. I can remove it as it doesn't serve anything here. Thanks, Joe On 11/14/18, 2:32 AM, Daniel Fuchs wrote: Hi Joe, I do not see where the new DTDHa

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Roger, Does this change improve the startup performance?  initProperties is done in initPhase1 where the Java code is running in interpreted mode.  Brent did the measurement some time ago that JNI calls is one cost while executing quite a lot of bytecodes in interpreted mode is another cost.

Re: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

> On Nov 14, 2018, at 3:50 AM, Baesken, Matthias > wrote: > > Hello, looks like finally Windows Server 2019 is availability after the > release stop . > > David found this info from November 13, 2018 : > > https://cloudblogs.microsoft.com/windowsserver/2018/11/13/update-on-windows-se

Re[4]: The new optimized version of Dual-Pivot Quicksort

Hello, Tagir! Thank you for interesting news! I will look at RadixSort and let you know my result. It may happen that int will be sorted by numeric-specific sorting algorithm (like we switched byte, char, short to counting sort). Regards, Vladimir >Среда, 14 ноября 2018, 19:17 +03:00 от Tagir

Re: Re[2]: The new optimized version of Dual-Pivot Quicksort

Hello, Laurent, Vladimir! I created a pull request containing my RadixSort implementation: https://github.com/bourgesl/nearly-optimal-mergesort-code/pull/1 On my machine the results produced by Mergesorts.java are like this: Runs with individual timing (skips first 10 runs): adjusted reps: 110 +

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Hi, On 11/14/2018 09:52 AM, Andy Herrick wrote: On 11/13/2018 5:50 PM, Philip Race wrote: On 11/13/18, 12:52 PM, Roger Riggs wrote: Hi, There are enough files unique to each platform to put them in separate packages otherwise you get too many (IMHO) files in a single package/directory an

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 11/13/2018 5:50 PM, Philip Race wrote: On 11/13/18, 12:52 PM, Roger Riggs wrote: Hi, There are enough files unique to each platform to put them in separate packages otherwise you get too many (IMHO) files in a single package/directory and its harder to tell which go with which.  There

Re: RFR 4947890 : Minimize JNI upcalls in system-properties initialization

Hi Thomas, I was aiming for a fairly straightforward, easy to maintain technique, not too far removed from the current implementation. The strings need to be created sometime and the JNI function to create a string doesn't suffer from much overhead (compared to java) so I don't think it would

Re: RFR - JDK-8203442 String::transform (Code Review)

On Tue, 13 Nov 2018 at 15:44, Brian Goetz wrote: > Yes, we know :) But we don’t have any current plans to do that, nor use-site > extension methods, nor does it seem likely to come to the top of the language > priority list very soon. So its not a choice between |> and .transform(); > it’s a

JDK12 talks ASM7 now!

Hi guys, Thanks everyone for the feedback. I pushed the patch yesterday, Vicente

RE: RFR - JDK-8203442 String::transform (Code Review)

Hi Remi, Brian, What about ‘asInputTo’ or some variant thereof (e.g. using Argument or the abbreviated Arg instead of Input; or dropping/replacing either of the prefix/suffix)? This would give, for example: `raw html`.asInputTo(HtmlDocument::new) source.stream().asInputTo(this::maybeAddFi

Re: RFR: 8148188: Enhance the security libraries to record events of interest

On 11/13/18 1:53 PM, Sean Mullan wrote: * src/java.base/share/classes/sun/security/x509/X509CertImpl.java  158 // Event recording cache list  159 private List recordedCerts; Shouldn't this be static? Otherwise each certificate would have it's own instance and duplicates would not be

Re: RFR: 8148188: Enhance the security libraries to record events of interest

On 11/13/18 8:11 PM, Weijun Wang wrote: Confused. Aren't all Security properties security-related? This is not about normal system properties. Although probably not that common, an application could create their own security properties, ex: Security.setProperty("security.myPassword", "abc123

Re: RFR - JDK-8203442 String::transform (Code Review)

Hi Brian, - Mail original - > De: "Brian Goetz" > À: "Peter Levart" > Cc: "core-libs-dev" > Envoyé: Mardi 13 Novembre 2018 15:37:31 > Objet: Re: RFR - JDK-8203442 String::transform (Code Review) >> An argument against re-using the name map() for this String method is that >> Stream.map

Re: RFR (JDK 12/java.base) 8213325: (props) Properties.loadFromXML does not fully comply with the spec

Hi Joe, I do not see where the new DTDHandler::endDTD methos is called. Is that an oversight or is there more magic? best regards, -- daniel On 14/11/2018 05:18, Joe Wang wrote: Hi, Please review a patch to bring the small footprint parser for java.util.Properties compliant with the specifi

RE: RFR : 8211106: [windows] Update OS detection code to recognize Windows Server 2019

Hello, looks like finally Windows Server 2019 is availability after the release stop . David found this info from November 13, 2018 : https://cloudblogs.microsoft.com/windowsserver/2018/11/13/update-on-windows-server-2019-availability/ " ... In addition to extensive internal validation

Extending Java Arrays/Collection Sort API

Hi, I am a scientist and the author of the Marlin renderer, integrated in OpenJDK. In this renderer, I needed a fast sort algorithm on small almost sorted arrays, but more important, to deal with 2 arrays: x values and their corresponding edge indices (pointer like). I derived my MergeSort class