Hi Alan,
I can sympathize with the performance loss aspect of this patch, but I
nevertheless think it is a move in the right direction. You must admit
that the performance optimization of AbstractSet.removeAll was a rather
shaky one (dependent on the relative sizes of the two collections) and
Hi Stuart,
I believe I already accepted the fact of ersatz Collections.
Could you explain the inconsistency in the specification that affects
removeAll()? I don’t see it.
In the current specification, the classes that can create ersatz Collections
all call out the ersatz Collections in their d
Hi all,
Please review the change to update the l10n names for Japanese era Reiwa
in JDK COMPAT provider. The l10n names come from the CLDR 35.1, please
refer this unicode chart[1] for l10n definitions.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8218781
Webrev:
http://cr.openjdk.java.net/~l
Hi Alan,
Whether you call them "ersatz" collections, "non-standard" collections, or
collections with different membership semantics, they have been around in the
collections framework from day one. This is perhaps unfortunate, and it may be
considered to be bad design, but it is a fact.
The
Stuart's cool type system hack is hard for me to grok, but it seems alright
to put into ConcurrentSkipListMap.java. We could add it to the current
jsr166 integration.
*From: *Stuart Marks
*Date: *Thu, May 16, 2019 at 3:11 PM
*To: *Martin Buchholz, David Holmes, Doug Lea, Langer, Christoph
*Cc:
Hi,
I still need a reviewer for this simple patch and CSR,
TIA,
Vicente
On 5/14/19 4:53 PM, Vicente Romero wrote:
Please review fix for [1] at [2]. The implementation of method
java.lang.constant.MethodTypeDesc::dropParameterTypes was throwing a
non specified exception. The proposed fix is sy
Hi Roger,
Thanks for the review, I will do the re-wrapping before pushing,
Thanks,
Vicente
On 5/16/19 5:15 PM, Roger Riggs wrote:
Hi Vicente,
Looks ok.
And the CSR too.
Please re-wrap the lines to 80 chars to make diffs easier to read.
ConstantDesc.java and MethodTypeDesc.java
Thanks, Roger
On 5/14/19 9:16 PM, Martin Buchholz wrote:
src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
Regarding the change in this particular file, I'd suggest the following:
diff -r 006dadb903ab -r 92e1fdce45e0
src/java.base/share/classes/java/util/concurrent/ConcurrentS
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html
Just another test timeout tweak:
8224024: java/util/concurrent/BlockingQueue/DrainToFails.java testBounded
fails intermittently
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/DrainToFails/index.htm
Hi Vicente,
Looks ok.
And the CSR too.
Please re-wrap the lines to 80 chars to make diffs easier to read.
ConstantDesc.java and MethodTypeDesc.java
Thanks, Roger
On 05/15/2019 05:27 PM, Vicente Romero wrote:
Please review fix for [1] at [2] and the related CSR at [3]. Method
java.lang.constan
ping
On 5/15/19 5:27 PM, Vicente Romero wrote:
Please review fix for [1] at [2] and the related CSR at [3]. Method
java.lang.constant.MethodTypeDesc::insertParameterTypes should
control the type of parameters being inserted. In particular, no
parameter can be a class descriptor of primitive t
Looks good.
/Erik
On 2019-05-16 12:30, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223804
Webrev: http://cr.openjdk.java.net/~prr/8223804/
This is a small cleanup fix.
When doing a previous launcher fix :
https://bugs.openjdk.java.net/browse/JDK-8222819
I failed to check i
Hi Phil,
Looks fine.
Roger
On 05/16/2019 03:30 PM, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223804
Webrev: http://cr.openjdk.java.net/~prr/8223804/
This is a small cleanup fix.
When doing a previous launcher fix :
https://bugs.openjdk.java.net/browse/JDK-8222819
I fai
Bug: https://bugs.openjdk.java.net/browse/JDK-8223804
Webrev: http://cr.openjdk.java.net/~prr/8223804/
This is a small cleanup fix.
When doing a previous launcher fix :
https://bugs.openjdk.java.net/browse/JDK-8222819
I failed to check if the removal there meant there were now unused
imports in
done, I have restricted the scope of the CSR to method
`j.l.c.MethodTypeDesc::ofConstructor` only which is the one for which
the doc change is more important,
Thanks,
Vicente
On 5/16/19 12:41 PM, Joe Darcy wrote:
Hi Vicente,
As the spec now includes a very small change to cover the array
co
Hi Vicente,
As the spec now includes a very small change to cover the array
contents, please update the CSR and I'll quickly approve it.
Thanks,
-Joe
On 5/16/2019 9:19 AM, Vicente Romero wrote:
Hi Joe,
Yes you are correct, thanks, I have updated the spec for the method
plus added a couple
On 16/05/2019 17:27, Alan Bateman wrote:
> On 16/05/2019 15:49, Andrew Dinn wrote:
>> Please review this trivial change to MapperByteBuffer which encapsulates
>> the page align down operation in a suitably named method.
>>
>> JIRA: https://bugs.openjdk.java.net/browse/JDK-8224042
>> webrev: http:
On 16/05/2019 17:24, Mikael Vidstedt wrote:
>
> Looks good, thanks for doing it!
Thanks for the review Mikael.
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningha
On 16/05/2019 15:49, Andrew Dinn wrote:
Please review this trivial change to MapperByteBuffer which encapsulates
the page align down operation in a suitably named method.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8224042
webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/
Looks
Looks good, thanks for doing it!
Cheers,
Mikael
> On May 16, 2019, at 7:49 AM, Andrew Dinn wrote:
>
> Please review this trivial change to MapperByteBuffer which encapsulates
> the page align down operation in a suitably named method.
>
> JIRA: https://bugs.openjdk.java.net/browse/JDK-8224
Hi Thomas,
Thanks for the review.
On 16/05/2019 16:54, Thomas Stüfe wrote:
> looks good and trivial. Method could be static.
Yes, good point! I will modify accordingly and then push.
regards,
Andrew Dinn
---
Hi Joe,
Yes you are correct, thanks, I have updated the spec for the method plus
added a couple of tests to make sure that the right exception is being
thrown [1],
Thanks,
Vicente
[1] http://cr.openjdk.java.net/~vromero/8223726/webrev.01/
On 5/15/19 1:45 PM, Joe Darcy wrote:
Hi Vicente,
S
Hi Andrew,
looks good and trivial. Method could be static.
Cheers, Thomas
On Thu, May 16, 2019 at 4:49 PM Andrew Dinn wrote:
> Please review this trivial change to MapperByteBuffer which encapsulates
> the page align down operation in a suitably named method.
>
> JIRA: https://bugs.openjdk.j
Klaus:
My apologies for not getting back to you sooner.
I have tried the (nearly) the exact steps you give and can run the
resultant app on windows.
My best guess is that it is caused by a problem we have when there are
spaces in the path given to --runtime-image. (similar to
https://bugs.o
On 16/05/2019 14:14, Alan Bateman wrote:
> Mikael's suggestion seem okay. This is under the hood implementation so
> doesn't matter if there is a follow-on issue or you include it in the
> bigger patch. It might be easier to do the former while it's fresh in
> our minds.
Indeed. I have raised JDK-8
Please review this trivial change to MapperByteBuffer which encapsulates
the page align down operation in a suitably named method.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8224042
webrev: http://cr.openjdk.java.net/~adinn/8224042/webrev.00/
Testing:
This was successfully exercised by runn
Hi Christoph,
Thank you for the update.
Looks good. One minor suggestion below that you can take care of before you
push without a new webrev.
Best,
Lance
> On May 15, 2019, at 9:25 AM, Langer, Christoph
> wrote:
>
> Hi Lance,
>
> thanks for the quick turnaround. I tried to address your f
On 14/05/2019 09:00, Andrew Dinn wrote:
Hi Mikael,
Thanks for looking at this.
On 13/05/2019 17:41, Mikael Vidstedt wrote:
Would it be worth putting the logic in an aptly named (private)
method? Something like:
...
private long alignDown(long address, long alignment) {
return addres
On 15/05/2019 21:32, Roger Riggs wrote:
Please review a change in the synchronization during the creation of
an ObjectInputStream.
Currently, a synchronized block is used to initialize the streams
filter is read the global serial filter
which becomes a bottleneck under high concurrency. Since t
Hi Roger,
On 16/05/2019 6:32 am, Roger Riggs wrote:
Please review a change in the synchronization during the creation of an
ObjectInputStream.
Currently, a synchronized block is used to initialize the streams filter
is read the global serial filter
which becomes a bottleneck under high concurre
30 matches
Mail list logo
