JDK 13 RFR of JDK-8181869: getAnnotatedParameterTypes​() specification should be clarified

Hello, Please review the doc clarification below to address     JDK-8181869: getAnnotatedParameterTypes​() specification should be clarified Each of the three flavors of get-parameter-types methods (getParameterTypes, getGenericParameterTypes, getAnnotatedParameterTypes) gets the same

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

http://cr.openjdk.java.net/~almatvee/8224597/webrev.02/ Updated OS X tests to use XML APIs to parse Info.plist. Thanks, Alexander On 6/6/2019 2:43 PM, Alexey Semenyuk wrote: Any particular reason not to use xml api to read xml files? The way to extract app attributes from xml files produced

JDK 13 RFR of JDK-8042748: Clarify exception thrown by ParameterizedTypeImpl.validateConstructorArguments()

Hello, Please review the patch below to address     JDK-8042748: Clarify exception thrown by ParameterizedTypeImpl.validateConstructorArguments() Thanks, -Joe diff -r 0a7af38ef32a src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ---

Re: JDK 13 RFR of JDK-8225465: Add @jls tags to receiver type methods

+1 > On Jun 6, 2019, at 8:38 PM, Joe Darcy wrote: > > Hello, > > Receiver types are an obscure corner of the Java language added as part of > type annotations. The API methods in core reflection and javax.lang.model > that refer to receiver types should cross-reference the relevant JLS

JDK 13 RFR of JDK-8225465: Add @jls tags to receiver type methods

Hello, Receiver types are an obscure corner of the Java language added as part of type annotations. The API methods in core reflection and javax.lang.model that refer to receiver types should cross-reference the relevant JLS sections using @jls javadoc tags. Please review the patch below to

Re: RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

On 6/6/19 8:39 AM, Andrew Haley wrote: On 6/6/19 12:35 PM, Ivan Gerasimov wrote: Could you please check it if it looks better now? http://cr.openjdk.java.net/~igerasim/8225397/00/webrev/ OK, it's just a hint, fair enough. Patch is OK. Thank you! For an extra gold star (:-) you could

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

looks good to me. /Andy On 6/6/2019 5:37 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added tests for --win-console, --mac-bundle-identifier and

Re: RFR: JDK-8224130: create additional automated tests for create-app-image

Looks good. - Alexey On 6/6/2019 5:45 PM, Andy Herrick wrote: revised to use Files.newBufferedWriter() in JPackageHelper.cmdWithAtFilename() as suggested. webrev: http://cr.openjdk.java.net/~herrick/8224130/webrev.02/ /Andy On 6/6/2019 1:03 PM, Alexey Semenyuk wrote:

Re: JEP 343: Packaging Tool

Andy is looking into a change which should satisfy the requirement to be able to produce an intermediate app-image (and later create a package from an app-image), while also getting rid of the two sub-commands, and making the building of the installer (package) the default. The idea would be

Re: RFR: JDK-8224130: create additional automated tests for create-app-image

revised to use Files.newBufferedWriter() in JPackageHelper.cmdWithAtFilename() as suggested. webrev: http://cr.openjdk.java.net/~herrick/8224130/webrev.02/ /Andy On 6/6/2019 1:03 PM, Alexey Semenyuk wrote:

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

Any particular reason not to use xml api to read xml files? The way to extract app attributes from xml files produced by jpackage looks fragile. - Alexey On 6/6/2019 5:37 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch

RFR: JDK-8224597: create automated tests for platform create-app-image options

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added tests for --win-console, --mac-bundle-identifier and --mac-bundle-name. [1] https://bugs.openjdk.java.net/browse/JDK-8224597 [2]

Re: RFR: JDK-8223333: Use try-with-resources where feasible

Hi Andy, Looks good. As well as other fixes you send yesterday for review. Thanks, Alexander On 6/6/2019 12:48 PM, Andy Herrick wrote: OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:

Re: RFR: JDK-8223333: Use try-with-resources where feasible

Looks good. - Alexey On 6/6/2019 3:48 PM, Andy Herrick wrote: OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:

Re: JEP 343: Packaging Tool

2019/6/5 16:09:11 -0700, Alan Snyder : > I haven’t used recent versions of this tool, but I have found it > essential to be able to modify the image before the final package is > created. There is no way that this tool can anticipate all of the > custom configuration that might be needed, and I do

Re: RFR: JDK-8225448 String::translateEscapes javadoc has accessibility issues

Looks good to me, and to doccheck. -- Jon On 06/06/2019 12:33 PM, Jim Laskey wrote: Please review these changes. A table in the javadoc for String::translateEscapes was missing some tags. Thank you. Cheers, -- Jim webrev: http://cr.openjdk.java.net/~jlaskey/8225448/webrev-01/index.html

Re: RFR: JDK-8223333: Use try-with-resources where feasible

OK - revised MacCertificate as per below: webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03 /Andy On 6/6/2019 12:47 PM, Alexey Semenyuk wrote: http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html,

Re: RFR JDK-8225339 Optimize HashMap.keySet()/HashMap.values()/HashSet toArray() methods

On 6/5/19 9:25 PM, Tagir Valeev wrote: Thanks for review. Indeed, you have a point about behavioral change. I filed a CSR: https://bugs.openjdk.java.net/browse/JDK-8225393 Great, I've made some edits to the CSR and I've added myself as a reviewer. It should be ready for you to move into the

RFR: JDK-8225448 String::translateEscapes javadoc has accessibility issues

Please review these changes. A table in the javadoc for String::translateEscapes was missing some tags. Thank you. Cheers, -- Jim webrev: http://cr.openjdk.java.net/~jlaskey/8225448/webrev-01/index.html jbs:

Re: RFR: 8224974: Implement JEP 352

Hi Andrew, > On Jun 6, 2019, at 9:24 AM, Brian Burkhalter > wrote: > >> So, here is webrev.06 as the latest official patch: >> >> http://cr.openjdk.java.net/~adinn/8224974/webrev.06/ >> I created a delta webrev versus version 5 and

Re: RFR: 8224974: Implement JEP 352

Hotspot changes looks good. CheckGraalIntrinsics failed because of typo - you should use 'J' instead of 'L': + "jdk/internal/misc/Unsafe.writeback0(L)V", One nitpick in vmSymbols.hpp spacing is off in next line: + do_intrinsic(_writebackPostSync0,jdk_internal_misc_Unsafe,

Re: RFR: JDK-8223586: remove jpackage dead code and other cleanup

Looks good. - Alexey On 6/5/2019 8:14 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223586 [2]

Re: RFR: JDK-8223212: Code cleanup found during jpackage review

Looks good. - Alexey On 6/5/2019 8:14 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223212 [2]

Re: RFR: JDK-8224130: create additional automated tests for create-app-image

http://cr.openjdk.java.net/~herrick/8224130/webrev.01/test/jdk/tools/jpackage/helpers/JPackageHelper.java.sdiff.html: ---  try (PrintWriter out = new PrintWriter(new BufferedWriter(  520 new FileWriter("argfile.cmds" {  521 out.println(fileString);  522 

Re: RFR: JDK-8224748: --add-launcher option --add-modules

Looks good. - Alexey On 6/5/2019 8:06 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224748 [2]

Re: RFR: JDK-8223953: Fix CLASSPATH parsing for sub-directorys containing spaces

Looks good. - Alexey On 6/5/2019 8:03 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223953 [2]

Re: RFR: JDK-8223241: jpackage cleanup from code review

Looks good. - Alexey On 6/5/2019 8:01 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223241 [2]

Re: RFR: JDK-8223333: Use try-with-resources where feasible

http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html, lines 81-93 can be replaced with a single statement, something like: --- java.nio.file.Files.copy(   new ByteArrayInputStream(baos.toByteArray()),  

Re: RFR: 8224974: Implement JEP 352

Hi Andrew, > On Jun 6, 2019, at 1:53 AM, Andrew Dinn wrote: > > […] > > I have updated webrev.06 in place and PmemTest now runs ok. I still need > to have Jonathan Halliday test the patch with our Transaction and Data > Grid software before it can be properly signed off. Another submit run >

Re: RFR: JDK-8222901: different behavior when --name option not used

Looks good. - Alexey On 6/5/2019 7:52 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222901 [2]

Re: RFR: JDK-8223333: Use try-with-resources where feasible

good catch - update 7 files to use Files.newBufferedWriter(). revised webrev: http://cr.openjdk.java.net/~herrick/822/webrev.02 /Andy On 6/6/2019 2:54 AM, Remi Forax wrote: Hi Andy, A code like this is not safe try (Writer w

Re: RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

On 6/6/19 12:35 PM, Ivan Gerasimov wrote: > Could you please check it if it looks better now? > > http://cr.openjdk.java.net/~igerasim/8225397/00/webrev/ OK, it's just a hint, fair enough. Patch is OK. For an extra gold star (:-) you could consider adding a comment like "avoid overflow in the

Re: 13 RFR (XXS) 8197927: Allow the system property `java.vendor.version` to be undefined

Lance, Mandy, Christoph -- thanks for the reviews! - Mark

Re: 8219992: Correct the documentation of PrintWriter to refer System.lineSeparator

+1 On 06/05/2019 05:38 PM, Lance Andersen wrote: looking good Brian... On Jun 5, 2019, at 5:31 PM, Brian Burkhalter wrote: Updated patch based on CSR feedback: --- a/src/java.base/share/classes/java/io/PrintWriter.java +++ b/src/java.base/share/classes/java/io/PrintWriter.java @@ -704,9

Re: RFR: 8207851: Implement JEP 352

On 06/06/2019 10:46, Andrew Haley wrote: > Handy hint. In your .emacs, add this: > > ;;; goodbye trailing whitespace blues!!! > > (add-hook 'java-mode-hook > (lambda () >(progn > (set-variable 'show-trailing-whitespace t) > ))) > > (add-hook

Re: PING: RFR(s): (new approach) 8223777: In posix_spawn mode, failing to exec() jspawnhelper does not result in an error

* Thomas Stüfe: > Hi Florian, > > Interesting, but in this case it is not posix_spawn, but plain > fork(). The VM does this, the exec calls come from us, not the > libc. See childproc.c . Ah. Others have unearthed the genealogy. Thanks for that. I wonder if in a Java context, things are

Re: RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

Thank you Andrew! The multiplier 6 was pre-existent, and I don't really want to change behavior in this legacy class. The high limit of (Integer.MAX_VALUE - 20) was arbitrarily chosen. I don't think it matters much in this case, but I can change it to (Integer.MAX_VALUE - 8), which is used

Re: RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

On 6/6/19 10:18 AM, Ivan Gerasimov wrote: > Hello! > > It is yet another instance of integer overflow under certain extreme > circumstances. > > This time it is when calculating the initial capacity of a StringBuilder > in BitSet.toString. > > If there are too many elements in the set, we

Re: RFR JDK-8225339 Optimize HashMap.keySet()/HashMap.values()/HashSet toArray() methods

Hello! > The doc will change for HashSet and LinkedHashSet as currently it says > that toArray methods are inherited from AbstractCollection which is not > true anymore. > For HashMap/LinkedHashMap doc should not change. I will post a specdiff to > CSR [1] once I figure out how to generate it. I

Re: RFR: 8207851: Implement JEP 352

On 6/6/19 10:13 AM, Andrew Dinn wrote: > On 05/06/2019 19:13, Gustavo Romero wrote: >> I found some trailing space in v5 and it seems they are in v6 as well. > Thanks for the heads up. I will fix these in the next webrev (07). Handy hint. In your .emacs, add this: (add-hook 'java-mode-hook

RFR (s) 8225397 : Integer value miscalculation in toString() method of BitSet

Hello! It is yet another instance of integer overflow under certain extreme circumstances. This time it is when calculating the initial capacity of a StringBuilder in BitSet.toString. If there are too many elements in the set, we can't do much anyway. The best effort is to avoid confusing

Re: RFR: 8207851: Implement JEP 352

Hi Gustavo, On 05/06/2019 19:13, Gustavo Romero wrote: > I found some trailing space in v5 and it seems they are in v6 as well. Thanks for the heads up. I will fix these in the next webrev (07). regards, Andrew Dinn --- Senior Principal Software Engineer Red Hat UK Ltd Registered in

Re: RFR: 8224974: Implement JEP 352

Hi Brian, On 06/06/2019 01:06, Brian Burkhalter wrote: > With version 6 [1] of the patch applied, tests throw this exception: > > Mapped java.lang.InternalError: java.lang.NullPointerException > at > java.base/jdk.internal.misc.ExtendedMapMode.newMapMode(ExtendedMapMode.java:58) > at >

RFR: JDK-8224130: create additional automated tests for create-app-image

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224130 [2] http://cr.openjdk.java.net/~herrick/8224130/ /Andy

RE: 13 RFR (XXS) 8197927: Allow the system property `java.vendor.version` to be undefined

+1 Thanks for taking care of this. /Christoph > -Original Message- > From: core-libs-dev On Behalf > Of mark.reinh...@oracle.com > Sent: Donnerstag, 6. Juni 2019 01:07 > To: core-libs-dev@openjdk.java.net > Subject: 13 RFR (XXS) 8197927: Allow the system property >

Re: RFR: JDK-8223333: Use try-with-resources where feasible

Hi Andy, A code like this is not safe try (Writer w = new BufferedWriter(new FileWriter( ... because new BufferedWriter may throw an OutOfMemoryError, in that case the file descriptor used by the FileWriter is not freed. There are two ways to fix that, either you need to expand the