[PATCH] Add const to input parameter for JNU_IsInstanceOfByName

Hi Everyone, I'm making some const-correctness fixes to some downstream libraries that use JNU_* functions, and noticed that JNU_IsInstanceOfByName takes in the class name by char* instead of const char* when it does not need to modify the string. It would be useful to change this so that we

Re: 8131664: Javadoc for PrintStream is now incorrect

Hi Lance, > On Jul 15, 2019, at 1:33 PM, Lance Andersen wrote: > > Is there an existing CSR or are you waiting for the review to complete here? The latter. > Overall, I think it is OK. > > The existing autoflush wording looks like it could use some wordsmithing at > some point (as I know

Re: 8131664: Javadoc for PrintStream is now incorrect

Hi Brian, Is there an existing CSR or are you waiting for the review to complete here? Overall, I think it is OK. The existing autoflush wording looks like it could use some wordsmithing at some point (as I know we do this a little differently in some of the APIs ) - “A boolean” not sure we

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

There is however this problematic statement in the PrintStream class doc that neither of the two alternative versions of the fix addresses: "Two other features are provided as well. Unlike other output streams, a PrintStream never throws an IOException; instead, exceptional situations merely

8131664: Javadoc for PrintStream is now incorrect

https://bugs.openjdk.java.net/browse/JDK-8131664 http://cr.openjdk.java.net/~bpb/8131664/webrev.00/ This patch proposes to clean up some verbiage in java.io .PrintStream

Re: JDK 14 RFR of JDK-8202385: Annotation to mark serial-related fields and methods

Generally, the current idiom in JDK API docs is to use a link beginning "{@docRoot}/../specs/." such as "{@docRoot}/../specs/serialization/index.html" -- Jon On 07/13/2019 01:16 PM, Joe Darcy wrote: PS I've uploaded an updated an iteration of the webrev    

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Here is an alternative version which adds a writeBytes(byte[]) method instead of overriding write(byte[]): http://cr.openjdk.java.net/~bpb/8187898/webrev-alt.00/ This has the advantage of allowing new code to call writeBytes() without a

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Looks fine,  Brian. On 7/15/19 11:58 AM, Brian Burkhalter wrote: So updated: http://cr.openjdk.java.net/~bpb/8187898/webrev.02/ Thanks, Brian On Jul 12, 2019, at 4:15 PM, Philip Race wrote: In that case just delete the comments and the

Re: [11u] RFR: 8227127: Era designator not displayed correctly using the COMPAT provider

Looks good to me. Naoto On 7/15/19 7:19 AM, Severin Gehwolf wrote: Hi, Could I please get a review of this 11u backport? The JDK 14 patch doesn't apply as is due to JDK-8221432 (CLDR data update) not being present. I've fixed LocaleDataTest.java's @bug line manually. Otherwise the patch is

Re: RFR: 8227615: [TESTBUG] Fix jtreg "jdk/sun/security/util/FilePermCompat/CompatImpact.java" failing with graal issue.

Good. Thanks, Vladimir On 7/15/19 2:32 AM, Xiaohong Gong (Arm Technology China) wrote: Hi, Please help to review this small patch: Webrev: http://cr.openjdk.java.net/~pli/rfr/8227615/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8227615 Jtreg test

Re: RFR: 8227574: Fix jtreg access denied failure with graal mode.

Looks good to me. Thanks, Vladimir On 7/15/19 1:40 AM, Xiaohong Gong (Arm Technology China) wrote: Hi, Please help to review the following patch that fixes two jtreg tests failure with graal mode due to the access denied issue. Webrev: http://cr.openjdk.java.net/~pli/rfr/8227574/webrev.00/

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Hello, > On Jul 13, 2019, at 12:00 PM, Tagir Valeev wrote: > > And whilst great you are fixing up this code, we are but a small fraction of > the world's code > that use java.io and I wonder if this is worth the > compatibility risk ? > > Why not introducing a separate

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

So updated: http://cr.openjdk.java.net/~bpb/8187898/webrev.02/ Thanks, Brian > On Jul 12, 2019, at 4:15 PM, Philip Race wrote: > > In that case just delete the comments and the commented out code ... > > -phil. > > On 7/12/19, 3:12 PM,

[11u] RFR: 8227127: Era designator not displayed correctly using the COMPAT provider

Hi, Could I please get a review of this 11u backport? The JDK 14 patch doesn't apply as is due to JDK-8221432 (CLDR data update) not being present. I've fixed LocaleDataTest.java's @bug line manually. Otherwise the patch is the same. Bug: https://bugs.openjdk.java.net/browse/JDK-8227127 webrev:

Re: RFR: JDK-8220807: excessive verbose output when running with --win-per-user-install

Looks good. - Alexey On 7/15/2019 7:48 AM, Andy Herrick wrote: revised [3] to only suppress these warnings when --win-per-user-install option used [3] http://cr.openjdk.java.net/~herrick/8220807/webrev.02/ /Andy On 7/12/2019 1:22 PM, Alexey Semenyuk wrote: Andy, The fix suppresses

Re: RFR: JDK-8220807: excessive verbose output when running with --win-per-user-install

revised [3] to only suppress these warnings when --win-per-user-install option used [3] http://cr.openjdk.java.net/~herrick/8220807/webrev.02/ /Andy On 7/12/2019 1:22 PM, Alexey Semenyuk wrote: Andy, The fix suppresses warning for system wide installations too,not just for per user. Is

RFR: 8176894 Provide specialized implementation for default methods putIfAbsent, computeIfAbsent, computeIfPresent, compute, merge in TreeMap

Hello! Please review the following patch: http://cr.openjdk.java.net/~tvaleev/webrev/8176894/r2/ https://bugs.openjdk.java.net/browse/JDK-8176894 Also please review the associated CSR: https://bugs.openjdk.java.net/browse/JDK-8227666 The patch was originally submitted by Sergey Kuksenko in

RE: RFR [14]: 8227438: [TESTLIB] Determine if file exists by Files.exists in function FileUtils.deleteFileIfExistsWithRetry

Thank you, Joe and Lance! Pushed the change. Frank > -Original Message- > From: Joe Wang [mailto:huizhe.w...@oracle.com] > Subject: Re: RFR [14]: 8227438: [TESTLIB] Determine if file exists by > Files.exists in function FileUtils.deleteFileIfExistsWithRetry > > +1 > > -Joe > > >

Re: RFR: 8227642: [TESTBUG] Make docker tests podman compatible

Hi Misha, On Fri, 2019-07-12 at 15:19 -0700, mikhailo.seledt...@oracle.com wrote: > Hi Severin, > >The change looks good to me. Thank you for adding support for Podman > container technology. > > Testing: I ran both HotSpot and JDK container tests with your patch; > tests executed on