Re: JDK-8228402: chdir() and write() errors are not handled in jpackage

Hi Andy, I think it is better not to use assert() in this case since it terminates app abnormally. Do we really should terminate execution if write() fails in this case? Can we ignore error? It might be better to handle it gracefully and then return from main() with error if we cannot ignore

Re: RFR: JDK-8226542: DMG tests failing with java.io.IOException: Exec failed with code 1 command

Hi Andy, Looks fine. If I understood correctly default script was just opening DMG file in finder after it was generated, correct? Thanks, Alexander On 7/23/2019 2:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch

Re: RFR: JDK-8224627: Creating installer with --runtime-image on OS X fails

Hi Andy, Looks fine. Thanks, Alexander On 7/23/2019 2:01 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224627 [2]

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Sorry I was obviously missing the part of this thread where it was decided to not actually fix this as requested in the bug due to compatibility issues. I agree with Brian that something must be added to the class-level javadoc explaining that due to a historical oversight there is one

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Jumping in here as this change is starting to really confuse me ... On 24/07/2019 2:41 am, Brian Burkhalter wrote: On Jul 23, 2019, at 8:27 AM, Brian Burkhalter wrote: On Jul 23, 2019, at 8:20 AM, Alan Bateman mailto:alan.bate...@oracle.com>> wrote: On 23/07/2019 16:08, Brian Burkhalter

RE: RFR: 8228397: Missing license copyright header in some resource properties files

Hi, Leo., This updated webrev looks fine. Thanks for fixing! iris -Original Message- From: Leo Jiang Sent: Tuesday, July 23, 2019 12:08 AM To: Mandy Chung Cc: jdk-dev ; core-libs-dev Subject: Re: RFR: 8228397: Missing license copyright header in some resource properties files

8078891: java.io.SequenceInputStream.close is not atomic and not idempotent

https://bugs.openjdk.java.net/browse/JDK-8078891 http://cr.openjdk.java.net/~bpb/8078891/webrev.00/ Ensure that SequenceInputStream closes all component streams. Thanks, Brian

[14] RFR: 8212970: TZ database in "vanguard" format support

Hi, Please review the fix to the following enhancement: https://bugs.openjdk.java.net/browse/JDK-8212970 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8212970/webrev.09/ This change aims to support the "vanguard" IANA time zone data format, which uses the negative

JDK-8228402: chdir() and write() errors are not handled in jpackage

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8228402 [2] http://cr.openjdk.java.net/~herrick/8228402/ /Andy

RFR: JDK-8226542: DMG tests failing with java.io.IOException: Exec failed with code 1 command

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226542 [2] http://cr.openjdk.java.net/~herrick/8226542/ /Andy

RFR: JDK-8224627: Creating installer with --runtime-image on OS X fails

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224627 [2] http://cr.openjdk.java.net/~herrick/8224627/webrev.01/ /Andy

Re: 8202471: Resolves generic receiver type for types with generic signatures

I integrated the tests into the jtreg test suite (it seems to work for me, please double check since this is my first attempt). I will now also post a CSR to the corresponding list and reference this patch. Here comes the inline patch including the jtreg tests: Index:

Re: 8202469 / 8202473: Correct type annotation resolution for class type variables

I integrated the tests into the jtreg bits (to me it looks like they are running ok but since this is my first time, please double-check). I have already signed the OCA a few years ago when I did some work on Glassfish. Let me know if anything else is missing or if I need to do anything else.

Re: Review Request: JDK-8173978: Lookup.in should allow teleporting from a lookup class in a named module without dropping all access

(Coming back to this patch and ready to push this change later today) Here is the updated webrev:    http://cr.openjdk.java.net/~mchung/jdk14/8173978/webrev.02/ This includes the change that Peter suggested accepting m2 == null. Mandy On 7/5/19 12:29 PM, Peter Levart wrote: Hi Mandy, Yes,

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

> On Jul 23, 2019, at 10:09 AM, Brian Burkhalter > wrote: > >> You will want to add an @throws > > Will do. > >> The implSpec >> — >> * @implSpec >> * The default implementation is equivalent to >> * {@link java.io.FilterOutputStream#write(byte[],int,int) >> *

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Hi Lance, > On Jul 23, 2019, at 10:03 AM, Lance Andersen > wrote: > > A couple of minor suggestions: > > For > > ——— > @Override > public void write(byte buf[]) throws IOException { > super.write(buf, 0, buf.length); > } > > ——— > > You will want to add an @throws Will

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Hi Brian A couple of minor suggestions: For ——— @Override public void write(byte buf[]) throws IOException { super.write(buf, 0, buf.length); } ——— You will want to add an @throws The implSpec — * @implSpec * The default implementation is equivalent to

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

> On Jul 23, 2019, at 8:27 AM, Brian Burkhalter > wrote: > >> On Jul 23, 2019, at 8:20 AM, Alan Bateman > > wrote: >> >> On 23/07/2019 16:08, Brian Burkhalter wrote: >>> >>> I don’t see what you mean. >>>@Override >>>public void write(byte buf[])

Re: RFR: 8228501: java_props_macosx.c - provide missing CFRelease for CFLocaleCopyCurrent was: RE: java_props_macosx.c : CFLocaleCopyCurrent() needs CFRelease ?

Thanks, Matthias. Changes look good to me. I think it is hard to provide a regression test for this change, then please add noreg-hard label to the issue. Naoto On 7/23/19 4:23 AM, Baesken, Matthias wrote: Hello, please review the following fix that adds CFRelease to 2

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

> On Jul 23, 2019, at 8:20 AM, Alan Bateman wrote: > > On 23/07/2019 16:08, Brian Burkhalter wrote: >> >> I don’t see what you mean. >> @Override >> public void write(byte buf[]) throws IOException { >> super.write(buf); >> } >> Should “trouble” be set and the IOE

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

On 23/07/2019 16:08, Brian Burkhalter wrote: I don’t see what you mean. @Override public void write(byte buf[]) throws IOException { super.write(buf); } Should “trouble” be set and the IOE re-thrown? super.write(byte[]) will invoke PrintStream overrides write(byte[],

RFR: 8228482: fix xlc16/xlclang comparison of distinct pointer types and string literal conversion warnings

Hello please review this patch . It fixes a couple of xlc16/xlclang warnings , especially comparison of distinct pointer types and string literal conversion warnings . When building with xlc16/xlclang, we still have a couple of warnings that have to be fixed : warning: ISO C++11 does not

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

> On Jul 23, 2019, at 12:45 AM, Alan Bateman wrote: > > On 23/07/2019 01:01, Brian Burkhalter wrote: >> : >> This version [1] adds writeBytes() and overrides write(byte[]) without >> changing its behavior. The documentation of write(byte[]) points the user to >> writeBytes() and

CFDataCreate/CFRelease - was : RE: java_props_macosx.c : CFLocaleCopyCurrent() needs CFRelease ?

Hello ,I checked a number of other CF*Create* / CF*Copy* methods (and corresp. CFRelease calls) we have in java.base and almost all looked good to me . However this one looked bad to me :

RFR: 8228501: java_props_macosx.c - provide missing CFRelease for CFLocaleCopyCurrent was: RE: java_props_macosx.c : CFLocaleCopyCurrent() needs CFRelease ?

Hello, please review the following fix that adds CFRelease to 2 CFLocaleCopyCurrent usages . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8228501 http://cr.openjdk.java.net/~mbaesken/webrevs/8228501.0/ Best regards, Matthias > > Thanks for your input ! > > I opened > >

Re: [OpenJDK 2D-Dev] 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

On 23/07/2019 01:01, Brian Burkhalter wrote: : This version [1] adds writeBytes() and overrides write(byte[]) without changing its behavior. The documentation of write(byte[]) points the user to writeBytes() and write(byte[],int.int). The overridden write(byte[]) declares that it throws IOE

Re: RFR: 8228397: Missing license copyright header in some resource properties files

Thank you for your reviewing. Updated the webrev: http://cr.openjdk.java.net/~ljiang/8228397/webrev.01/ I know the update is trivial, if no more suggestion I will push the patch tomorrow. Thanks, Leo On 7/23/19 3:55 AM, Mandy Chung wrote: Hi Leo, Thanks for adding the copyright and

Re: java_props_macosx.c : CFLocaleCopyCurrent() needs CFRelease ?

Thanks for your input ! I opened https://bugs.openjdk.java.net/browse/JDK-8228501 for this issue, will provide a patch . Best regards, Matthias > Date: Mon, 22 Jul 2019 12:56:50 -0700 > From: naoto.s...@oracle.com > To: core-libs-dev@openjdk.java.net > Subject: Re: java_props_macosx.c :