Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

Hi, I saw my name in this thread and had a discussion with Mandy. I don't like that the VM and JDK having this special coordinated dance of +1/-1, and the reason for this is to differentiate the value of 0 in StackFrame meaning either uninitialized or invalid.  If through some race, an uniti

Re: RFR: JDK-8229138: Add --linux-app-release option for DEB and RPM packages

Looks good. On 8/13/2019 12:56 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229138?filter=-1 [2] http://cr.openjdk.java.net/

Re: 8187898: PrintStream should override FilterOutputStream#write(byte[]) with a method that has no throws clause

Reprising discussion of [1] from last month. I updated the patch [2] which now hopefully accounts for the various comments. Specifically the specification of the PrintStream.write(byte[]) override was clarified as follows: A) If auto-flush is enabled data will be flushed. B) API Note: * No IOE

Re: RFR: JDK-8215447: Investigate if current implementation of --license-file is correct for RPM packagesI

Looks good. On 8/13/2019 12:10 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Install license file in the correct location in stead of the app's installation directory

Re: RFR [14] 8217606: LdapContext#reconnect always opens a new connection

Hi Pavel, Chris, Looks good, Thanks for the improvements and cleanup as well as fixing the bug. Roger On 8/13/19 2:21 PM, Pavel Rappo wrote: On 13 Aug 2019, at 16:58, Roger Riggs wrote: The Semaphore implementation is the least complex. Looks fine to me. Updated: http://cr.openjd

Re: RFR: JDK-8229138: Add --linux-app-release option for DEB and RPM packages

Looks good. - Alexey On 8/13/2019 3:56 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229138?filter=-1 [2] http://cr.openjdk.

Re: RFR (XS) 8221307 : String.substring() OOB exception on start index reports improper information

Hi Ivan, Looks good. Thanks, Roger On 8/13/19 3:55 PM, Ivan Gerasimov wrote: Hello! A simple benchmark did not detect any negative impact of delegating substring(int) to substring(int, int): Before fix: Benchmark Mode  Cnt   Score   Error Units StringSubstring.from26to

Re: RFR: JDK-8229138: Add --linux-app-release option for DEB and RPM packages

please excuse the filter on the bug's url, make that: [1] https://bugs.openjdk.java.net/browse/JDK-8229138 /Andy On 8/13/2019 3:56 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpac

RFR: JDK-8229138: Add --linux-app-release option for DEB and RPM packages

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8229138?filter=-1 [2] http://cr.openjdk.java.net/~herrick/8229138/webrev.01/ Thanks, Andy

Re: RFR (XS) 8221307 : String.substring() OOB exception on start index reports improper information

Hello! A simple benchmark did not detect any negative impact of delegating substring(int) to substring(int, int): Before fix: Benchmark Mode  Cnt   Score   Error Units StringSubstring.from26toEnd0  avgt   12  20.279 ± 0.306 ns/op StringSubstring.from26toEnd1  avgt   12  20.

Re: RFR: JDK-8215447: Investigate if current implementation of --license-file is correct for RPM packagesI

looks good /Andy On 8/13/2019 3:10 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Install license file in the correct location in stead of the app's installation dire

RFR: JDK-8215447: Investigate if current implementation of --license-file is correct for RPM packagesI

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Install license file in the correct location in stead of the app's installation directory, update corresponding jtreg tests. [1] https://bugs.openj

Re: RFR [14] 8217606: LdapContext#reconnect always opens a new connection

> On 13 Aug 2019, at 16:58, Roger Riggs wrote: > > > > The Semaphore implementation is the least complex. Looks fine to me. Updated: http://cr.openjdk.java.net/~prappo/8217606/webrev.01/ -Pavel

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

On 8/13/19 9:30 AM, Peter Levart wrote: Usually the StackFrameInfo(s) are consumed as soon as they are returned from StackWalker API and never assigned to @Stable field. So there's no purpose of @Stable for bci field use. Except documentation. But documentation can be specified in the form o

Re: jdk.serial filter is not working for restricting depth of treemap in java

Hi Kumar, The other limits on the number of references (maxref) and size of the stream (maxbytes) cover the similar potential cases. The maxarray limit is targeted at limiting the size of arrays, different considerations apply to other data structures. Thanks, Roger On 7/29/19 11:07 PM, Kum

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

On 8/13/19 3:57 PM, Aleksey Shipilev wrote: On 8/13/19 3:33 AM, Mandy Chung wrote: On 8/12/19 5:13 PM, Frederic Parain wrote: 96 // VM adds 1 to the code index to StackFrameInfo::bci field such that 97 // zero (and negative values) indicates invalid BCI. So substract 1. http://cr.openjdk.jav

Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods

Hi Julia, Great, thanks. Brian > On Aug 13, 2019, at 9:12 AM, Julia Boes wrote: > > That's right, I created a separate issue for that (separate RFR to follow). > > Thanks, > > Julia > > On 13/08/2019 15:43, Brian Burkhalter wrote: >> Hi Julia, >> >> I think this looks OK but I would consid

Re: RFR: JDK-8226534: combination of windows options cause exception in MsiBundler

Looks good. - Alexey On 8/12/2019 8:38 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by adding --install-dir folders to RemoveFile table as per Wixs requirem

Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods

Hi Brian, That's right, I created a separate issue for that (separate RFR to follow). Thanks, Julia On 13/08/2019 15:43, Brian Burkhalter wrote: Hi Julia, I think this looks OK but I would consider expanding the scope to add the three methods to StrictMath as well. Either that or file a se

Re: RFR [14] 8217606: LdapContext#reconnect always opens a new connection

Hi Pavel, On 8/12/19 1:41 PM, Pavel Rappo wrote: Comments are inline. On 8 Aug 2019, at 18:59, Roger Riggs wrote: ... That's fine, a Semaphore can be used to wait for the first connection and then check with a different timeout for unexpected connections. I've sketched some possible imple

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

+1 on the bug fix. (I wouldn't spend time changing a bunch of tests that have a consistent style of their own. Having a few that look different is inconsistent and 'wrong'.  And I wouldn't fix even one of them. No one is mechanically looking for @summary in these tests and its just make-work.)

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Naoto, Thank you for adding the heading. you rock :-) > On Aug 13, 2019, at 11:06 AM, naoto.s...@oracle.com wrote: > > Hi Lance, > > I modified the headers of those two test cases as follows: > > http://cr.openjdk.java.net/~naoto/8211990/webrev.01/ > > Didn't bother changing others :-) >

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

Peter, Aleksey, On 8/13/19 2:17 AM, Peter Levart wrote: What are you trying to achieve with @Stable annotation? I chose the path of using it for at least documentation purpose that it is initialized once after :)  This field is not final as it's modified by the VM but it's a stable variabl

Re: RFR: 8211990: DateTimeException thrown when calculating duration between certain dates

Hi Lance, I modified the headers of those two test cases as follows: http://cr.openjdk.java.net/~naoto/8211990/webrev.01/ Didn't bother changing others :-) Naoto On 8/12/19 3:46 PM, Lance Andersen wrote: Hi Naoto On Aug 12, 2019, at 6:34 PM, naoto.s...@oracle.com

Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods

Hi Julia, I think this looks OK but I would consider expanding the scope to add the three methods to StrictMath as well. Either that or file a separate issue for that purpose. Thanks, Brian > On Aug 13, 2019, at 3:16 AM, Julia Boes wrote: > > This is a minor fix of the javadoc in java.lang.

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

On 8/13/19 3:33 AM, Mandy Chung wrote: > On 8/12/19 5:13 PM, Frederic Parain wrote: > 96 // VM adds 1 to the code index to StackFrameInfo::bci field such that > 97 // zero (and negative values) indicates invalid BCI. So substract 1. > > http://cr.openjdk.java.net/~mchung/jdk14/8193325/webrev.04/

Re: Fwd: Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods

Hi Roger, Changed - Thanks for reviewing! Cheers, Julia On 13/08/2019 14:48, Roger Riggs wrote: Hi Julia, Looks good. In the compatibility description, I would lead with the "No behavioral change". Since this is part of the specification, the code (implementation) is not relevant to the c

Re: Fwd: Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods

Hi Julia, Looks good. In the compatibility description, I would lead with the "No behavioral change". Since this is part of the specification, the code (implementation) is not relevant to the change. Thanks, Roger On 8/13/19 9:33 AM, Julia Boes wrote: Forwarding this thread to the right l

Fwd: Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods

Forwarding this thread to the right list! Forwarded Message Subject: Re: RFR: 8229337: java.lang.Math class doc should be adjusted regarding -Exact methods Date: Tue, 13 Aug 2019 13:51:02 +0100 From: Julia Boes To: Lance Andersen CC: jdk-...@openjdk.java.net

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

Hi Mandy, Just a question... On 8/12/19 10:24 PM, Mandy Chung wrote: Having a second thought, I'm keeping @Stable bci field while zero indicates an invalid BCI that makes it obvious that this field will be updated.  VM will set StackFrameInfo::bci to value+1. http://cr.openjdk.java.net/~mchu

Re: Review Request: JDK-8209005: Lookup.unreflectSpecial fails for default methods when Lookup.findSpecial works

Hi Mandy, This looks good to me. best regards, -- daniel On 31/07/2019 21:59, Mandy Chung wrote: Hi Peter, Daniel [...] This is correct when this class is a subclass of C.   A slight clarification to indicate that aMethod's declaring class is C might help.  I also fixed another typo: -