Re: RFR: JDK-8229750: Fix bad merge of JDK-8215447 patch

Looks good. On 8/14/2019 11:29 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - bad merge fix [1] https://bugs.openjdk.java.net/browse/JDK-8229750 [2] http://cr.openjdk

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

Much cleaner! Thumbs up! Fred > On Aug 14, 2019, at 15:42, Mandy Chung wrote: > > I have further discussion with Coleen and walkthrough the vframe > implementation. Here is what we confirm and agree. > > vframeStream::bci might return an invalid bci whereas javaVFrame::bci returns > a vali

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

On 8/14/19 3:42 PM, Mandy Chung wrote: I have further discussion with Coleen and walkthrough the vframe implementation.  Here is what we confirm and agree. vframeStream::bci might return an invalid bci whereas javaVFrame::bci returns a valid bci (compiledVFrame::bci adjusts invalid bci to 0

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi, In the CSR, please include *only* the specification of the API. Do not include the implementation or tests. The specification text has to stand on it own merits. Copy/paste patches are ok but the particular diff context information is unnecessary noise. Thanks, Roger On 8/14/19 3:21 PM,

Re: RFR JDK-8193325: StackFrameInfo::getByteCodeIndex returns wrong value if bci > 32767

I have further discussion with Coleen and walkthrough the vframe implementation.  Here is what we confirm and agree. vframeStream::bci might return an invalid bci whereas javaVFrame::bci returns a valid bci (compiledVFrame::bci adjusts invalid bci to 0). An invalid bci could happen when hitti

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi Daniel, That makes sense. So it meant to say "converts the long to int only if it's within the range of an integer" (to be "exact"). It may then add "throws an exception if not". But the original is fine, just my 2 cents. Best, Joe On 8/14/19 12:21 PM, Daniel Fuchs wrote: Hi Joe, On 14/

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi Joe, On 14/08/2019 20:15, Joe Wang wrote: The 2nd part is not necessary as that's what the "@throws" tag is for. Not withstanding the fact that this is a copy of the API doc from java.lang.Math, I'd argue that the second part is quite important. It's why the method is called exact, and is p

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

while you're here, could you please replace semicolon with comma:  916  * Returns the value of the {@code long} argument;  917  * throwing an exception if the value overflows an {@code int}. It seems to me the first sentence shall be the synopsis. The 2nd part is not necessary as tha

Re: RFR 8184432: Remove references to j...@sun.com from javax.sql.rowset.spi.SyncProvider

Hi Iris, Jon Gibbons reported the issue as part of some of his many clean-up activities to improve the javadocs Best, Lance. > On Aug 14, 2019, at 3:03 PM, Iris Clark wrote: > > HI, Lance. > > Looks good. > > I'm curious. How did you find this? > > iris > > -Original Message- >

RE: RFR 8184432: Remove references to j...@sun.com from javax.sql.rowset.spi.SyncProvider

HI, Lance. Looks good. I'm curious. How did you find this? iris -Original Message- From: Lance Andersen Sent: Wednesday, August 14, 2019 7:34 AM To: core-libs-dev Subject: RFR 8184432: Remove references to j...@sun.com from javax.sql.rowset.spi.SyncProvider Hi, Please review this

Re: RFR: JDK-8229750: Fix bad merge of JDK-8215447 patch

looks good /Andy On 8/14/19 2:29 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - bad merge fix [1] https://bugs.openjdk.java.net/browse/JDK-8229750 [2] http://cr.open

RFR: JDK-8229750: Fix bad merge of JDK-8215447 patch

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - bad merge fix [1] https://bugs.openjdk.java.net/browse/JDK-8229750 [2] http://cr.openjdk.java.net/~asemenyuk/8229750/webrev.00/ Thanks, Alexey

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

A tiny addition: On 8/14/19 10:56 AM, Ivan Gerasimov wrote: Hi Julia! In ExactArithTests.java 1) 169 long neg2 = -((long)x) ; please remove the superfluous space at the end. 2) 176 long neg2 = (long) x - 1L; should be `long neg2 = -((long)x);` In StrictMath.java 3) wh

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi Julia! In ExactArithTests.java 1) 169 long neg2 = -((long)x) ; please remove the superfluous space at the end. 2) 176 long neg2 = (long) x - 1L; should be `long neg2 = -((long)x);` In StrictMath.java 3) while you're here, could you please replace semicolon with comma

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi Julia, Brian > On Aug 14, 2019, at 12:08 PM, Brian Burkhalter > wrote: > > Hi Julia, > > I think you need “@since 14” on the new StrictMath methods Yes, as these are new methods to this class the above would be correct vs 1.8 > . I don’t see any other problems. Looks OK to me For the CSR

Re: RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi Julia, I think you need “@since 14” on the new StrictMath methods. I don’t see any other problems. Thanks, Brian > On Aug 14, 2019, at 9:01 AM, Julia Boes wrote: > > This fix adds decrementExact(), incrementExact(), and negateExact() to > java.lang.StrictMath. The methods were added to j

RFR: 8229485: Add decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath

Hi, This fix adds decrementExact(), incrementExact(), and negateExact() to java.lang.StrictMath. The methods were added to java.lang.Math previously [1] and should have been added to java.lang.StrictMath for consistency. Bug: https://bugs.openjdk.java.net/browse/JDK-8229485 Webrev: http:/

Re: RFR 8184432: Remove references to j...@sun.com from javax.sql.rowset.spi.SyncProvider

+1 On 8/14/19 10:33 AM, Lance Andersen wrote: Hi, Please review this trivial patch which removes references to j...@sun.com and mention of a list of available SyncProviders which does not exist. $ hg diff diff -r cffcc4c5a5ba src/java.sql.rowset/share/classes/jav

RFR 8184432: Remove references to j...@sun.com from javax.sql.rowset.spi.SyncProvider

Hi, Please review this trivial patch which removes references to j...@sun.com and mention of a list of available SyncProviders which does not exist. $ hg diff diff -r cffcc4c5a5ba src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncProvider.java --- a/src/jav