On Mon, Aug 19, 2019 at 12:17 AM Claes Redestad
wrote:
> I'd add a comment that protocol is assumed to be "file",
URLClassPath.FileLoader class already has a comment "from a file URL that
refers to a directory",
but anyway added comment for constructor.
and perhaps make the constructor private
On 8/19/2019 8:17 PM, Andy Herrick wrote:
On 8/19/2019 7:51 PM, Alexey Semenyuk wrote:
Looks good.
BTW, we can statically link with runtime app launcher and avoid
copying a bunch of MS dll-s to install bin directory.
I'm not sure if that's true, but it would be great if it is. The app
On 8/19/2019 7:51 PM, Alexey Semenyuk wrote:
Looks good.
BTW, we can statically link with runtime app launcher and avoid
copying a bunch of MS dll-s to install bin directory.
I'm not sure if that's true, but it would be great if it is. The app
launcher creates the virtual machine and runs
looks good.
/Andy
On 8/19/2019 7:23 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by statically linking with runtime.
[1] https://bugs.openjdk.java.net/brows
Looks good.
BTW, we can statically link with runtime app launcher and avoid copying
a bunch of MS dll-s to install bin directory.
- Alexey
On 8/19/2019 7:23 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the
There is a bunch or resource names with "deb-" prefix. My assumption
about this prefix was that these names are related to control files for
Debian packaging, i.e. special files that go into DEBIAN directory.
copyright file used to be one of them. However this was not correct.
There should be n
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Fixed by statically linking with runtime.
[1] https://bugs.openjdk.java.net/browse/JDK-8229788
[2] http://cr.openjdk.java.net/~almatvee/8229788/webr
Bug: https://bugs.openjdk.java.net/browse/JDK-8229899
Webrev: http://cr.openjdk.java.net/~aeubanks/8229899/webrev.00/
final boolean isInvalid() {
if (status == null) {
status = (this.path.indexOf('\u') < 0) ? PathStatus.CHECKED
This is a good idea to explore. We should keep this patch to focus on
switching ASM.I will file a JBS issue for this suggestion.
Mandy
On 8/19/19 2:19 PM, Remi Forax wrote:
A follow up should to use constant dynamic (introduce in Java 11) to get the
j.l.r.Method object instead of pre-calcula
Thanks for doing that. I've only skimmed through the patch and I’d recommend
that no matter if the changes are adequate or not there should be a test [1]:
"...A unit test, written for the jtreg test harness, that validates your
change. The test should fail when run against a build without the ch
Looks good.
-- Kevin
On 8/19/2019 9:56 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix all permission related issues reported by lintian
- cleanup control files to
Looks good. I do have one question. I see that you changed the resource
name from "resource.deb-copyright" to "resource.copyright-file". Will
this property be used for the RPM copyright / license file, too? If not,
would it be better to keep "deb" in the name?
-- Kevin
On 8/19/2019 9:25 AM,
looks good.
/Andy
On 8/19/2019 12:56 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix all permission related issues reported by lintian
- cleanup control files to ad
Looks good.
Thanks,
Alexander
On 8/19/2019 2:16 PM, Kevin Rushforth wrote:
OK. Looks good.
-- Kevin
On 8/19/2019 2:09 PM, Andy Herrick wrote:
On 8/19/19 4:53 PM, Kevin Rushforth wrote:
The following will take the last in the list of extensions and use
that:
+ entryName = ext.toUpperCase
A follow up should to use constant dynamic (introduce in Java 11) to get the
j.l.r.Method object instead of pre-calculating all of them in the static init
block.
The idea is that a ldc on a constant dynamic with bootstrap method that takes a
MethodHandle as parameter (as boostrap argument) can r
OK. Looks good.
-- Kevin
On 8/19/2019 2:09 PM, Andy Herrick wrote:
On 8/19/19 4:53 PM, Kevin Rushforth wrote:
The following will take the last in the list of extensions and use that:
+ entryName = ext.toUpperCase() + "File";
entryName is both set and used within the "for (String ext :
exte
Looks good.
Thanks,
Alexander
On 8/19/2019 9:56 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix all permission related issues reported by lintian
- cleanup control
On 8/19/19 4:41 PM, Alexey Semenyuk wrote:
Looks good.
Just curious why changes in FileAssociationsBase.java files?
It doesn't really matter in a test association, but experimental
mime-types (those not registered win IANA) are supposed to be of the
form application/x-...
/Andy
- Alex
On 8/19/19 4:53 PM, Kevin Rushforth wrote:
The following will take the last in the list of extensions and use that:
+ entryName = ext.toUpperCase() + "File";
entryName is both set and used within the "for (String ext :
extensions)" block.
Also, did you mean to upper-case the extension? I n
Hello list
Please find the attached patch that fixes JDK-8228580.
It works the similar way UDP timeout does: calculate the initial
timeout from retry attempt, and account for duration of every blocking
call on the TCP socket.
I am listed as Author[1] on "jdk" project.
[1] https://openjdk.java.n
The following will take the last in the list of extensions and use that:
+ entryName = ext.toUpperCase() + "File";
Also, did you mean to upper-case the extension? I note that "File" isn't
upper-case, nor is the prefix when there isn't an extension.
-- Kevin
On 8/19/2019 12:33 PM, Andy Herr
Looks good.
Just curious why changes in FileAssociationsBase.java files?
- Alexey
On 8/19/2019 3:33 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk
Looks good.
Thanks,
Alexander
On 8/19/2019 9:25 AM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- change format of the default copyright file to comply with Debian
packa
Please review a potential fix of [1].
BigInteger.toString(int radix) for instances with more than 20 ints in the
magnitude array works by recursively decomposing the BigInteger into smaller
BigIntegers which have no more than 20 ints in their magnitude array and then
uses the internal method sm
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8229795
[2] http://cr.openjdk.java.net/~herrick/8229795/
/Andy
looks good to me.
/Andy
On 8/19/19 12:25 PM, Alexey Semenyuk wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- change format of the default copyright file to comply with Debian
packaging re
Hi Andrew,
Just a minor style thing in MapSyncFail test: can "true" and "false"
(the mode) be "READ_WRITE_SYNC" and "READ_ONLY_SYNC" instead?
-Dmitry
On 8/19/19 2:29 PM, Andrew Dinn wrote:
Hi Alan,
...
I renamed the test to MapSyncFail and modified it to run without
restrict
Am 2019-08-19 um 19:09 schrieb Volker Simonis:
Hi Michael,
have you had a look at the recently added enhancements for zipfs:
8213031: (zipfs) Add support for POSIX file permissions
https://bugs.openjdk.java.net/browse/JDK-8213031
The corresponding CSR
8213082: (zipfs) Add support for POSIX
Hi Michael,
have you had a look at the recently added enhancements for zipfs:
8213031: (zipfs) Add support for POSIX file permissions
https://bugs.openjdk.java.net/browse/JDK-8213031
The corresponding CSR
8213082: (zipfs) Add support for POSIX file permissions
https://bugs.openjdk.java.net/brow
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- fix all permission related issues reported by lintian
- cleanup control files to address issues reported by lintian
- fix jtreg tests
- change package
Am 2019-08-19 um 18:48 schrieb Alan Bateman:
On 19/08/2019 16:39, Osipov, Michael wrote:
:
Note that this also happens when the file is already there. The
permissions are *not* retained and this causes here a lot of grief.
zip(1) does not suffer from this nor does ZipOutputStream as you ca
On 19/08/2019 16:39, Osipov, Michael wrote:
:
Note that this also happens when the file is already there. The
permissions are *not* retained and this causes here a lot of grief.
zip(1) does not suffer from this nor does ZipOutputStream as you can see.
I'd expect that reading the attributes f
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- change format of the default copyright file to comply with Debian
packaging requirements;
- install copyright file in proper location to comply with
Folks,
please evaluate this bug. I am astounded that this hasn't been
reported/fixed before.
We create ZIP (zipfs provider) files with a default umask of 027. Those
files are read via NFS and CIFS with Unix group permissions from other
processes, may be on Windows or HP-UX (Tomcat).
Consid
Hi Mandy,
On 8/16/19 8:59 PM, Mandy Chung wrote:
Hi Roger,
Thanks for doing this. Replacing ancient bytecode generators makes
it much easier to support new features like value types.
The diff of ProxyGenerator is not quite right (might be due to
the rename?) as some code are unchanged but sho
On 19/08/2019 12:29, Andrew Dinn wrote:
:
I renamed the test to MapSyncFail and modified it to run without
restriction to a specific os or cpu.
I also generalized it to run twice with a boolean arg which selects mode
READ_ONLY_SYNC on the first run and READ_WRITE_SYNC on the second one.
The log
The Assignee field in JBS should be updated.
This syntax is so weird it's probably not caught by
https://errorprone.info/bugpattern/MixedArrayDimensions
If not, you could try writing your own errorprone check for it.
On Thu, Aug 15, 2019 at 9:47 AM Evgeny Mandrikov
wrote:
> Hello!
>
> Please re
Hi Alan,
Thanks for looking at the patch again. I think I have addressed all your
concerns (comments inline). Webrev and retest results at the end.
On 16/08/2019 11:39, Alan Bateman wrote:
> I think the main changes since I looked at it previously have been in
> the tests.
That's mostly it. I di
On 19/08/2019 09:02, Aleksey Shipilev wrote:
On 8/15/19 9:01 PM, Aleksey Shipilev wrote:
On 8/15/19 6:46 PM, Evgeny Mandrikov wrote:
[1] http://cr.openjdk.java.net/~godin/8152467/webrev.00/
This looks good.
I also believe this qualifies as trivial patch.
Yes, and looks okay although it's prob
Hi,
May I have review for "JDK-8229871: Imporve performance of Method.copy()
and leafCopy()"?
Method.copy() and leafCopy() creates a copy of a Method object with
sharing MethodAccessor object. Since the methodAccessor field is a
volatile variable, copying this field needs memory fence to ensur
On 8/15/19 9:01 PM, Aleksey Shipilev wrote:
> On 8/15/19 6:46 PM, Evgeny Mandrikov wrote:
>> [1] http://cr.openjdk.java.net/~godin/8152467/webrev.00/
>
> This looks good.
I also believe this qualifies as trivial patch. I will be sponsoring the push.
Now running through
jdk-submit, to avoid surpr
> On 18 Aug 2019, at 23:18, Claes Redestad wrote:
>
> Hi,
>
> On 2019-08-18 21:22, Evgeny Mandrikov wrote:
>> [1] https://cr.openjdk.java.net/~godin/8139820/webrev.00/
>
> looks ok to me.
+1 seems ok to me.
-Chris
42 matches
Mail list logo
