jpackage and macOS Catalina notarization

2020-01-03 Thread James Elliott
Hello, everyone, I finally found this list, as well as a way to search it, and so hope this question is relevant and appropriate and not already answered. For some time I have been using an old javapackager along with a newer release of jlink to create native macOS installers for a free,

Re: [15] RFR: 8227313: Support monetary grouping separator in DecimalFormat/DecimalFormatSymbols

2020-01-03 Thread Joe Wang
Hi Naoto, Historical indeed, and true, it was not exposed prior to JDK6. Just need to make sure other classes within the package won't accidentally use its set method or mark it if it's 'deprecated'. But it's a minor issue. I'm fine with your changeset as is. Best, Joe On 1/3/20 1:24 PM,

Re: [15] RFR: 8227313: Support monetary grouping separator in DecimalFormat/DecimalFormatSymbols

2020-01-03 Thread naoto . sato
Hi Joe, Thanks again for the review. The reason the way it is is all historical. percent/perMill/minusSign all had public APIs for the 'char' version since inception, and text version APIs were added later (JDK13). Thus they had to be in sync (both fields are accessible through API). On the

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

2020-01-03 Thread Bob Vandette
Here are a few comments from scanning the webrev. It looks like you can remove line 151 http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/06-incremental/webrev/src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java.sdiff.html 151 int[] ints = new

Re: [15] RFR: 8227313: Support monetary grouping separator in DecimalFormat/DecimalFormatSymbols

2020-01-03 Thread Joe Wang
Hi Naoto, The change looks fine to me as only monetaryGroupingSeparator was added to equals. I can't help to note though that, all fields participated in the equals calculation except exponential. Some of the other fields are in similar situations (one is public and the other not), e.g.

Re: [15] RFR: 8227313: Support monetary grouping separator in DecimalFormat/DecimalFormatSymbols

2020-01-03 Thread naoto . sato
Hi Joe, I revised the changeset, as the cached hash code in DecimalFormatSymbols needs to be recalculated when any of the relevant fields is mutated. Here is the updated webrev: http://cr.openjdk.java.net/~naoto/8227313/webrev.02/ Naoto On 1/2/20 2:19 PM, Joe Wang wrote: Happy New Year,